[MIR] Promote ruby-ethon to main as a pcs dependency

Bug #1990571 reported by Lucas Kanashiro
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ruby-ethon (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[Availability]

The package ruby-ethon is already in Ubuntu universe.

The package ruby-ethon build for the architectures it is designed to work on.

It currently builds and works for architectures: amd64 (arch:all).

Link to package [[https://launchpad.net/ubuntu/+source/ruby-ethon|ruby-ethon]]

[Rationale]

The package ruby-ethon is required in Ubuntu main for pcs promotion.

Ideally, we expect that ruby-ethon (and pcs) will be promoted in the "L" development cycle. The idea is to promote only the ruby-ethon binary.

[Security]

Required links:

https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=ruby-ethon

No CVE was found.

Nothing was found searching in the OSS security mailing list archive.

https://ubuntu.com/security/cves?package=ruby-ethon

No CVE was found.

No CVEs/security issues in this software in the past.

No `suid` or `sgid` binaries.

No executables in `/sbin` and `/usr/sbin`.

Package does not install services, timers or recurring jobs.

Packages does not open privileged ports (ports < 1024).

Packages does not contain extensions to security-sensitive software
(filters, scanners, plugins, UI skins, ...).

[Quality assurance - function/usage]

The package works well right after install.

[Quality assurance - maintenance]

The package is maintained well in Debian/Ubuntu and has not too many
and long term critical bugs open

- Ubuntu https://bugs.launchpad.net/ubuntu/+source/ruby-ethon/+bug
- Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=ruby-ethon

The package does not deal with exotic hardware we cannot support.

[Quality assurance - testing]

The package runs a test suite on build time, if it fails
it makes the build fail, link to build log:

https://launchpadlibrarian.net/577919062/buildlog_ubuntu-jammy-amd64.ruby-ethon_0.15.0-2_BUILDING.txt.gz

The package runs an autopkgtest, and is currently passing on
this list of architectures: amd64, arm64, armhf, ppc64el, s390x.

Link to test logs:

https://autopkgtest.ubuntu.com/packages/ruby-ethon

The package does have not failing autopkgtests right now. Only in i386, where some dependencies are not installable.

[Quality assurance - packaging]

debian/watch is present and works.

debian/control defines a correct Maintainer field.

Lintian overrides are not present. There is no output of `lintian --pedantic` against Kinetic version.

This package does not rely on obsolete or about to be demoted packages.

The package will not be installed by default.

Packaging and build is easy, link to d/rules:

https://git.launchpad.net/~git-ubuntu-import/ubuntu/+source/ruby-ethon/tree/debian/rules

[UI standards]

Application is not end-user facing (does not need translation).

[Dependencies]

There are further dependencies that are not yet in main, MIR for them
is at:

- ruby-ffi MIR bug: https://bugs.launchpad.net/ubuntu/+source/ruby-ffi/+bug/1990570
- ruby-mime-types MIR bug: https://bugs.launchpad.net/ubuntu/+source/ruby-mime-types/+bug/1990569

[Standards compliance]

This package correctly follows FHS and Debian Policy.

[Maintenance/Owner]

Owning Team will be Server.

Team is not yet, but will subscribe to the package before promotion.

This does not use static builds.

This does not use vendored code.

This package is not rust based.

The package has been built in the archive more recently than the last
test rebuild.

[Background information]

The Package description explains the package well.

Upstream Name is: ethon.

Link to upstream project: https://github.com/typhoeus/ethon

description: updated
Changed in ruby-ethon (Ubuntu):
assignee: nobody → Didier Roche-Tolomelli (didrocks)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Review package for ruby-ethon

[Summary]
MIR team ACK once the MIRs dependencies are solved. Keep in mind that you need to subscribe the server team before promotion. Note that we need first the dependencies to be MIR acked first:
- ruby-ffi MIR bug: https://bugs.launchpad.net/ubuntu/+source/ruby-ffi/+bug/1990570
- ruby-mime-types MIR bug: https://bugs.launchpad.net/ubuntu/+source/ruby-mime-types/+bug/1990569

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
  - ruby-ethon checked with `check-mir`
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

[Security]
OK:
- history of CVEs does not look concerning.
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not open a port/socket
- does not process arbitrary web content (only binding to libcurl, which is doing the parsing work)
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- autokpgtests are running and passing (those are apparently autogenerated)
- test suite fails will fail the build upon error.
- no new python2 dependency

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Upstream update history is good
- Latest release is packaged.
- Debian/Ubuntu update history is good
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list

[Upstream red flags]
OK:
- no Warning/Errors during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case

Changed in ruby-ethon (Ubuntu):
assignee: Didier Roche-Tolomelli (didrocks) → nobody
status: New → Incomplete
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

(Setting as incomplete until we have the dep MIRs acked)

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

FWIW both dep MIRs got ACKed.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Subsription is present, dependencies acked -> move this to the correct "ready" state.

Changed in ruby-ethon (Ubuntu):
status: Incomplete → In Progress
Revision history for this message
Mark Esler (eslerm) wrote :

Security relevant issues and pull requests in https://github.com/typhoeus/ethon

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This was not even meant to go into the security queue, but thanks Mark!
Lucas will have a look at merging 0.16 to catch all that.

Worst case (really worst) it would only appear in 23.10, but that is way before anything long term (24.04). So it should be fine.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I uploaded version 0.16.0-1 to Debian unstable:

https://tracker.debian.org/news/1409853/accepted-ruby-ethon-0160-1-source-into-unstable/

It should be in lunar soon.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Showing up in component mismatch now as planned.

Changed in ruby-ethon (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Promoted together with the full PCS stack, details see https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1953341/comments/13

Changed in ruby-ethon (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.