Mahara

signoff/verify have two ways to work out signable/verifiable status

Bug #1991031 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 22.10.0

Bug Description

One is being used on the progress completion page, eg the $view->get_progress_action('owner')

And the other is being used on individual pages, eg the ArtefactTypePeerassessment::is_signable($view, false)

Both are lacking some things we need to check for

We need to consolidate this down to one function that can be used in both places

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.10.0
importance: Undecided → High
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13183

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/13183
Committed: https://git.mahara.org/mahara/mahara/commit/2bafdde76faf597127e9d21231f781bcfa72b93a
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit 2bafdde76faf597127e9d21231f781bcfa72b93a
Author: Robert Lyon <email address hidden>
Date: Wed Sep 28 14:48:50 2022 +1300

Bug 1991031: Consolidate the checking from signoff/verify

To one class/function

Change-Id: Ia4fc012f61c139538f7a548f45d29535b3359d1f
Signed-off-by: Robert Lyon <email address hidden>

Doris Tam (doristam)
Changed in mahara:
status: In Progress → Fix Committed
Doris Tam (doristam)
Changed in mahara:
status: Fix Committed → Won't Fix
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.