Ubuntu
hal package

hal ignores virtual network interfaces

Bug #199269 reported by Kees Cook
6
Affects Status Importance Assigned to Milestone
HAL
Fix Released
Medium
hal (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: hal

hald does not store information about vlan or bridge interfaces due to the lack of matching parent sysfs paths and "device" symlink.

See original description
Revision history for this message
In , Kees Cook (kees) wrote :

Created an attachment (id=14372)
additional failure debugging

Revision history for this message
In , Kees Cook (kees) wrote :

Also, it seems that using the "device" symlink is deprecated by the kernel, as documented in the Linux kernel's Documentation/sysfs-rules.txt file (e.g. "Assuming the existence of the "device"-link for a device in /sys/devices/ is a bug in the application.")

Revision history for this message
In , Kees Cook (kees) wrote :

Created an attachment (id=14390)
additional device detection failure debugging

Fixed debug patch to actually compile. ;)

Revision history for this message
In , Kees Cook (kees) wrote :

Created an attachment (id=14391)
do not ignore virtual network devices

This is a proposed patch to allow hal to see all network devices, including virtual ones. As done with other virtual devices, the parent is recorded as "/org/freedesktop/Hal/devices/computer".

Revision history for this message
In , Kees Cook (kees) wrote :

Created an attachment (id=14392)
do not ignore virtual network devices

Cleaned up patch -- using MAC address detection for parent-finding was simply wrong.

Revision history for this message
In , Danny Kukawka (danny-kukawka) wrote :

(In reply to comment #2)
> Also, it seems that using the "device" symlink is deprecated by the kernel, as
> documented in the Linux kernel's Documentation/sysfs-rules.txt file (e.g.
> "Assuming the existence of the "device"-link for a device in /sys/devices/ is a
> bug in the application.")

And what prints: ls -alF /sys/class/net

Revision history for this message
In , Kees Cook (kees) wrote :

$ ls -alF /sys/class/net
total 0
drwxr-xr-x 2 root root 0 Feb 20 23:00 ./
drwxr-xr-x 38 root root 0 Feb 20 23:00 ../
lrwxrwxrwx 1 root root 0 Feb 20 23:00 br0 -> ../../devices/virtual/net/br0/
lrwxrwxrwx 1 root root 0 Feb 20 23:00 eth0 -> ../../devices/pci0000:00/0000:00:19.0/net/eth0/
lrwxrwxrwx 1 root root 0 Feb 20 23:00 eth0.10 -> ../../devices/virtual/net/eth0.10/
lrwxrwxrwx 1 root root 0 Feb 20 23:00 eth0.3 -> ../../devices/virtual/net/eth0.3/
lrwxrwxrwx 1 root root 0 Feb 20 23:00 lo -> ../../devices/virtual/net/lo/
lrwxrwxrwx 1 root root 0 Feb 20 23:00 vnet0 -> ../../devices/virtual/net/vnet0/

Revision history for this message
In , Kees Cook (kees) wrote :

Note that this patch, as it stands, creates some additional work in existing clients that process the list of network interfaces (e.g. network-manager). They need to be adjusted to deal with virtual network interfaces too.

Revision history for this message
Kees Cook (kees) wrote :

Binary package hint: hal

hald does not store information about vlan or bridge interfaces due to the lack of matching parent sysfs paths and "device" symlink.

Revision history for this message
Kees Cook (kees) wrote :

This was fixed in 0.5.10-5ubuntu7, but caused other hal-aware applications to have problems. See bug 199140.

Changed in hal:
assignee: nobody → pitti
status: New → Fix Released
assignee: pitti → keescook
importance: Undecided → Wishlist
Revision history for this message
Kees Cook (kees) wrote :

This fix appears to have caused bug 199140 and bug 198541. I recommend it be reverted based on how late we are in the release cycle.

Changed in hal:
assignee: keescook → pitti
importance: Wishlist → High
status: Fix Released → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

I reverted it in bzr head. I can re-enable it if Alex' evaluation of fixing network-manager to ignore them will turn out positively.

Revision history for this message
Martin Pitt (pitti) wrote :

I uploaded a new hal into hardy which reverts the recent patch to detect virtual network interfaces. This will be reapplied in Intrepid once the other bugs are sorted out.

Changed in hal:
importance: High → Wishlist
status: In Progress → Confirmed
assignee: pitti → nobody
Bug Watch Updater (bug-watch-updater)
Changed in hal:
status: Unknown → Confirmed
Revision history for this message
In , Danny Kukawka (danny-kukawka) wrote :

commit d4f1c6eb85ccb45d45641f30d6ea04dbb046fa28
Author: Danny Kukawka <email address hidden>
Date: Mon Oct 20 15:18:26 2008 +0200

    add support for virtual network devices

    Added support for virtual network devices as e.g. openvpn tunnel
    interfaces or loopback devices. Added new net subnamespace
    net.loopback for ARPHRD_LOOPBACK interfaces.

Bug Watch Updater (bug-watch-updater)
Changed in hal:
status: Confirmed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Upstream patch is in Jaunty.

Changed in hal:
status: Confirmed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in hal:
importance: Unknown → Medium
Bug Watch Updater (bug-watch-updater)
Changed in hal:
importance: Medium → Unknown
Bug Watch Updater (bug-watch-updater)
Changed in hal:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.