[UBUNTU 22.04] dbginfo.sh updates for /bin/dash shell compatibility

Bug #1996477 reported by bugproxy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
Medium
Skipper Bug Screeners
s390-tools (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned
Lunar
Invalid
Undecided
Unassigned

Bug Description

SRU Justification:
==================

[ Impact ]

 * The dbginfo.sh script fails on system (actually shells) that run dash,
   due to some incompatibilities in dbginfo.sh (with using 'type').

 * The script fails with a with parameter error.

[ Fixes ]

 * 92b84092 92b84092077f5238f8067f24e9fc330ddefb4525 "dbginfo.sh: ensure type commands compatible with dash"

 * 9f93af61 9f93af614f7463317ec56af5a6484f66386af797 "dbginfo.sh: ensure compatibility with /bin/dash"

[ Test Plan ]

 * Use a user account that has dash as default shell,
   or simply call dash in whatever shell you are running.

 * Make sure the s390-tools are installed (but it's mandatory for s390x)
   since dbginfo.sh is included into this.

 * Now call /usr/sbin/dbginfo.sh (from within a dash shell)
   and watch out for any errors,
   esp. some caused by issues with parameters,
   like 'type' is not supporting '-t'.

[ Where problems could occur ]

 * The changes in handling the parameters could break the dbginfo.sh
   on other shells, like bash (which is the default in Ubuntu).

 * Fortunately the changes in the above commits are pretty traceable.

__________

Description: dbginfo.sh: incompatible commands with /bin/dash shell
Symptom: subsection data collection fails while running in /bin/dash shell
               - type is failing with parameter error

Problem: reduced data collection
Solution: rewrite in compatible way
Component: s390-tools

the master commits in s390tools v2.24.9 are:

92b8409 92b84092077f5238f8067f24e9fc330ddefb4525 "dbginfo.sh: ensure type commands compatible with dash"

9f93af6 9f93af614f7463317ec56af5a6484f66386af797 "dbginfo.sh: ensure compatibility with /bin/dash"

source: https://github.com/ibm-s390-linux/s390-tools/blob/master/scripts/dbginfo.sh

bugproxy (bugproxy)
tags: added: architecture-s3903164 bugnameltc-200479 severity-medium targetmilestone-inin---
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → linux (Ubuntu)
Frank Heimes (fheimes)
affects: linux (Ubuntu) → s390-tools (Ubuntu)
Frank Heimes (fheimes)
Changed in s390-tools (Ubuntu):
assignee: Skipper Bug Screeners (skipper-screen-team) → nobody
Changed in ubuntu-z-systems:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
importance: Undecided → Medium
Frank Heimes (fheimes)
description: updated
Frank Heimes (fheimes)
summary: - [UBUNTU 22.04] dbginfo.sh: updates in reagard to /bin/dash shell
+ [UBUNTU 22.04] dbginfo.sh updates for /bin/dash shell compatibility
Revision history for this message
Frank Heimes (fheimes) wrote :

Updating status on lunar to invalid, since lunar gets a new s390-tools major release that has these patches included.

Changed in s390-tools (Ubuntu Lunar):
status: New → Invalid
Revision history for this message
Frank Heimes (fheimes) wrote :

These patches are included in the following s390-tools package updates:

kinetic v2.23.0-0ubuntu1.1 - incl. fixes lp1996069+lp1996477

jammy v2.20.0-0ubuntu3.2 - incl. fixes lp1974109+lp1959987+lp1990520+lp1990524+lp1996069+lp1996477

Test packages are build in PPAs:
kinetic: https://launchpad.net/~fheimes/+archive/ubuntu/lp1996069+lp1996477
jammy: https://launchpad.net/~fheimes/+archive/ubuntu/lp1974109+lp1959987+lp1990520+lp1990524+lp1996069+lp1996477

And the debdiffs are attached (s390-tool and s390-tools-signed for K and J).

Changed in ubuntu-z-systems:
status: New → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hey Frank! This SRU doesn't seem to have the necessary SRU information in the description. Can you update it?

Revision history for this message
Frank Heimes (fheimes) wrote :

Excuse me Łukasz, I missed that - just added the needed SRU Justification.

description: updated
Frank Heimes (fheimes)
description: updated
Frank Heimes (fheimes)
description: updated
description: updated
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted s390-tools into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/s390-tools/2.23.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in s390-tools (Ubuntu Kinetic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello bugproxy, or anyone else affected,

Accepted s390-tools-signed into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/s390-tools-signed/2.23.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello bugproxy, or anyone else affected,

Accepted s390-tools into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/s390-tools/2.20.0-0ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in s390-tools (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello bugproxy, or anyone else affected,

Accepted s390-tools-signed into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/s390-tools-signed/2.20.0-0ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Frank Heimes (fheimes) wrote :

I successfully verified the packages s390-tools*3.2_s390x.deb on jammy (see attachment).

Hence updating the tag accordingly ...

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Frank Heimes (fheimes) wrote :

I successfully verified the packages s390-tools*1.1_s390x.deb on kinetic (see attachment).

Hence updating the tags accordingly ...

tags: added: verification-done verification-done-kinetic
removed: verification-needed verification-needed-kinetic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package s390-tools - 2.23.0-0ubuntu1.1

---------------
s390-tools (2.23.0-0ubuntu1.1) kinetic; urgency=medium

  * d/p/lp1996069-zipl-boot-add-secure-boot-trailer.patch
    Add secure boot trailer in zipl stage 3 to keep compatibility with
    upcoming IBM zSystems firmware updates. (LP: #1996069)
  * Add d/p/lp1996477-dbginfo.sh-ensure-type-commands-compatible-with-dash.patch
    and d/p/lp1996477-dbginfo.sh-ensure-compatibility-with-bin-dash.patch
    to achieve dbginfo.sh compatibility with /bin/dash shell. (LP: #1996477)

 -- Frank Heimes <email address hidden> Wed, 16 Nov 2022 16:48:54 +0100

Changed in s390-tools (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for s390-tools has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package s390-tools - 2.20.0-0ubuntu3.2

---------------
s390-tools (2.20.0-0ubuntu3.2) jammy; urgency=medium

  * Fix zipl segfaults when "parameters=" is missing (LP: #1974109) with:
    d/p/6ff8202f-zipl-Add-missing-check-for-a-nullpointer.patch
  * Add KVM Secure Execution Attestation Userspace Tool to enhance secure
    execution (hardware feature: FC 115) exploitation (LP: #1959987) with:
    d/p/38639269-libpv-New-library-for-PV-tools.patch
    d/p/3ab06d77-pvattest-Create-perform-and-verify-attestation-measu.patch
    d/p/26148740-pvattest-tools-Add-tool-for-attestation.patch
  * Fix re-enciphering of EP11 identity key of KMIP plugin (LP: #1990520) with:
    d/p/4e2ebe03-libseckey-Fix-re-enciphering-of-EP11-secure-key.patch
  * Fix KMIP plugin fails to connection to KMIP server (LP: #1990524) with:
    d/p/6c5c5f7e-libseckey-Adapt-keymgmt_match-implementation-to-Open.patch
  * d/p/5768d55-zipl-boot-add-secure-boot-trailer.patch
    Add secure boot trailer in zipl stage 3 to keep compatibility with
    upcoming IBM zSystems firmware updates. (LP: #1996069)
  * Add d/p/92b8409-dbginfo.sh-ensure-type-commands-compatible-with-dash.patch
    and d/p/9f93af6-dbginfo.sh-ensure-compatibility-with-bin-dash.patch
    to achieve dbginfo.sh compatibility with /bin/dash shell. (LP: #1996477)

 -- Frank Heimes <email address hidden> Wed, 16 Nov 2022 18:14:00 +0200

Changed in s390-tools (Ubuntu Jammy):
status: Fix Committed → Fix Released
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: In Progress → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2023-01-23 11:00 EDT-------
successfully tested with auto update/upgrade function on 22.04: receiving the update as script version 2.20.0-build-20221202

bugproxy (bugproxy)
tags: added: targetmilestone-inin2204
removed: targetmilestone-inin---
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.