Network Freeze With Broadcom DKMS Wireless Driver

Bug #1998039 reported by Brett Holman
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bcmwl (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned

Bug Description

Hardware: Macbook Pro 9,2 with Broadcom BCM4331 chipset
Ubuntu Release: 22.10
Kernel: 5.19.0-23-generic

Symptoms:
Warning traces in the dmesg. Network timeout/freeze for >1 minute (possibly related to suspend/resume).

This has been fixed in Arch and Debian already [1].

$ lsmod | grep wl
wl 6467584 0
cfg80211 1040384 1 wl

$ dpkg -l | grep -i broadcom
ii bcmwl-kernel-source 6.30.223.271+bdcom-0ubuntu9 amd64 Broadcom 802.11 Linux STA wireless driver source

Test Case:
==========
This is reproducible by forcing the computer to sleep and then waking it back up.

Regression Potential:
=====================
Since this is due to an intentional ABI change in the upstream kernel, regression potential is low.

[1] https://salsa.debian.org/diegoe/broadcom-sta/-/commit/720ac7c23d78d771219ed4c9228daa2cbb88a4ca

Revision history for this message
Brett Holman (holmanb) wrote :
Revision history for this message
Brett Holman (holmanb) wrote :
Revision history for this message
Brett Holman (holmanb) wrote :
Revision history for this message
Brett Holman (holmanb) wrote :
Brett Holman (holmanb)
summary: - Network Freeze With In Tree Broadcom Driver
+ Network Freeze With Broadcom DKMS Wireless Driver
Brett Holman (holmanb)
description: updated
Revision history for this message
Brett Holman (holmanb) wrote :

I can reproduce this bug locally by suspending my machine. This appears to always reproduce on 5.19.0-23-generic.

Brett Holman (holmanb)
no longer affects: linux-meta (Ubuntu)
Revision history for this message
Brett Holman (holmanb) wrote :

The patch in Debian doesn't apply cleanly, so I refreshed the patch for Ubuntu. Building and testing locally with the refreshed version appears to work (my reproducer doesn't reproduce with this package).

Steps:

1) Add new patch line in dkms config: debian/dkms.conf.in
2) add patch to debian/patches
3) build (dpkg-buildpackage -us -uc)
4) install and test

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0041-dev-addr-access.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.30.223.271+bdcom-0ubuntu10

---------------
bcmwl (6.30.223.271+bdcom-0ubuntu10) lunar; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0041-dev-addr-access.patch (LP: #1998039):
    - Fix netdev->dev_addr access with kernels >= 5.17.
  * debian/dkms.conf.in,
    debian/patches/0042-add-support-for-linux-6.x.patch (LP: #1999009):
    - Support linux >= 6.1

 -- Andrea Righi <email address hidden> Wed, 07 Dec 2022 06:38:54 +0000

Changed in bcmwl (Ubuntu):
status: New → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Can we get the description updated with a test case and some regression potential? Thank you.

Changed in bcmwl (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Brett, or anyone else affected,

Accepted bcmwl into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/bcmwl/6.30.223.271+bdcom-0ubuntu10~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Brett, or anyone else affected,

Accepted bcmwl into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/bcmwl/6.30.223.271+bdcom-0ubuntu10~22.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in bcmwl (Ubuntu Kinetic):
status: New → Fix Committed
tags: added: verification-needed-kinetic
Brett Holman (holmanb)
description: updated
Revision history for this message
Brett Holman (holmanb) wrote :

Hi Łukasz,

The test passes locally for me.

My reproducer, which works consistently on this machine, did not reproduce this issue using the new package. Suspending the machine was sufficient to force the error condition, but now that does not happen.

Package/Kernel versions:
========================

isa~ apt show bcmwl-kernel-source
Package: bcmwl-kernel-source
Version: 6.30.223.271+bdcom-0ubuntu10~22.10.1
Priority: optional
Section: restricted/admin
Source: bcmwl
Origin: Ubuntu
Maintainer: Ubuntu Developers <email address hidden>
Original-Maintainer: Alberto Milone <email address hidden>
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 8,090 kB
Depends: dkms, linux-libc-dev, libc6-dev
Conflicts: bcmwl-modaliases
Replaces: bcmwl-modaliases
Modaliases: wl(pci:v000014E4d00004311sv*sd*bc02sc80i*, pci:v000014E4d00004312sv*sd*bc02sc80i*, pci:v000014E4d00004313sv*sd*bc02sc80i*, pci:v000014E4d00004315sv*sd*bc02sc80i*, pci:v000014E4d00004727sv*sd*bc02sc80i*, pci:v000014E4d00004328sv*sd*bc02sc80i*, pci:v000014E4d00004328sv*sd*bc02sc80i*, pci:v000014E4d00004329sv*sd*bc02sc80i*, pci:v000014E4d0000432asv*sd*bc02sc80i*, pci:v000014E4d0000432bsv*sd*bc02sc80i*, pci:v000014E4d0000432csv*sd*bc02sc80i*, pci:v000014E4d0000432dsv*sd*bc02sc80i*, pci:v000014E4d00004365sv*sd*bc02sc80i*, pci:v000014E4d00004353sv*sd*bc02sc80i*, pci:v000014E4d00004357sv*sd*bc02sc80i*, pci:v000014E4d00004358sv*sd*bc02sc80i*, pci:v000014E4d00004359sv*sd*bc02sc80i*, pci:v000014E4d00004331sv*sd*bc02sc80i*, pci:v000014E4d000043a0sv*sd*bc02sc80i*, pci:v000014E4d000043B1sv*sd*bc02sc80i*)
Download-Size: 1,750 kB
APT-Manual-Installed: yes
APT-Sources: http://us.archive.ubuntu.com/ubuntu kinetic-proposed/restricted amd64 Packages
Description: Broadcom 802.11 Linux STA wireless driver source
 This package contains Broadcom 802.11 Linux STA wireless driver
 for use with Broadcom's BCM4311-, BCM4312-, BCM4313-, BCM4321-,
 BCM4322-, BCM43224-, and BCM43225-, BCM43227- and BCM43228-based

isa~ uname -a
Linux isa 5.19.0-30-generic #31-Ubuntu SMP PREEMPT_DYNAMIC Fri Jan 6 15:40:20 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

description: updated
Brett Holman (holmanb)
description: updated
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Marking verification as done on Jammy as well as the version is the same as in Kinetic.

tags: added: verification-done-kinetic
removed: verification-needed-kinetic
tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.30.223.271+bdcom-0ubuntu10~22.10.1

---------------
bcmwl (6.30.223.271+bdcom-0ubuntu10~22.10.1) kinetic; urgency=medium

  * Backport dkms support for HWE kernels.

bcmwl (6.30.223.271+bdcom-0ubuntu10) lunar; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0041-dev-addr-access.patch (LP: #1998039):
    - Fix netdev->dev_addr access with kernels >= 5.17.
  * debian/dkms.conf.in,
    debian/patches/0042-add-support-for-linux-6.x.patch (LP: #1999009):
    - Support linux >= 6.1

 -- Dimitri John Ledkov <email address hidden> Mon, 16 Jan 2023 11:12:48 +0000

Changed in bcmwl (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for bcmwl has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.30.223.271+bdcom-0ubuntu10~22.04.1

---------------
bcmwl (6.30.223.271+bdcom-0ubuntu10~22.04.1) jammy; urgency=medium

  * Backport dkms support for HWE kernels.

bcmwl (6.30.223.271+bdcom-0ubuntu10) lunar; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0041-dev-addr-access.patch (LP: #1998039):
    - Fix netdev->dev_addr access with kernels >= 5.17.
  * debian/dkms.conf.in,
    debian/patches/0042-add-support-for-linux-6.x.patch (LP: #1999009):
    - Support linux >= 6.1

bcmwl (6.30.223.271+bdcom-0ubuntu9) kinetic; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0040-add-support-for-linux-5.18.patch (LP: #1981968):
    - Add support for Linux 5.18.

 -- Dimitri John Ledkov <email address hidden> Mon, 16 Jan 2023 11:12:48 +0000

Changed in bcmwl (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.