Azure: Fix race on per-CQ variable napi_iperf panic fix

Bug #2003353 reported by Tim Gardner
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-azure (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Medium
Tim Gardner
Kinetic
Fix Released
Undecided
Tim Gardner

Bug Description

SRU Justification

[Impact]

This patch [1]1 is requested by MSFT Linux Systems Group to fix a race condition that can cause a panic in napi_iperf().

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=18010ff776fa42340efc428b3ea6d19b3e7c7b21

A number of prerequisite patches are required. v5.15.83 contains this patch, however v5.19 stable does not.

[Test Case]

MSFT tested and approved, "Please merge in both the kernels, LSG finished the validation".

[Where things could go wrong]

Test results are good. Regression potential seems low.

[Other Info]

SF: #00350135

Tim Gardner (timg-tpi)
affects: linux (Ubuntu) → linux-azure (Ubuntu)
description: updated
Changed in linux-azure (Ubuntu Focal):
assignee: nobody → Tim Gardner (timg-tpi)
importance: Undecided → Medium
status: New → In Progress
Changed in linux-azure (Ubuntu Kinetic):
assignee: nobody → Tim Gardner (timg-tpi)
status: New → In Progress
Changed in linux-azure (Ubuntu):
status: New → Fix Released
Tim Gardner (timg-tpi)
Changed in linux-azure (Ubuntu Kinetic):
status: In Progress → Fix Committed
Tim Gardner (timg-tpi)
Changed in linux-azure (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-azure/5.4.0-1104.110 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-azure verification-needed-focal
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-azure/5.19.0-1021.22 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-kinetic' to 'verification-done-kinetic'. If the problem still exists, change the tag 'verification-needed-kinetic' to 'verification-failed-kinetic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-kinetic-linux-azure verification-needed-kinetic
Tim Gardner (timg-tpi)
tags: added: verification-done-focal verification-done-kinetic
removed: verification-needed-focal verification-needed-kinetic
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (191.7 KiB)

This bug was fixed in the package linux-azure - 5.19.0-1021.22

---------------
linux-azure (5.19.0-1021.22) kinetic; urgency=medium

  * kinetic/linux-azure: 5.19.0-1021.22 -proposed tracker (LP: #2004286)

  * Kinetic update: upstream stable patchset 2023-01-27 (LP: #2004051)
    - [Config] azure: Update configs after rebase

  * Azure: Performance improvement for TDX (LP: #2004090)
    - SAUCE: clocksource: hyper-v: Use Invariant-TSC even if hv_read_tsc_page is
      hidden

  * Azure: mana: Fix IRQ name - add PCI and queue number (LP: #2004604)
    - net: mana: Fix IRQ name - add PCI and queue number

  * Azure: Fix race on per-CQ variable napi_iperf panic fix (LP: #2003353)
    - net: mana: Fix race on per-CQ variable napi work_done

  [ Ubuntu: 5.19.0-35.36 ]

  * kinetic/linux: 5.19.0-35.36 -proposed tracker (LP: #2004652)
  * CVE-2023-0461
    - SAUCE: Fix inet_csk_listen_start after CVE-2023-0461

  [ Ubuntu: 5.19.0-34.35 ]

  * kinetic/linux: 5.19.0-34.35 -proposed tracker (LP: #2004299)
  * LXD containers using shiftfs on ZFS or TMPFS broken on 5.15.0-48.54
    (LP: #1990849)
    - [SAUCE] shiftfs: fix -EOVERFLOW inside the container
  * Kinetic update: upstream stable patchset 2023-01-27 (LP: #2004051)
    - ASoC: fsl_sai: use local device pointer
    - serial: Add rs485_supported to uart_port
    - serial: fsl_lpuart: Fill in rs485_supported
    - x86/sgx: Create utility to validate user provided offset and length
    - x86/sgx: Add overflow check in sgx_validate_offset_length()
    - binder: validate alloc->mm in ->mmap() handler
    - ceph: Use kcalloc for allocating multiple elements
    - ceph: fix NULL pointer dereference for req->r_session
    - wifi: mac80211: fix memory free error when registering wiphy fail
    - wifi: mac80211_hwsim: fix debugfs attribute ps with rc table support
    - riscv: dts: sifive unleashed: Add PWM controlled LEDs
    - audit: fix undefined behavior in bit shift for AUDIT_BIT
    - wifi: airo: do not assign -1 to unsigned char
    - wifi: mac80211: Fix ack frame idr leak when mesh has no route
    - wifi: ath11k: Fix QCN9074 firmware boot on x86
    - spi: stm32: fix stm32_spi_prepare_mbr() that halves spi clk for every run
    - selftests/bpf: Add verifier test for release_reference()
    - Revert "net: macsec: report real_dev features when HW offloading is enabled"
    - platform/x86: ideapad-laptop: Disable touchpad_switch
    - platform/x86: touchscreen_dmi: Add info for the RCA Cambio W101 v2 2-in-1
    - platform/x86/intel/pmt: Sapphire Rapids PMT errata fix
    - scsi: ibmvfc: Avoid path failures during live migration
    - scsi: scsi_debug: Make the READ CAPACITY response compliant with ZBC
    - drm: panel-orientation-quirks: Add quirk for Acer Switch V 10 (SW5-017)
    - block, bfq: fix null pointer dereference in bfq_bio_bfqg()
    - arm64/syscall: Include asm/ptrace.h in syscall_wrapper header.
    - nvmet: fix memory leak in nvmet_subsys_attr_model_store_locked
    - Revert "drm/amdgpu: Revert "drm/amdgpu: getting fan speed pwm for vega10
      properly""
    - ALSA: usb-audio: add quirk to fix Hamedal C20 disconnect issue
    - RISC-V: vdso: Do not add missing symbols to version se...

Changed in linux-azure (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (146.9 KiB)

This bug was fixed in the package linux-azure - 5.4.0-1104.110

---------------
linux-azure (5.4.0-1104.110) focal; urgency=medium

  * focal/linux-azure: 5.4.0-1104.110 -proposed tracker (LP: #2004360)

  * Focal update: v5.4.226 upstream stable release (LP: #2003896)
    - [Config] azure: updateconfigs for INET_TABLE_PERTURB_ORDER

  * Azure: Fix race on per-CQ variable napi_iperf panic fix (LP: #2003353)
    - net: mana: Use struct_size() in kzalloc()
    - net: mana: Fix a memory leak in an error handling path in
      'mana_create_txq()'
    - net: mana: Move NAPI from EQ to CQ
    - net: mana: Add support for EQ sharing
    - net: mana: Add WARN_ON_ONCE in case of CQE read overflow
    - net: mana: Prefer struct_size over open coded arithmetic
    - net: mana: Fix error handling in mana_create_rxq()
    - net: mana: Fix race on per-CQ variable napi work_done

  * Azure: mana: Fix IRQ name - add PCI and queue number (LP: #2004604)
    - net: mana: Fix IRQ name - add PCI and queue number

  [ Ubuntu: 5.4.0-144.161 ]

  * focal/linux: 5.4.0-144.161 -proposed tracker (LP: #2004653)
  * CVE-2023-0461
    - SAUCE: Fix inet_csk_listen_start after CVE-2023-0461

  [ Ubuntu: 5.4.0-143.160 ]

  * focal/linux: 5.4.0-143.160 -proposed tracker (LP: #2004385)
  * NFS: client permission error after adding user to permissible group
    (LP: #2003053)
    - NFS: Clear the file access cache upon login
    - NFS: Judge the file access cache's timestamp in rcu path
    - NFS: Fix up a sparse warning
  * Focal update: v5.4.229 upstream stable release (LP: #2003914)
    - tracing/ring-buffer: Only do full wait when cpu != RING_BUFFER_ALL_CPUS
    - udf: Discard preallocation before extending file with a hole
    - udf: Fix preallocation discarding at indirect extent boundary
    - udf: Do not bother looking for prealloc extents if i_lenExtents matches
      i_size
    - udf: Fix extending file within last block
    - usb: gadget: uvc: Prevent buffer overflow in setup handler
    - USB: serial: option: add Quectel EM05-G modem
    - USB: serial: cp210x: add Kamstrup RF sniffer PIDs
    - USB: serial: f81232: fix division by zero on line-speed change
    - USB: serial: f81534: fix division by zero on line-speed change
    - igb: Initialize mailbox message for VF reset
    - xen-netback: move removal of "hotplug-status" to the right place
    - HID: ite: Add support for Acer S1002 keyboard-dock
    - HID: ite: Enable QUIRK_TOUCHPAD_ON_OFF_REPORT on Acer Aspire Switch 10E
    - HID: ite: Enable QUIRK_TOUCHPAD_ON_OFF_REPORT on Acer Aspire Switch V 10
    - HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk
    - net: loopback: use NET_NAME_PREDICTABLE for name_assign_type
    - usb: musb: remove extra check in musb_gadget_vbus_draw
    - ARM: dts: qcom: apq8064: fix coresight compatible
    - arm64: dts: qcom: sdm845-cheza: fix AP suspend pin bias
    - drivers: soc: ti: knav_qmss_queue: Mark knav_acc_firmwares as static
    - arm: dts: spear600: Fix clcd interrupt
    - soc: ti: knav_qmss_queue: Use pm_runtime_resume_and_get instead of
      pm_runtime_get_sync
    - soc: ti: knav_qmss_queue: Fix PM disable depth imbalance in knav_queue_probe
    - soc: ti: smartr...

Changed in linux-azure (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.