Raptor Lake Thermald ITMT version 2 support

I don't mind picking this one up.

@Colin, so you will push to the lunar?

Lunar already has this fix as it is the current latest release: http://changelogs.ubuntu.com/changelogs/pool/main/t/thermald/thermald_2.5.2-1/changelog

This fix needs to be backported to other releases as a stable release update, I'll do these.

Hello Srinivas, or anyone else affected,

Accepted thermald into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/2.5.1-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I've been exercising the existing code paths of thermald for several days now with no observable regression in behaviour. I cannot test the new code path change for this fix as I don't have the exact same system as that reported in the bug.

For what I can see, there is no regression on this single change for Kinetic.

@Colin, i could help to verify on the target.

@koba, if you have access to a Dell XPS 9320 then that would be super useful to verify too - thanks!

@Colin, i have accessed the Dell XPS 9320 and run some rounds of stress-ng.
Monitored through s-tui and thermald lod.
Didn't find any side-effects.

May i know if you're working on Jammy version?thanks
~~~
ubuntu@ubuntu:~$ ubuntu-report show
{
  "Version": "22.10",
  "OEM": {
    "Vendor": "Dell Inc.",
    "Product": "XPS 9320",
    "Family": "XPS",
    "DCD": "canonical-oem-somerville-jammy-amd64-20220504-33+jellyfish-tentacool-rpl+X88"
  },

ubuntu@ubuntu:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 22.10
Release: 22.10
Codename: kinetic
ubuntu@ubuntu:~$ sudo apt policy thermald
thermald:
  Installed: 2.5.1-1ubuntu1
  Candidate: 2.5.1-1ubuntu1
  Version table:
 *** 2.5.1-1ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu kinetic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     2.5.1-1 500
        500 http://tw.archive.ubuntu.com/ubuntu kinetic/main amd64 Packages

~~~

An upload of thermald to jammy-proposed has been rejected from the upload queue for the following reason: "refers to private bugs".

@koba, thanks for your kinetic testing. The [test plan] however also has this bit:

"""
The thermald log should indicate version 2 is being used with the message:
"ignore dummy_str: ds d1 d2 d3 " where ds = a string, d1 .. d3 are uint64 values that are parsed and ignored.
"""

Did you observe that message in the thermald log? I confess I don't know what in that message would indicate that "version 2 is being used", and I would have asked clarification on that before accepting the package.

+202304281026,
 there're related logs,
~~~
[1682648590][DEBUG] ITMT version 2 (null)
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG] ITMT version 2 itm_b
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG] ITMT version 2 itm_b_35
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG] ITMT version 2 itm_b_lap
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG] ITMT version 2 itm_c
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG] ITMT version 2 itm_p
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG] ITMT version 2 itm_p_35
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[1682648590][DEBUG]ignore dummy_str:\_SB_.PC00.TCPU 5 9 65536
[168264...

This bug was fixed in the package thermald - 2.5.1-1ubuntu1

---------------
thermald (2.5.1-1ubuntu1) kinetic; urgency=medium

  * Fix ITMT parsing, skip fields that are not known (LP: #2007579)
    upstream commit 90d56bc06cdcf78e7398ea7da389401516591774
    - 0001-Process-ITMT-v2.patch

 -- Colin Ian King <email address hidden> Thu, 16 Feb 2023 16:46:11 +0100

The verification of the Stable Release Update for thermald has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Please note that the jammy upload was rejected in comment #10, and the jammy task is therefore still "in progress".

Hello Srinivas, or anyone else affected,

Accepted thermald into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/2.4.9-1ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Verified
~~~
$ uname -a
Linux u-Precision-5480 6.1.0-1016-oem #16-Ubuntu SMP PREEMPT_DYNAMIC Wed Jun 21 08:45:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

$ sudo apt policy thermald
[sudo] password for x31:
thermald:
  Installed: 2.4.9-1ubuntu0.3
  Candidate: 2.4.9-1ubuntu0.3
  Version table:
 *** 2.4.9-1ubuntu0.3 500
        500 http://tw.archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     2.4.9-1ubuntu0.3 500
        500 https://ppa.launchpadcontent.net/kobako/exp-thermald/ubuntu jammy/main amd64 Packages
     2.4.9-1ubuntu0.2 500
        500 http://tw.archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
     2.4.9-1 500
        500 http://tw.archive.ubuntu.com/ubuntu jammy/main amd64 Packages

$ sudo thermald --no-daemon --adaptive --loglevel=debug

[1690482544][INFO]Processing ppcc limit 2, length 300
[1690482544][DEBUG] ITMT version 2 (null)
[1690482544][WARN]Found object of type 4, expecting 8
~~~

Hi @koba,

I think you pasted the wrong log in this bug here. You pasted the verification for INT3400 (bug #1989044)?

@Andreas, correct it.

This bug was fixed in the package thermald - 2.4.9-1ubuntu0.3

---------------
thermald (2.4.9-1ubuntu0.3) jammy; urgency=medium

  * Cherry-pick following fixes from thermald 2.5.1 and 2.5.2 (LP: #1995606)
  * debian/patches/0013-Add-AlderLake-N.patch
    - Add support for Adler Lake N (LP: #2012260)
  * debian/patches/0007-Add-INT3400-base-path-for-Raptor-Lake.patch
    - Fix RPL: Add INT3400 base path(LP: #1989044)
  * debian/patches/0014-Process-ITMT-v2.patch
    - Support ITMTv2 for Raptor Lake (LP: #2007579)
  * debian/patches/0008-Install-passive-default.patch
    - Fix throttled GPU (LP: #1981087)
  * debian/patches/0012-Always-match-motion-0.patch
    - Fix in-motion function doesn't work (LP: #2018275)
  * debian/patches/0003-Parse-ITMT-Table.patch
  * debian/patches/0004-Add-capability-for-min-max-per-trip.patch
  * debian/patches/0005-Install-ITMT_target.patch
  * debian/patches/0006-Use-per-trip-min-max.patch
  * debian/patches/0009-Parse-idsp-and-trips.patch
  * debian/patches/0010-use-PL1-max-min-from-PPCC-when-policies-match.patch
  * debian/patches/0011-Parse-GDDV-before-thd_engine-init.patch
    - Fix i9-12900k shutdown when run Prime95 and stress-ng (LP: #2018236)

 -- Koba Ko <email address hidden> Wed, 05 Jul 2023 13:37:32 +0200