Template Toolkit Syntax Errors Introduced by Aria Label Fix

Bug #2008925 reported by Jason Stephenson
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.10
Fix Released
High
Unassigned
3.9
Fix Released
High
Unassigned

Bug Description

Evergreen version: Master
OpenSRF Version: Master
O/S Version: Ubuntu 20.04

The patch for bug 1992490 introduced some syntax errors in some Bootstrap OPAC templates.

One way to find this is to login to the OPAC and Click on Messages, you will get an internal server error.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Sorry, I didn't see this before I created a duplicate bug report. Marking this one duplicate because that one has my patch - bug 2008928

tags: added: opac
tags: added: opac-account
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Here's my branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp2008925-fix-tt2-syntax-errors

Note that it changes more uses of the l() function than are strictly necessary to get the OPAC working and prevent the Internal Server Error. If you don't like that, there is always Terran's branch that makes the minimal changes necessary to get the Message view working again:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2008928_opac_messages_loading

tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
milestone: none → 3.11-beta
importance: Undecided → High
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Jason! Signoff for the more comprehensive fix at user/sandbergja/lp2008925-fix-tt2-syntax-errors-signoff

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_9. Thanks, Jason and Jane!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
milestone: 3.11-beta → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.