Ubuntu
gnome-settings-daemon package

[gsd-rfkill] WwanEnabled never get synced

Bug #2011770 reported by Atlas Yu on 2023-03-16

This bug affects 2 people

	Status	Importance	Assigned to
OEM Priority Project	Fix Released	Critical	Atlas Yu
gnome-settings-daemon (Ubuntu)	Fix Released	High	Unassigned
Jammy	Fix Released	Undecided	Unassigned
Kinetic	Fix Released	Undecided	Unassigned

Bug Description

[ Impact ]

* Sometimes on devices with WWAN card, whenever user presses the wireless function key (Fn+F8) or turn on the airplane mode radio button in Settings, the airplane mode will not be enabled, and the airplane mode icon is not shown in the status bar.

* There is a unmerged upstream merge request that delivers the fix: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/merge_requests/310

It works perfectly well on several Lenovo laptops with WWAN cards.
The root causes is that the value of "WwanEnabled" under "org.freedesktop.NetworkManager" is not synced correctly, gsd-rfkill should listen to "g-properties-changed" instead of "g-signal" now.

[ Test Plan ]

1. Find a machine which has WWAN card.
2. Boot the machine, and run rfkill list to see if WWAN is unblocked. if not use rfkill to unblock the WWAN, and reboot.
3. Press the wireless media key (Fn+F8) or turn on the airplane mode radio button in Settings.
4. The airplane mode should be enabled, but actually not.

[ Where problems could occur ]

* When user is using a very low version network-manager (< 1.20) that still broadcasting DBUS "PropertiesChanged" events on "g-signal" instead of the concurrent "g-properties-changed", the airplane mode will sometimes not be able to enable.

[1]: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/853
[2]: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6fb917178aa19c61e909957f5146aa4565e0cb2f

[ Other Info ]

1. About Ubuntu
Description: Ubuntu 22.04.2 LTS
Release: 22.04
Kernel: 6.1.0-1007-oem

2. The version of packages:
gnome-settings-daemon:
Installed: 42.1-1ubuntu2.1

network-manager:
Installed: 1.36.6-0ubuntu2

3. Expect:
The function nm_signal(plugins/rfkill/gsd-rfkill-manager.c) is called, and manager->wwan_enabled is set to the correct value.

4. Actual:
The function nm_signal(plugins/rfkill/gsd-rfkill-manager.c) is never called, so manager->wwan_enabled is not synced, If machine has WWAN device(s), and the initial value of manager->wwan_enabled is true, it will never be able to switch to airplane mode.

See original description

Tags:

Atlas Yu (pseudoc) on 2023-03-16

Changed in oem-priority:
status:	New → Triaged
importance:	Undecided → Critical
assignee:	nobody → Atlas Yu (pseudoc)
tags:	added: oem-priority originate-from-2007638 sutton

Revision history for this message

Launchpad Janitor (janitor) wrote on 2023-03-16:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-settings-daemon (Ubuntu):
status:	New → Confirmed

Revision history for this message

Bin Li (binli) wrote on 2023-03-16 (last edit on 2023-03-16):

On Lunar(23.04), I could reproduce this issue too.
With upstream's patch, this issue is fixed on ThinkPad T14s.

gnome-settings-daemon 44~rc-1ubuntu1
network-manager 1.40.12-1ubuntu1

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2023-03-16:

The attachment "sync-wwan-enabled.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Revision history for this message

Atlas Yu (pseudoc) wrote on 2023-03-16:

rfkill-sync-wwan-enabled.debdiff Edit (3.3 KiB, text/plain)

Revision history for this message

Atlas Yu (pseudoc) wrote on 2023-03-16:

cannot-enable-ariplane-mode.webm Edit (1.2 MiB, video/webm)

Here is a screen cast recording for better illustration.

description:

updated

Revision history for this message

Bin Li (binli) wrote on 2023-03-20:

@seb128,

Could you help review it or have someone help it? This issue will block our OEM schedule on 31th Mar. Thanks for your time.

Sebastien Bacher (seb128) on 2023-03-21

Changed in gnome-settings-daemon (Ubuntu):
importance:	Undecided → High
status:	Confirmed → Fix Committed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2023-03-21:

I've uploaded to lunar now, once confirm to work there we will SRU

Revision history for this message

Launchpad Janitor (janitor) wrote on 2023-03-22:

This bug was fixed in the package gnome-settings-daemon - 44~rc-1ubuntu2

---------------
gnome-settings-daemon (44~rc-1ubuntu2) lunar; urgency=medium

  * debian/patches/gitlab_nmsignal_deprecated.patch:
    - cherrypick a change in review upstream to fix airplane mode on some
      Lenovo laptops (lp: #2011770)

-- Sebastien Bacher <email address hidden> Tue, 21 Mar 2023 21:30:20 +0100

Changed in gnome-settings-daemon (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Atlas Yu (pseudoc) wrote on 2023-03-22:

#10

Thank you, Seb!

description:	updated
description:	updated

Revision history for this message

Sebastien Bacher (seb128) wrote on 2023-03-22:

#11

I've uploaded the SRU to K and J now

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2023-03-24: Please test proposed package

#12

Hello Atlas, or anyone else affected,

Accepted gnome-settings-daemon into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-settings-daemon/43.0-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-settings-daemon (Ubuntu Kinetic):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-kinetic
Changed in gnome-settings-daemon (Ubuntu Jammy):
status:	New → Fix Committed
tags:	added: verification-needed-jammy

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2023-03-24:

#13

Hello Atlas, or anyone else affected,

Accepted gnome-settings-daemon into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-settings-daemon/42.1-1ubuntu2.2 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2023-03-24: Autopkgtest regression report (gnome-settings-daemon/42.1-1ubuntu2.2)

#14

All autopkgtests for the newly accepted gnome-settings-daemon (42.1-1ubuntu2.2) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

mutter/42.5-0ubuntu1 (ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#gnome-settings-daemon

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2023-03-24: Autopkgtest regression report (gnome-settings-daemon/43.0-1ubuntu1.1)

#15

All autopkgtests for the newly accepted gnome-settings-daemon (43.0-1ubuntu1.1) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

mutter/43.0-1ubuntu4 (amd64, arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#gnome-settings-daemon

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Atlas Yu (pseudoc) on 2023-03-25

Changed in oem-priority:
status:	Triaged → Fix Committed

Revision history for this message

Atlas Yu (pseudoc) wrote on 2023-03-27:

#16

Verified the new version of gnome-settings-daemon (42.1-1ubuntu2.2) on jammy.

tags:

added: verification-done-jammy
removed: verification-needed-jammy

Revision history for this message

Atlas Yu (pseudoc) wrote on 2023-03-27:

#17

Verified the new version of gnome-settings-daemon (43.0-1ubuntu1.1) on kinetic.

tags:

added: verification-done verification-done-kinetic
removed: verification-needed verification-needed-kinetic

Revision history for this message

Atlas Yu (pseudoc) wrote on 2023-03-27:

#18

RE: #14/#15

The autopkgtest regressions seem not to be real regressions, this patch only affect WWAN, in the regression report the failure is about display issue in mutter.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2023-04-03:

#19

This bug was fixed in the package gnome-settings-daemon - 42.1-1ubuntu2.2

---------------
gnome-settings-daemon (42.1-1ubuntu2.2) jammy; urgency=medium

  * debian/patches/gitlab_nmsignal_deprecated.patch:
    - cherrypick a change proposed upstream to fix airplane mode on some
      Lenovo laptops (lp: #2011770)

-- Sebastien Bacher <email address hidden> Wed, 22 Mar 2023 10:59:52 +0100

Changed in gnome-settings-daemon (Ubuntu Jammy):
status:	Fix Committed → Fix Released

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2023-04-03: Update Released

#20

The verification of the Stable Release Update for gnome-settings-daemon has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2023-04-03:

#21

This bug was fixed in the package gnome-settings-daemon - 43.0-1ubuntu1.1

---------------
gnome-settings-daemon (43.0-1ubuntu1.1) kinetic; urgency=medium

  * debian/patches/gitlab_nmsignal_deprecated.patch:
    - cherrypick a change proposed upstream to fix airplane mode on some
      Lenovo laptops (lp: #2011770)

-- Sebastien Bacher <email address hidden> Wed, 22 Mar 2023 11:05:29 +0100