FFe+SRU: update google-osconfig-agent from 20220824.00 to 20230330.00

Bug #2015501 reported by Mitchell Dzurick
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
google-osconfig-agent (Ubuntu)
Fix Released
Undecided
Utkarsh Gupta
Bionic
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned

Bug Description

[FFe]
=====

One of your cloud partners have informed us that there is a customer issue blocking on this update, so we are attempting to expedite it ahead of (despite) Lunar’s release.

This package is in universe and is not seeded so there'll be no need to re-spin the images.

The update includes small bugfixes and a small feature addition -
Support new format of zypper patch (#469) which can be viewed here https://github.com/GoogleCloudPlatform/osconfig/commit/6cea7b7ea176cc85d946913bc639765541c4f0a2. This feature addition does not significantly impact the codebase either so it can be considered safe.

Upstream tag can be found at https://github.com/GoogleCloudPlatform/osconfig/tree/20230330.00

Changes between versions (20220824.00 (in the archive) -> 20230330.00):
 Fix exclude packages field processing (#440)
 Delete yum transaction files if created. (#445)
 Don't print raw pointer data. (#446)
 Close clients that are not passed anywhere (#450)
 Call FQDN (#454)
 Update owners file. (#455)
 Fix the error in the copy_file_from_bucket.yaml example. (#456)
 Update OWNERS (#458)
 Remove Debian 9 from e2e tests image list (#460)
 Bump golang.org/x/sys from 0.0.0-20210923061019-b8560ed6a9b7 to 0.1.0 (…
 Update dependencies (#466)
 Remove old images from e2e tests image list
 Fix comparing exec.Cmd in mock on Go1.20
 support new format of zypper patch (#469)
 Revert "Call FQDN (#454)" (#470)

Let us know if you need any more information. Thank you!

[SRU]
=====

[Impact]

This package is provided by Google for installation within guests that run on Google Compute Engine. It is part of a collection of tools and daemons, that ensure that the Ubuntu images published to GCE run properly on their platform.

Cloud platforms evolve at a rate that can't be handled in six-month increments, and they will often develop features that they would like to be available to customers who don't want to upgrade from earlier Ubuntu releases. As such, updating this package to more recent upstream releases is required within all Ubuntu releases, so they continue to function properly in their environment.

[Test Case]

When a new version of this package is uploaded to -proposed, the following will be done:

 * an image based on -proposed will be built for GCE and published to the ubuntu-os-cloud-devel project
 * the GCE team will be asked to validate that the new package addresses the issues it is expected to address, and that the image passes their internal image validation.

If all the testing indicates that the image containing the new package is acceptable, verification will be considered to be done.

[Other Information]

This bug is used for tracking of releasing the new upstream version for all supported series, as per the approved policy mentioned in the following MRE:

https://wiki.ubuntu.com/google-osconfig-agent-Updates

The updated package is not built for armhf and riscv64 due to upstream regressions but the package is not used on those architectures thus please release the SRU without the armhf and risc64 binaries.

The package does not build for powerpc on Xenial, but this is OK since it is not used on powerpc either.

Also, since this bumps some of the vendored dependencies, here's a diff of the version bump: https://paste.ubuntu.com/p/qJV8fnyFFy/

description: updated
Utkarsh Gupta (utkarsh)
description: updated
summary: - FFE: google-osconfig-agent 20220824.00 -> 20230330.00
+ FFE: update google-osconfig-agent from 20220824.00 to 20230330.00
Changed in google-osconfig-agent (Ubuntu):
assignee: nobody → Utkarsh Gupta (utkarsh)
Revision history for this message
Steve Langasek (vorlon) wrote : Re: FFE: update google-osconfig-agent from 20220824.00 to 20230330.00

FFe granted

Changed in google-osconfig-agent (Ubuntu):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package google-osconfig-agent - 20230330.00-0ubuntu1

---------------
google-osconfig-agent (20230330.00-0ubuntu1) lunar; urgency=medium

  [ Mitchell Dzurick ]
  * New upstream version 20230330.00. (LP: #2015501)
    - Fix exclude packages field processing (#440)
    - Delete yum transaction files if created. (#445)
    - Don't print raw pointer data. (#446)
    - Close clients that are not passed anywhere (#450)
    - Call FQDN (#454)
    - Update owners file. (#455)
    - Fix the error in the copy_file_from_bucket.yaml example. (#456)
    - Update OWNERS (#458)
    - Remove Debian 9 from e2e tests image list (#460)
    - Bump golang.org/x/sys from 0.0.0-20210923061019-b8560ed6a9b7 to 0.1.0 (…
    - Update dependencies (#466)
    - Remove old images from e2e tests image list
    - Fix comparing exec.Cmd in mock on Go1.20
    - support new format of zypper patch (#469)
    - Revert "Call FQDN (#454)" (#470)
  * d/extra/vendor: update go dependency vendor.

  [ Utkarsh Gupta ]
  * Supervise this upload.
  * d/copyright: Drop superfluous-file-pattern.
  * d/copyright: Update year for grpc license.

 -- Mitchell Dzurick <email address hidden> Thu, 06 Apr 2023 12:34:17 -0700

Changed in google-osconfig-agent (Ubuntu):
status: Triaged → Fix Released
Utkarsh Gupta (utkarsh)
description: updated
summary: - FFE: update google-osconfig-agent from 20220824.00 to 20230330.00
+ FFe+SRU: update google-osconfig-agent from 20220824.00 to 20230330.00
Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

There are vendored dependencies version bumps, according to the changelog provided in the bug description:

    - Update dependencies (#466)
    - Bump golang.org/x/sys from 0.0.0-20210923061019-b8560ed6a9b7 to 0.1.0 (…
  * d/extra/vendor: update go dependency vendor.

The MRE[1] states that:
"""
Vendored dependencies
If any pinned and vendored dependencies in this package change as part of the SRU then the following must be present in the SRU bug.

* Details of vendored package version changes are present in the SRU bug

* It is preferred that links to changelogs for the vendored packages are also present in the SRU bug
"""

Do you have those details, or links to them?

I'm taking a look at some, but it's a lot.

Looks like for x/sys it's this: https://github.com/GoogleCloudPlatform/osconfig/releases/tag/20230227.00
Bump golang.org/x/sys from 0.0.0-20210923061019-b8560ed6a9b7 to 0.1.0…

… (#463)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20210923061019-b8560ed6a9b7 to 0.1.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
...

Unfortunately https://github.com/golang/sys/releases is empty
But the 0.1.0 tag has something:
"""
https://github.com/golang/sys/releases/tag/v0.1.0
Currently ReadDirent is not available on zOS. This implementation modifies the current darwin implementation to work on zOS.

Also make tests available on zOS.

Fixes golang/go#54528
Fixes golang/go#54587
"""

The git log between b8560ed6a9b7 and v0.1.0, however, has 177 commits, that's a lot. Have you reviewed that, and have a summary?

Likewise for the d/extra/vendor, what's the summary of those vendored dependencies updates?

1. https://wiki.ubuntu.com/gce-compute-image-packages-Updates

Changed in google-osconfig-agent (Ubuntu Kinetic):
status: New → Incomplete
Changed in google-osconfig-agent (Ubuntu Jammy):
status: New → Incomplete
Changed in google-osconfig-agent (Ubuntu Focal):
status: New → Incomplete
Changed in google-osconfig-agent (Ubuntu Bionic):
status: New → Incomplete
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I also just noticed that the changes file[1] only has the last changelog entry. It closes this bug, but all the details about this upload are in the previous entry:

...
Changes:
 google-osconfig-agent (20230330.00-0ubuntu1~22.10.0) kinetic; urgency=medium
 .
   * No-change rebuild for Kinetic. (LP: #2015501)
Checksums-Sha1:
...

1. https://launchpadlibrarian.net/663315124/google-osconfig-agent_20230330.00-0ubuntu1~22.10.0_source.changes

Utkarsh Gupta (utkarsh)
description: updated
Revision history for this message
Utkarsh Gupta (utkarsh) wrote (last edit ):

Hi!

I've updated the MRE wiki page to reflect that we don't have to link changelogs, et al, but just the diff of the version bumps of the vendored deps. I've also added that in the description now.

P.S. This was done after talking to Lukasz (and Robie) in-person last week because it's a wasted engineering effort and time for us to link the changelogs of everything and then for the SRU team to go through each of them. You'll see the amount of vendored stuff that has changed is A LOTTTTTT. Anyway, since this only affects src:google-osconfig-agent only, we decided to inspect the bumps and see if there's anything alarming and then dive into that further.

Changed in google-osconfig-agent (Ubuntu Bionic):
status: Incomplete → New
Changed in google-osconfig-agent (Ubuntu Focal):
status: Incomplete → New
Changed in google-osconfig-agent (Ubuntu Jammy):
status: Incomplete → New
Changed in google-osconfig-agent (Ubuntu Kinetic):
status: Incomplete → New
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Mitchell, or anyone else affected,

Accepted google-osconfig-agent into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-osconfig-agent/20230330.00-0ubuntu1~22.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in google-osconfig-agent (Ubuntu Kinetic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Changed in google-osconfig-agent (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Mitchell, or anyone else affected,

Accepted google-osconfig-agent into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-osconfig-agent/20230330.00-0ubuntu1~22.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in google-osconfig-agent (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Mitchell, or anyone else affected,

Accepted google-osconfig-agent into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-osconfig-agent/20230330.00-0ubuntu1~20.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in google-osconfig-agent (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Mitchell, or anyone else affected,

Accepted google-osconfig-agent into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-osconfig-agent/20230330.00-0ubuntu1~18.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I really don't know how to improve the review process for google packages. This upload bumped so many vendored dependencies that it was borderline silly, I have no idea why they include so many versions. I think I need to sit down with other SRU members and consult this.

Another thing: for focal and bionic this seems to be bumping the golang version used for building - please always mention that in the SRU bug. I'll work on making it more clear, but I think the general expectation for ALL MREs is to document any packaging changes happening for new versions that are being uploaded.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (google-osconfig-agent/20230330.00-0ubuntu1~20.04.0)

All autopkgtests for the newly accepted google-osconfig-agent (20230330.00-0ubuntu1~20.04.0) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

google-osconfig-agent/20230330.00-0ubuntu1~20.04.0 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#google-osconfig-agent

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package google-osconfig-agent - 20230504.00-0ubuntu1~22.10.0

---------------
google-osconfig-agent (20230504.00-0ubuntu1~22.10.0) kinetic; urgency=medium

  * No-change rebuild for Kinetic.

google-osconfig-agent (20230504.00-0ubuntu1) mantic; urgency=medium

  * New upstream version 20230504.00. (LP: #2020762)

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 15:28:34 +0530

Changed in google-osconfig-agent (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package google-osconfig-agent - 20230504.00-0ubuntu1~22.04.0

---------------
google-osconfig-agent (20230504.00-0ubuntu1~22.04.0) jammy; urgency=medium

  * No-change rebuild for Jammy.

google-osconfig-agent (20230504.00-0ubuntu1) mantic; urgency=medium

  * New upstream version 20230504.00. (LP: #2020762)

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 15:33:15 +0530

Changed in google-osconfig-agent (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package google-osconfig-agent - 20230504.00-0ubuntu1~20.04.0

---------------
google-osconfig-agent (20230504.00-0ubuntu1~20.04.0) focal; urgency=medium

  * No-change rebuild for Focal.

google-osconfig-agent (20230504.00-0ubuntu1) mantic; urgency=medium

  * New upstream version 20230504.00. (LP: #2020762)

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 15:35:06 +0530

Changed in google-osconfig-agent (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

As LP: #2020762 superseded this bug and the former one being verified, we can mark this one as verified because the newer builds are based on top of this one and so in the process of verifying the former one, this was is also verified. We ran our internal tests (CTF tests on the image) and Google also did the validation of these packages and the images we sent them. Adjusting the tags accordingly.

tags: added: verification-done verification-done-bionic verification-done-focal verification-done-jammy verification-done-kinetic
removed: verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package google-osconfig-agent - 20230504.00-0ubuntu1~18.04.0

---------------
google-osconfig-agent (20230504.00-0ubuntu1~18.04.0) bionic; urgency=medium

  * No-change rebuild for Bionic.

google-osconfig-agent (20230504.00-0ubuntu1) mantic; urgency=medium

  * New upstream version 20230504.00. (LP: #2020762)

 -- Utkarsh Gupta <email address hidden> Thu, 25 May 2023 15:41:46 +0530

Changed in google-osconfig-agent (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.