Merge proposal has puny and confusing secondary pages

Bug #202415 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Paul Hummer

Bug Description

When you propose a branch for merging, the proposal gets its own page, along with six secondary pages. Four of the six -- "Edit branch merge proposal", "Request review", "Set proposal as work in progress", and "Resubmit proposal" -- consist only of the Whiteboard field and some buttons. "Mark as merged" contains even less, a single-line field and buttons. And "Delete branch merge proposal" consists of two buttons and nothing else.

Having these as separate tiny pages is inefficient, but in the last case it's also confusing: I'm apparently required to choose whether to "Delete" or to "Cancel" a branch merge proposal, without any explanation of how those actions differ.

I suggest that all these pages be merged into the proposal page:
* "Edit branch merge proposal" become a JavaScript-powered button that makes the whiteboard editable;
* "Request review" become checking a checkbox;
* "Set proposal as work as progress" become unchecking the same checkbox;
* "Resubmit proposal" become ... something (I don't understand what this page does);
* "Mark as merged" become a collapsed-by-default section containing a text field;
* "Delete branch merge proposal" become a "Withdraw Proposal" button near the top of the proposal page.

Fixing this bug would incidentally fix bug 202015.

Revision history for this message
Jonathan Lange (jml) wrote :

A sketch would be helpful here.

Note that these pages are new and are a good candidate for the updated UI.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

We'll sketch this at the Code sprint next week.

Changed in launchpad-bazaar:
assignee: nobody → mpt
milestone: none → 1.2.4
Revision history for this message
Matthew Paul Thomas (mpt) wrote :
Changed in launchpad-bazaar:
milestone: 1.2.4 → 1.2.5
Changed in launchpad-bazaar:
assignee: mpt → rockstar
milestone: 1.2.5 → 1.2.6
Tim Penhey (thumper)
Changed in launchpad-bazaar:
assignee: rockstar → abentley
importance: Undecided → High
status: New → Confirmed
Tim Penhey (thumper)
Changed in launchpad-bazaar:
assignee: abentley → rockstar
milestone: 1.2.6 → 1.99
Tim Penhey (thumper)
Changed in launchpad-bazaar:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.