latest patch breaks OSC 52 clipboard access

The attachment "corrected patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

Oops, sorry about that. Thank you for pointing out the issue, I will fix it in Debian unstable.

Status changed to 'Confirmed' because the bug affects multiple users.

Thanks for taking the time to report this bug and trying to make Ubuntu better.

The bug was already fixed in version 33a-5 in Debian unstable by Romain (thanks!):

https://tracker.debian.org/news/1472848/accepted-tmux-33a-5-source-into-unstable/

It should be fixed in the development release (noble) soon, once it is sync'ed from Debian.

However, the affected version is also present in Mantic, so adding a task for it.

Reproduction is easy:

$ lxc launch images:ubuntu/23.10/desktop ubuntu --vm -c limits.cpu=4 -c limits.memory=4GiB --console=vga

In the VM:

$ sudo apt update -y
$ sudo apt install -y tmux alacritty
$ echo "set -g mouse on" > ~/.tmux.conf:
$ alacritty
$ tmux
# Write text, highlight with mouse, try to paste and see no text is copied

Testing the fix with current debian unstable package
$ wget http://ftp.us.debian.org/debian/pool/main/t/tmux/tmux_3.3a-5_amd64.deb
$ sudo dpkg -i tmux_3.3a-5_amd64.deb
$ tmux
# write some text, highlight with mouse, and see text will be pasted

Test package here - https://launchpad.net/~mitchdz/+archive/ubuntu/lp2040080-tmux-clipboard Checked in a VM that the clipboard works.

Staged the fix[1]. We will have to wait until Noble gets a package sync before SRUing into Mantic.

[1] - https://code.launchpad.net/~mitchdz/ubuntu/+source/tmux/+git/tmux/+merge/454437

This bug was fixed in the package tmux - 3.3a-5

---------------
tmux (3.3a-5) unstable; urgency=medium

  * Fix backport of commit bf636d9575 which breaks OSC 52 clipboard
    access, with thanks to Claudio Leite (LP: #2040080).

 -- Romain Francoise <email address hidden> Sun, 22 Oct 2023 16:34:17 +0200

Hello Claudio, or anyone else affected,

Accepted tmux into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tmux/3.3a-4ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted tmux (3.3a-4ubuntu1) for mantic have finished running.
The following regressions have been reported in tests triggered by the package:

vim-ultisnips/3.2-2 (amd64, armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/mantic/update_excuses.html#tmux

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Hello,

The issue is fixed for me with 3.3a-4ubuntu1. Thank you!

This bug was fixed in the package tmux - 3.3a-4ubuntu1

---------------
tmux (3.3a-4ubuntu1) mantic; urgency=medium

  * d/p/lp2040080-fix-upstream-bf636d9575-OSC52-clipboard.patch:
    fix upstream patch to allow OSC52 clipboard access (LP: #2040080).

 -- Mitchell Dzurick <email address hidden> Tue, 07 Nov 2023 15:49:10 -0700

The verification of the Stable Release Update for tmux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.