Incorrect argument from SEV live-migration fix

Bug #2040337 reported by John Cabaj
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-gcp (Ubuntu)
New
Undecided
Unassigned
Focal
Fix Released
High
John Cabaj
Jammy
Fix Released
High
John Cabaj

Bug Description

[Impact]

* Google requested fix to notify_range_enc_status_changed() passing incorrect argument.

[Fix]

* Upstream ac3f9c9f1b37 introduced change to notify_range_enc_status_changed() to accept page size instead of number of pages, but function was not updated. Updating to send correct argument. Upstream implementation changed with TDX
support, and is unaffected, so no plans to upstream.

[Test Case]

* Compile tested
* Boot tested
* Tested by Google

[Where things could go wrong]

* Low chance of regression. Isolated logic fix.

[Other Info]

* SF #00367134

John Cabaj (john-cabaj)
Changed in linux-gcp (Ubuntu Focal):
status: New → In Progress
Changed in linux-gcp (Ubuntu Jammy):
status: New → In Progress
Changed in linux-gcp (Ubuntu Focal):
importance: Undecided → High
Changed in linux-gcp (Ubuntu Jammy):
importance: Undecided → High
Changed in linux-gcp (Ubuntu Focal):
assignee: nobody → John Cabaj (john-cabaj)
Changed in linux-gcp (Ubuntu Jammy):
assignee: nobody → John Cabaj (john-cabaj)
John Cabaj (john-cabaj)
description: updated
John Cabaj (john-cabaj)
Changed in linux-gcp (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in linux-gcp (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/5.15.0-1047.55 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-gcp' to 'verification-done-jammy-linux-gcp'. If the problem still exists, change the tag 'verification-needed-jammy-linux-gcp' to 'verification-failed-jammy-linux-gcp'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-gcp-v2 verification-needed-jammy-linux-gcp
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/5.4.0-1118.127 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal-linux-gcp' to 'verification-done-focal-linux-gcp'. If the problem still exists, change the tag 'verification-needed-focal-linux-gcp' to 'verification-failed-focal-linux-gcp'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-gcp-v2 verification-needed-focal-linux-gcp
Revision history for this message
John Cabaj (john-cabaj) wrote :

Verified requisite change is in focal and jammy releases. Full suite of boot test and regression tests will suffice for verification.

tags: added: verification-done-focal-linux-gcp verification-done-jammy-linux-gcp
removed: verification-needed-focal-linux-gcp verification-needed-jammy-linux-gcp
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-gcp - 5.4.0-1118.127

---------------
linux-gcp (5.4.0-1118.127) focal; urgency=medium

  * focal/linux-gcp: 5.4.0-1118.127 -proposed tracker (LP: #2041969)

  * Incorrect argument from SEV live-migration fix (LP: #2040337)
    - SAUCE: (no-up) x86/mm: Fixing notify_range_enc_status_changed incorrect
      argument

  [ Ubuntu: 5.4.0-167.184 ]

  * focal/linux: 5.4.0-167.184 -proposed tracker (LP: #2041988)
  * CVE-2023-45871
    - igb: set max size RX buffer when store bad packet is enabled
  * CVE-2023-31085
    - ubi: Refuse attaching if mtd's erasesize is 0
  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

 -- Stefan Bader <email address hidden> Fri, 03 Nov 2023 15:25:48 +0100

Changed in linux-gcp (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-gcp - 5.15.0-1047.55

---------------
linux-gcp (5.15.0-1047.55) jammy; urgency=medium

  * jammy/linux-gcp: 5.15.0-1047.55 -proposed tracker (LP: #2041917)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/s2023.10.02)

  * Incorrect argument from SEV live-migration fix (LP: #2040337)
    - SAUCE: (no-up) x86/mm: Fixing notify_range_enc_status_changed incorrect
      argument

  * No graphic desktop environment on Google GCP instances (LP: #2039732)
    - [Config] gcp: Inherit CONFIG_SYSFB_SIMPLEFB from master

  [ Ubuntu: 5.15.0-89.99 ]

  * jammy/linux: 5.15.0-89.99 -proposed tracker (LP: #2041949)
  * CVE-2023-31085
    - ubi: Refuse attaching if mtd's erasesize is 0
  * CVE-2023-45871
    - igb: set max size RX buffer when store bad packet is enabled
  * CVE-2023-25775
    - RDMA/irdma: Remove irdma_uk_mw_bind()
    - RDMA/irdma: Remove irdma_sc_send_lsmm_nostag()
    - RDMA/irdma: Remove irdma_cqp_up_map_cmd()
    - RDMA/irdma: Remove irdma_get_hw_addr()
    - RDMA/irdma: Make irdma_uk_cq_init() return a void
    - RDMA/irdma: optimize rx path by removing unnecessary copy
    - RDMA/irdma: Remove enum irdma_status_code
    - RDMA/irdma: Remove excess error variables
    - RDMA/irdma: Prevent zero-length STAG registration
  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

 -- Stefan Bader <email address hidden> Fri, 03 Nov 2023 15:14:39 +0100

Changed in linux-gcp (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp-tcpx/5.15.0-1003.3 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal-linux-gcp-tcpx' to 'verification-done-focal-linux-gcp-tcpx'. If the problem still exists, change the tag 'verification-needed-focal-linux-gcp-tcpx' to 'verification-failed-focal-linux-gcp-tcpx'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-gcp-tcpx-v2 verification-needed-focal-linux-gcp-tcpx
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.