Failed to build against linux-unstable 6.6.0-8-generic: error: 'struct genl_info' has no member named 'userhdr'

Bug #2042059 reported by You-Sheng Yang
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
backport-iwlwifi-dkms (Ubuntu)
Fix Released
High
You-Sheng Yang
Mantic
Fix Released
High
You-Sheng Yang
Noble
Fix Released
High
You-Sheng Yang

Bug Description

[SRU Justification]

[Impact]

backport-iwlwifi-dkms fails to compile against kernel > 6.6 due to API changes.

[Fix]

Upstream fix commit 8fd541f76cdc ("backport: genetlink: adjust to info->userhdr removal").

[Test Case]
```
$ sudo add-apt-repository ppa:canonical-kernel-team/unstable
$ sudo apt-get install linux-headers-generic-wip

$ sudo add-apt-repository ppa:vicamo/ppa-2042059
$ sudo apt-get install backport-iwlwifi-dkms
```

[Where problems could occur]

We're pulling new upstream version with around 200+ commits for backport-iwlwifi-dkms/noble, but only backport the required fix commit for mantic. Likely to expect issue in Noble only.

[Other Info]

Mantic is nominated because we're still using mantic environment for preparing linux-unstable.

========== original bug report ==========

In file included from /var/lib/dkms/backport-iwlwifi/11289/build/drivers/net/wireless/intel/iwlwifi/iwl-tm-gnl.c:8:
/var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h: In function '__bp_genl_info_userhdr_set':
/var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h:9:13: error: 'struct genl_info' has no member named 'userhdr'
    9 | info->userhdr = userhdr;
      | ^~
/var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h: In function '__bp_genl_info_userhdr':
/var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h:14:20: error: 'struct genl_info' has no member named 'userhdr'
   14 | return info->userhdr;
      | ^~
/var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h: At top level:
/var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h:48:21: error: conflicting types for 'genl_info_userhdr'; have 'void *(struct genl_info *)'
   48 | static inline void *genl_info_userhdr(struct genl_info *info)
      | ^~~~~~~~~~~~~~~~~
In file included from /var/lib/dkms/backport-iwlwifi/11289/build/backport-include/net/genetlink.h:3:
./include/net/genetlink.h:126:21: note: previous definition of 'genl_info_userhdr' with type 'void *(const struct genl_info *)'
  126 | static inline void *genl_info_userhdr(const struct genl_info *info)
      | ^~~~~~~~~~~~~~~~~
make[8]: *** [scripts/Makefile.build:251: /var/lib/dkms/backport-iwlwifi/11289/build/drivers/net/wireless/intel/iwlwifi/iwl-tm-gnl.o] Error 1
make[8]: *** Waiting for unfinished jobs....

Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Probably has been fixed by upstream commit 8fd541f76cdc ("backport: genetlink: adjust to info->userhdr removal") (>= 11461)

Revision history for this message
You-Sheng Yang (vicamo) wrote :
Changed in backport-iwlwifi-dkms (Ubuntu Noble):
assignee: nobody → You-Sheng Yang (vicamo)
importance: Undecided → High
status: New → In Progress
Revision history for this message
You-Sheng Yang (vicamo) wrote :

debdiff based on new upstream version 11510 for Noble 24.04.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Need sponsor for above debdiff.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Add debdiff for mantic as well. Need sponsoring, too.

Changed in backport-iwlwifi-dkms (Ubuntu Mantic):
status: New → In Progress
importance: Undecided → High
assignee: nobody → You-Sheng Yang (vicamo)
You-Sheng Yang (vicamo)
description: updated
Revision history for this message
Alberto Milone (albertomilone) wrote :

I have uploaded the one for mantic as backport-iwlwifi-dkms_11289-0ubuntu1.23.10.1.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package backport-iwlwifi-dkms - 11510-0ubuntu1

---------------
backport-iwlwifi-dkms (11510-0ubuntu1) noble; urgency=low

  [You-Sheng Yang]
  * New release
    - upstream version 11510 commit 41e354fb5f32f. (LP: #2042059)
    - debian: refresh patches
  * dkms: bump OBSOLETE_BY version to v6.7.0

 -- You-Sheng Yang <email address hidden> Tue, 31 Oct 2023 14:39:23 +0800

Changed in backport-iwlwifi-dkms (Ubuntu Noble):
status: In Progress → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello You-Sheng, or anyone else affected,

Accepted backport-iwlwifi-dkms into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/11289-0ubuntu1.23.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in backport-iwlwifi-dkms (Ubuntu Mantic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-mantic
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Unsubscribing sponsors, as this was uploaded already.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

verified backport-iwlwifi-dkms/mantic-proposed version 11289-0ubuntu1.23.10.1.

tags: added: verification-done verification-done-mantic
removed: verification-needed verification-needed-mantic
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I also tested an install with the mantic GA kernel, and it kept building fine.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package backport-iwlwifi-dkms - 11289-0ubuntu1.23.10.1

---------------
backport-iwlwifi-dkms (11289-0ubuntu1.23.10.1) mantic; urgency=low

  * Failed to build against linux-unstable 6.6.0-8-generic (LP: #2042059)

 -- You-Sheng Yang <email address hidden> Tue, 31 Oct 2023 21:30:50 +0800

Changed in backport-iwlwifi-dkms (Ubuntu Mantic):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Update Released

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.