Include cifs.ko in linux-modules package

Bug #2042546 reported by Roxana Nicolescu
90
This bug affects 23 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Status tracked in Noble
Lunar
Fix Released
High
Roxana Nicolescu
Mantic
Fix Committed
High
Roxana Nicolescu
Noble
Fix Committed
High
Roxana Nicolescu

Bug Description

[Impact]

Commit: "smb: move client and server files to common directory fs/smb" moved the fs/cifs directory to fs/sb/client. The inclusion list for linux-modules was not updated, it still contains the old path. This means that the cifs.ko module cannot be loaded if only linux-modules package is installed, now being part of linux-modules-extra.
For the main kernels this is not a problem because linux-modules-extra is always installed, but for derivatives like aws, azure etc, this module cannot be loaded without explicitly installing linux-modules-extra.

[How to reproduce it]:
1. Install the latest azure kernel 6.5.0-1017.17
2. Load cifs module
$ modprobe cifs
modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure
If modules-extra is installed, this works.

[Fix]

Replace fs/cifs/* with fs/smb/client/* in debian.<derivative>/control.d/<derivative>.inclusion-list. First the main kernels are addressed, derivatives will be fixed via cranky fix.

[Test Plan]

1. Apply the fix to one of the derivative (azure), build a new kernel and install it
2. Load cifs module
$ modprobe cifs
It should work without installing modules-extra.

[Regression potential]

Very low, it's a straightforward fix.

[Other Info]
Sending a patch for every derivative takes time and each derivative will be fixed once this proposal is acked via cranky fix.

Original for lunar only
SRU Justification:

[Impact]

Commit: "smb: move client and server files to common directory fs/smb" introduced in 2023.09.04 moved the fs/cifs directory to fs/sb/client. The inclusion list for linux-modules was not updated, it still contains the old path. This means that the cifs.ko module cannot be loaded if only linux-modules package is installed, now being part of linux-modules-extra.
For lunar:main this is not a problem because linux-modules-extra is always installed, but for derivatives like aws, azure etc, this module cannot be loaded without explicitly installing linux-modules-extra.

[How to reproduce it]:
1. Install the latest azure kernel 6.2.0-1016.16
2. Load cifs module
$ modprobe cifs
modprobe: FATAL: Module cifs not found in directory /lib/modules/6.2.0-1016-azure
If modules-extra is installed, this works.

[Fix]

Replace fs/cifs/* with fs/smb/client/* in debian.<derivative>/control.d/<derivative>.inclusiojn-list
This is going to be done in s2023.10.02 cycle for derivatives.

[Test Plan]

1. Apply the fix to one of the derivative (azure), build a new kernel and install it
2. Load cifs module
$ modprobe cifs
It should work without installing modules-extra.

[Regression potential]

Very low, it's a straightforward fix.

[Other Info]
Sending a patch for every derivative takes time and each derivative will be fixed once this proposal is acked.
There is also the possibility to do it via cranky fix, but owners may omit it during security updates and it's hard to enforce it. Plus, it is a one-time change.

description: updated
tags: added: sru-s2023.10.02
tags: added: sru-s20231002
removed: sru-s2023.10.02
description: updated
Changed in linux (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu Lunar):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Roxana Nicolescu (roxanan)
summary: - Cifs.ko not part of linux-modules anymore
+ Include cifs.ko in linux-modules
summary: - Include cifs.ko in linux-modules
+ Include cifs.ko in linux-modules package
Changed in linux (Ubuntu Lunar):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-kvm/6.2.0-1017.17 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-kvm' to 'verification-done-lunar-linux-kvm'. If the problem still exists, change the tag 'verification-needed-lunar-linux-kvm' to 'verification-failed-lunar-linux-kvm'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-kvm-v2 verification-needed-lunar-linux-kvm
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-6.2/6.2.0-37.38~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-hwe-6.2' to 'verification-done-jammy-linux-hwe-6.2'. If the problem still exists, change the tag 'verification-needed-jammy-linux-hwe-6.2' to 'verification-failed-jammy-linux-hwe-6.2'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-hwe-6.2-v2 verification-needed-jammy-linux-hwe-6.2
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-aws/6.2.0-1016.16 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-aws' to 'verification-done-lunar-linux-aws'. If the problem still exists, change the tag 'verification-needed-lunar-linux-aws' to 'verification-failed-lunar-linux-aws'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-aws-v2 verification-needed-lunar-linux-aws
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/6.2.0-1019.21 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-gcp' to 'verification-done-lunar-linux-gcp'. If the problem still exists, change the tag 'verification-needed-lunar-linux-gcp' to 'verification-failed-lunar-linux-gcp'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-gcp-v2 verification-needed-lunar-linux-gcp
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-lowlatency-hwe-6.2/6.2.0-1017.17~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-lowlatency-hwe-6.2' to 'verification-done-jammy-linux-lowlatency-hwe-6.2'. If the problem still exists, change the tag 'verification-needed-jammy-linux-lowlatency-hwe-6.2' to 'verification-failed-jammy-linux-lowlatency-hwe-6.2'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-lowlatency-hwe-6.2-v2 verification-needed-jammy-linux-lowlatency-hwe-6.2
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-azure/6.2.0-1017.17 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-azure' to 'verification-done-lunar-linux-azure'. If the problem still exists, change the tag 'verification-needed-lunar-linux-azure' to 'verification-failed-lunar-linux-azure'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-azure-v2 verification-needed-lunar-linux-azure
Revision history for this message
Dean Attewell (eitsop) wrote :

when will this change be deployed?

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-riscv/6.2.0-37.38.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-riscv' to 'verification-done-lunar-linux-riscv'. If the problem still exists, change the tag 'verification-needed-lunar-linux-riscv' to 'verification-failed-lunar-linux-riscv'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-riscv-v2 verification-needed-lunar-linux-riscv
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/6.2.0-39.40 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux' to 'verification-done-lunar-linux'. If the problem still exists, change the tag 'verification-needed-lunar-linux' to 'verification-failed-lunar-linux'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-v2 verification-needed-lunar-linux
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-starfive/6.2.0-1009.10 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-starfive' to 'verification-done-lunar-linux-starfive'. If the problem still exists, change the tag 'verification-needed-lunar-linux-starfive' to 'verification-failed-lunar-linux-starfive'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-starfive-v2 verification-needed-lunar-linux-starfive
Revision history for this message
Roxana Nicolescu (roxanan) wrote :

@eitsop It is part of the 2023.10.30 cycle and it will be released on the week of 4th of December as described here https://kernel.ubuntu.com.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oracle/6.2.0-1016.17 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-lunar-linux-oracle' to 'verification-done-lunar-linux-oracle'. If the problem still exists, change the tag 'verification-needed-lunar-linux-oracle' to 'verification-failed-lunar-linux-oracle'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-lunar-linux-oracle-v2 verification-needed-lunar-linux-oracle
Revision history for this message
Manuel Diewald (diewald) wrote :

Installed lunar/linux-gcp-6.2.0-1019 from -proposed in a vm running a lunar cloudimg server image (amd64) and successfully loaded module cifs without needing to install modules-extra.

tags: added: verification-done-lunar-linux-gcp
removed: verification-needed-lunar-linux-gcp
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-starfive-6.2/6.2.0-1009.10~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-starfive-6.2' to 'verification-done-jammy-linux-starfive-6.2'. If the problem still exists, change the tag 'verification-needed-jammy-linux-starfive-6.2' to 'verification-failed-jammy-linux-starfive-6.2'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-starfive-6.2-v2 verification-needed-jammy-linux-starfive-6.2
Revision history for this message
C de-Avillez (hggdh2) wrote :

removed modules-extra, rebooted, and installed the new kernel for Azure; then rebooted again.

modprobe cifs works, and modules-extra is not installed. Marking verification done for Azure.

tags: added: verification-done-jammy-linux-hwe-6.2
removed: verification-needed-jammy-linux-hwe-6.2
Revision history for this message
Stefan Bader (smb) wrote :

Downloaded linux-modules-6.2.0-39-generic_6.2.0-39.40_amd64.deb from the PPA unpacked it and ensured it contains the cifs module:

~/tmp/lunar/unpack$ find|grep cifs
./lib/modules/6.2.0-39-generic/kernel/fs/smb/client/cifs.ko
./lib/modules/6.2.0-39-generic/kernel/fs/smb/common/cifs_md4.ko
./lib/modules/6.2.0-39-generic/kernel/fs/smb/common/cifs_arc4.ko

tags: added: verification-done-lunar-linux
removed: verification-needed-lunar-linux
Revision history for this message
Joseph (jhb1986) wrote (last edit ):

We are still seeing this issue on the latest 6.2.0-1016-azure kernel

user@ubuntu:~$ uname -a
Linux ubuntu 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

user@ubuntu:~$ modprobe cifs
modprobe: FATAL: Module cifs not found in directory /lib/modules/6.2.0-1016-azure

user@ubuntu:~$ ls -lh /lib/modules/6.2.0-1016-azure/kernel/fs/
total 120K
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 9p
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 autofs
-rw-r--r-- 1 root root 38K Oct 10 16:03 binfmt_misc.ko
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 btrfs
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 cachefiles
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 ceph
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 dlm
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 fat
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 fscache
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 fuse
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 isofs
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 lockd
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 netfs
drwxr-xr-x 5 root root 4.0K Nov 1 02:12 nfs
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 nfs_common
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 nfsd
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 nls
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 overlayfs
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 udf
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 ufs
drwxr-xr-x 2 root root 4.0K Nov 1 02:12 xfs

user@ubuntu:~$ apt list --installed 2>/dev/null | grep -i cifs
cifs-utils/jammy-updates,jammy-security,now 2:6.14-1ubuntu0.1 amd64 [installed]

user@ubuntu:~$ sudo mount -t cifs //<mount>/<path>/ /mnt/<mount_point> -o username=<mount_user>
Password for <mount_user>@//<mount>/<point>/<path>:
mount error: cifs filesystem not supported by the system
mount error(19): No such device
Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg)

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (39.0 KiB)

This bug was fixed in the package linux - 6.2.0-39.40

---------------
linux (6.2.0-39.40) lunar; urgency=medium

  * lunar/linux: 6.2.0-39.40 -proposed tracker (LP: #2043451)

  * USB bus error after upgrading to proposed kernel on lunar and jammy
    (LP: #2043197)
    - USB: core: Fix oversight in SuperSpeed initialization

  * Include cifs.ko in linux-modules package (LP: #2042546)
    - [Packaging] Replace fs/cifs with fs/smb/client in inclusion list

linux (6.2.0-38.39) lunar; urgency=medium

  * lunar/linux: 6.2.0-38.39 -proposed tracker (LP: #2041557)

  * CVE-2023-25775
    - RDMA/irdma: Prevent zero-length STAG registration

  * CVE-2023-5345
    - fs/smb/client: Reset password pointer to NULL

  * CVE-2023-39189
    - netfilter: nfnetlink_osf: avoid OOB read

  * SMC stats: Wrong bucket calculation for payload of exactly 4096 bytes
    (LP: #2039575)
    - net/smc: Fix pos miscalculation in statistics

  * [SRU][J/L/M] UBUNTU: [Packaging] Make WWAN driver a loadable module
    (LP: #2033406)
    - [Packaging] Make WWAN driver loadable modules

  * CVE-2023-45871
    - igb: set max size RX buffer when store bad packet is enabled

  * CVE-2023-39193
    - netfilter: xt_sctp: validate the flag_info count

  * CVE-2023-39192
    - netfilter: xt_u32: validate user space input

  * CVE-2023-31085
    - ubi: Refuse attaching if mtd's erasesize is 0

  * CVE-2023-5717
    - perf: Disallow mis-matched inherited group reads

  * CVE-2023-5178
    - nvmet-tcp: Fix a possible UAF in queue intialization setup

  * CVE-2023-5158
    - vringh: don't use vringh_kiov_advance() in vringh_iov_xfer()

  * CVE-2023-5090
    - x86: KVM: SVM: always update the x2avic msr interception

  * usbip: error: failed to open /usr/share/hwdata//usb.ids (LP: #2039439)
    - [Packaging] Make linux-tools-common depend on hwdata

  * Unable to use nvme drive to install Ubuntu 23.10 (LP: #2040157)
    - misc: rtsx: Fix some platforms can not boot and move the l1ss judgment to
      probe

  * Lunar update: upstream stable patchset 2023-10-19 (LP: #2039884)
    - ACPI: thermal: Drop nocrt parameter
    - module: Expose module_init_layout_section()
    - arm64: module-plts: inline linux/moduleloader.h
    - arm64: module: Use module_init_layout_section() to spot init sections
    - ARM: module: Use module_init_layout_section() to spot init sections
    - lockdep: fix static memory detection even more
    - parisc: Cleanup mmap implementation regarding color alignment
    - parisc: sys_parisc: parisc_personality() is called from asm code
    - io_uring/parisc: Adjust pgoff in io_uring mmap() for parisc
    - kallsyms: Fix kallsyms_selftest failure
    - module/decompress: use vmalloc() for zstd decompression workspace
    - Upstream stable to v6.1.51, v6.4.14
    - erofs: ensure that the post-EOF tails are all zeroed
    - ksmbd: fix wrong DataOffset validation of create context
    - ksmbd: fix slub overflow in ksmbd_decode_ntlmssp_auth_blob()
    - ksmbd: replace one-element array with flex-array member in struct
      smb2_ea_info
    - ksmbd: reduce descriptor size if remaining bytes is less than request size
    - ARM: pxa: remove use of symbol_get()
    - mmc: au1x...

Changed in linux (Ubuntu Lunar):
status: Fix Committed → Fix Released
Tim Gardner (timg-tpi)
tags: added: verification-done-lunar-linux-aws verification-done-lunar-linux-azure
removed: verification-needed-lunar-linux-aws verification-needed-lunar-linux-azure
tags: added: verification-done-lunar-linux-kvm
removed: verification-needed-lunar-linux-kvm
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp-6.2/6.2.0-1021.23~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-gcp-6.2' to 'verification-done-jammy-linux-gcp-6.2'. If the problem still exists, change the tag 'verification-needed-jammy-linux-gcp-6.2' to 'verification-failed-jammy-linux-gcp-6.2'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-gcp-6.2-v2 verification-needed-jammy-linux-gcp-6.2
description: updated
description: updated
description: updated
Changed in linux (Ubuntu Mantic):
importance: Undecided → High
Changed in linux (Ubuntu Noble):
importance: Undecided → High
Changed in linux (Ubuntu Mantic):
assignee: nobody → Roxana Nicolescu (roxanan)
Changed in linux (Ubuntu Noble):
assignee: nobody → Roxana Nicolescu (roxanan)
Changed in linux (Ubuntu Mantic):
status: New → In Progress
Changed in linux (Ubuntu Noble):
status: Invalid → In Progress
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/6.5.0-1018.18 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-mantic-linux-gcp' to 'verification-done-mantic-linux-gcp'. If the problem still exists, change the tag 'verification-needed-mantic-linux-gcp' to 'verification-failed-mantic-linux-gcp'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-mantic-linux-gcp-v2 verification-needed-mantic-linux-gcp
Changed in linux (Ubuntu Mantic):
status: In Progress → Fix Committed
Changed in linux (Ubuntu Noble):
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.