opeanfs-modules-dkms FTBS with linux 6.5 on jammy

Bug #2043195 reported by Andrea Righi
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
openafs (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Committed
Undecided
Unassigned

Bug Description

[Impact]

/var/lib/dkms/openafs/1.8.8.1/build/src/crypto/hcrypto/kernel/config.h:94:20: error: static declaration of ‘abort’ follows non-static declaration
   94 | static_inline void abort(void) {osi_Panic("hckernel aborting\n");}
      | ^~~~~

[Test case]

 $ sudo apt install openafs-modules-dkms

[Fix]

Backport changes from mantic to properly support the new 6.5 kernel ABI.

[Regression pontential]

We may experience regressions in systems that are using the OpenAFS filesystem, especially with 6.5 kernels (and above).

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: openafs-modules-dkms 1.8.8.1-3ubuntu2~22.04.2
ProcVersionSignature: User Name 6.5.0-9.9~22.04.2-generic 6.5.3
Uname: Linux 6.5.0-9-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Fri Nov 10 12:04:43 2023
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: openafs
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Andrea Righi (arighi) wrote :
Revision history for this message
Andrea Righi (arighi) wrote :

Applying individual patches from mantic is not trivial, certain fixes are dependent on other patches/changes and the backport of all these changes would be really bug prone.

Therefore after a detail evaluation and testing it seems safer to backport the whole package from mantic, considering that the kernel/user-space ABI seems to be fully compatible. Moreover the version in mantic has been extensively tested already with the 6.5 kernel.

The autopkgtest can be used to smoke test the new version of openafs with the jammy user-space. Test result was positive and no regression has been found so far.

The patch reported in attach suggests to use the version of openafs from mantic and simply recompile the module with the jammy user-space.

Revision history for this message
Andrea Righi (arighi) wrote :

Test result with the new openafs version in jammy (tested both with the GA kernel and the new 6.5 hwe kernel):

ubuntu@jammy$ uname -r
5.15.0-91-generic
ubuntu@jammy$ sudo dpkg -i openafs-modules-dkms_1.8.10-1ubuntu2~22.04.1_all.deb
(Reading database ... 194503 files and directories currently installed.)
Preparing to unpack openafs-modules-dkms_1.8.10-1ubuntu2~22.04.1_all.deb ...
Unpacking openafs-modules-dkms (1.8.10-1ubuntu2~22.04.1) over (1.8.10-1ubuntu2~22.04.1) ...
Setting up openafs-modules-dkms (1.8.10-1ubuntu2~22.04.1) ...
Loading new openafs-1.8.10 DKMS files...
Building for 5.15.0-91-generic
Building initial module for 5.15.0-91-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

openafs.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-91-generic/updates/dkms/

depmod...
...
ubuntu@jammy$ sudo autopkgtest . -- null
...
./openafs.orig/1.8.8.1/build/make.log
autopkgtest [21:25:32]: test dkms-autopkgtest: -----------------------]
autopkgtest [21:25:32]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
dkms-autopkgtest PASS
autopkgtest [21:25:32]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-autopkgtest PASS

===========================

$ uname -r
6.5.0-14-generic
$ sudo dpkg -i openafs-modules-dkms_1.8.10-1ubuntu2~22.04.1_all.deb
...
Unpacking openafs-modules-dkms (1.8.10-1ubuntu2~22.04.1) over (1.8.10-1ubuntu2~22.04.1) ...
Setting up openafs-modules-dkms (1.8.10-1ubuntu2~22.04.1) ...
Loading new openafs-1.8.10 DKMS files...
Building for 6.5.0-14-generic
Building initial module for 6.5.0-14-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

openafs.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.5.0-14-generic/updates/dkms/

depmod...

ubuntu@jammy$ sudo autopkgtest . -- null
...
autopkgtest [06:40:26]: test dkms-autopkgtest: -----------------------]
autopkgtest [06:40:26]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
dkms-autopkgtest PASS
autopkgtest [06:40:26]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-autopkgtest PASS
autopkgtest [06:40:26]: Binaries: resetting testbed apt configuration

tags: added: patch
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted openafs into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.8.10-1ubuntu2~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in openafs (Ubuntu Jammy):
status: New → Fix Committed
Changed in openafs (Ubuntu):
status: New → Invalid
tags: added: verification-needed verification-needed-jammy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.