opeanfs-modules-dkms FTBS with linux 6.5 on jammy

Bug #2052642 reported by Andrea Righi
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
openafs (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Committed
Undecided
Unassigned
Mantic
Fix Committed
Undecided
Unassigned

Bug Description

[Impact]

Despite the fix in LP: #2043195 openafs-modules-dkms still fails to build with the new jammy/linux-hwe-6.5 kernel:

In file included from /var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-6.5.0-17-generic-SP/sha256-kernel.c:34:
/var/lib/dkms/openafs/1.8.8.1/build/src/crypto/hcrypto/kernel/config.h:94:20: error: static declaration of ‘abort’ follows non-static declaration
   94 | static_inline void abort(void) {osi_Panic("hckernel aborting\n");}
      | ^~~~~
In file included from ./include/linux/kernel.h:29,
                 from ./arch/x86/include/asm/percpu.h:27,
                 from ./arch/x86/include/asm/preempt.h:6,
                 from ./include/linux/preempt.h:79,
                 from ./include/linux/spinlock.h:56,
                 from ./include/linux/wait.h:9,
                 from /var/lib/dkms/openafs/1.8.8.1/build/src/afs/sysincludes.h:118,
                 from /var/lib/dkms/openafs/1.8.8.1/build/src/crypto/hcrypto/kernel/config.h:30:
./include/linux/panic.h:36:6: note: previous declaration of ‘abort’ with type ‘void(void)’
   36 | void abort(void);
      | ^~~~~
make[5]: *** [scripts/Makefile.build:251: /var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-6.5.0-17-generic-SP/sha256-kernel.o] Error 1

[Test case]

Install the latest 6.5 kernel, then:

 $ sudo apt install openafs-modules-dkms

[Fix]

Backport the fix from mantic to properly support the new linux 6.5 kernel ABI.

[Regression potential]

We may experience regressions in systems that are using openafs, the change to build the module is minimal, so we shouldn't expect data corruption or similar, worst case the module could still fail to build with newer kernels.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: openafs-modules-dkms 1.8.8.1-3ubuntu2~22.04.2
ProcVersionSignature: User Name 5.15.0-94.104-generic 5.15.136
Uname: Linux 5.15.0-94-generic x86_64
NonfreeKernelModules: openafs
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Wed Feb 7 14:58:27 2024
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
RebootRequiredPkgs: Error: path contained symlinks.
SourcePackage: openafs
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Andrea Righi (arighi) wrote :
Revision history for this message
Andrea Righi (arighi) wrote :
Revision history for this message
Andrea Righi (arighi) wrote :
tags: added: patch
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted openafs into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.8.10-2ubuntu1~23.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in openafs (Ubuntu):
status: New → Invalid
Changed in openafs (Ubuntu Mantic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-mantic
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in openafs (Ubuntu Jammy):
status: New → Confirmed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Andrea, or anyone else affected,

Accepted openafs into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.8.10-2ubuntu1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in openafs (Ubuntu Jammy):
status: Confirmed → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Andrea Righi (arighi) wrote :

New package from jammy-proposed tested both with the GA kernel and the new hwe-6.5 kernel with positive results. Following the details:

- 6.5.0-17-generic

Module build:

openafs.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.5.0-17-generic/updates/dkms/

autopkgtest result:

autopkgtest [07:31:07]: test dkms-autopkgtest: -----------------------]
autopkgtest [07:31:08]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
dkms-autopkgtest PASS
autopkgtest [07:31:08]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-autopkgtest PASS
autopkgtest [07:31:08]: Binaries: resetting testbed apt configuration

- 5.15.0-100-generic

Module build:

openafs.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-100-generic/updates/dkms/

autopkgtest result:

autopkgtest [07:43:54]: test dkms-autopkgtest: -----------------------]
autopkgtest [07:43:54]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
dkms-autopkgtest PASS
autopkgtest [07:43:54]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-autopkgtest PASS
autopkgtest [07:43:54]: Binaries: resetting testbed apt configuration

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Jonas Purtschert (jonasleft) wrote :

Proposed fix works on our Jammy Server with new Kernel:

- Ubuntu 22.04.4 LTS Server
- Kernel: 6.5.0-17-generic

Installed from jammy-proposed with:

apt install openafs-modules-dkms/jammy-proposed

AFS+Kerberos is now working again on our server.
Thanks!

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the
> package you tested,

Hi everyone who tested, thank you for the verification!

But please please, state the version of the package you used. Just saying "in jammy-proposed" is not specific enough.

That being said, this update is missing the mantic verification, which blocks a jammy release.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This update is missing the mantic verification, which blocks a jammy release.

Revision history for this message
Jonas Purtschert (jonasleft) wrote :

> But please please, state the version of the package you used. Just saying "in jammy-proposed" is not specific enough.

Hope thats okay now:

$ apt list --installed | grep openafs
openafs-client/jammy-proposed,now 1.8.10-2ubuntu1~22.04.1 amd64 [installed]
openafs-krb5/jammy,now 1.8.10-2~ppa3~ubuntu22.04.1 amd64 [installed]
openafs-modules-dkms/jammy-proposed,jammy-proposed,now 1.8.10-2ubuntu1~22.04.1 all [installed]

$ uname -r
6.5.0-17-generic

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 22.04.4 LTS
Release: 22.04
Codename: jammy

Revision history for this message
Achim Bohnet (allee) wrote :

Works for me on 6 jammy hosts:

# dpkg -l openafs\* | grep ^i
ii openafs-client 1.8.10-2ubuntu1~22.04.1 amd64 AFS distributed filesystem client support
ii openafs-doc 1.8.10-2ubuntu1~22.04.1 all AFS distributed filesystem documentation
ii openafs-krb5 1.8.10-2ubuntu1~22.04.1 amd64 AFS distributed filesystem Kerberos 5 integration
ii openafs-modules-dkms 1.8.10-2ubuntu1~22.04.1 all AFS distributed filesystem kernel module DKMS source

# uname -a
Linux it01lt 6.5.0-26-generic #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Mar 12 10:22:43 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This update is still missing the mantic verification, which blocks a jammy release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.