libgcrypt < 1.10.2 returns wrong sha3 hashes for inputs > 4 GiB

Attached is a reproducer adapted from the regression test included with newer libgcrypt versions. Compiled with `cc -o hashtest hashtest.c -lgcrypt` it will die with an assertion in the error case.

Bad:
$ ./hashtest
Ohhhh jeeee: Assertion `count < bsize' failed (../../cipher/keccak.c:864:keccak_write)
Aborted (core dumped)
$

Good:
$ ./hashtest
$

Fix for jammy attached

!!! Warning !!!

hashtest.c allocates 5GB of RAM, do not run on 32-bit architectures.

Do not run if you don't have that much RAM free, as it will likely trigger OOM kill of your machine.

!!! Warning !!!

The attachment "libgcrypt.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Thanks for the patch Tobias! I created a PPA to test it here: https://launchpad.net/~lvoytek/+archive/ubuntu/libgcrypt-sha3-test

I confirmed it works by running the following:

# lxc launch ubuntu:jammy test-libgcrypt-jammy
# lxc shell test-libgcrypt-jammy

# add-apt-repository ppa:lvoytek/libgcrypt-sha3-test
# apt update && apt dist-upgrade -y
# apt install wget gcc libgcrypt20-dev -y
# wget https://bugs.launchpad.net/ubuntu/+source/libgcrypt20/+bug/2044852/+attachment/5723975/+files/hashtest.c
# cc -o hashtest hashtest.c -lgcrypt
# ./hashtest

Overall the patch looks good, I'd just recommend using a DEP-3 header to show the origin of the change, etc for easy access later

Thanks for testing Lena! Updated diff including Origin tag attached

Hi Tobias,

Thanks for the debdiff, it looks good to be uploaded. However, SRU policy states that we fix later releases first: https://wiki.ubuntu.com/StableReleaseUpdates#General_Requirements

Could you clarify the status of all supported releases as well as devel, and if relevant, provide the relevant debdiffs?

TIA :)

Answering to myself: According to bug title, this is fixed in Noble and Mantic, but not in Lunar and Jammy.

I'm unsubscribing ubuntu-sponsors, please resubscribe once you address the Lunar question :)

It turns out that lunar is also already fixed since Debian backported the fix to 1.10.1-3, see d/p/35-keccak-Use-size_t-to-avoid-integer-overflow.patch

So this really only needs to be fixed in jammy. Resubscribing sponsors.

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libgcrypt20_1.9.4-3ubuntu3.1.dsc: done.
  Uploading libgcrypt20_1.9.4-3ubuntu3.1.debian.tar.xz: done.
  Uploading libgcrypt20_1.9.4-3ubuntu3.1_source.buildinfo: done.
  Uploading libgcrypt20_1.9.4-3ubuntu3.1_source.changes: done.
Successfully uploaded packages.

Thank you

(inline used correct sru version number, and added bug reference)

Hello Tobias, or anyone else affected,

Accepted libgcrypt20 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libgcrypt20/1.9.4-3ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted libgcrypt20 (1.9.4-3ubuntu3.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

systemd/249.11-0ubuntu3.11 (ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#libgcrypt20

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!