hiredis FTBFS on ppc64el

PPA build: https://launchpad.net/~mkukri/+archive/ubuntu/dev-ppc64el/+build/27637841

Thank you for your work there. The package is currently in sync with Debian, could you send the patch to them since the fix will benefit them at some point when gcc is updated and will allow us to not have to carry an Ubuntu delta...

@seb128, does Debian also build ppc64el with -O3 -flto? both of those flags are needed for this error to occur.

@mkukri, no they don't, but is the patch incorrect and would create issues when building with another optimization level? if not it would still be right for Debian to carry the fix even if they don't strictly need it for their default build...

I disagree with Seb, this does seem reasonable to ship as an Ubuntu delta. Usually I would agree with Seb's reasoning: Debian could benefit from this, and in fact, I'd suggest you send it to them still just to see what they say.

This all being said, in my own prior experience, Debian Maintainers are not inclined to accept these patches. -O3 is Ubuntu-specific, and Debian Policy in recent years explicitly prohibits vendor patches. If this Debian maintainer happens to be particularly cooperative, sure, I'm happy to sync over this. That being said, the patch fixes a current, Ubuntu-specific FTBFS, so I will be sponsoring it.

Small nitpick with the patch itself, I would have included this bug report in it. Will just add that line prior to uploading.

Thanks.

I'm fine with having the delta but I would have liked to see the patch forwarded to Debian still (and I usually block upload on that to happen because from experience once the change is uploaded the probably that the forward or anything extra requested happens drops)

I am no DD, and even definitely more not the hiredis maintainer in Debian, but I consider this workaround for a bug in Ubuntu's compiler exposed by Ubuntu's dpkg flags.

I do admit however that I could be better at up-streaming patches relevant to Debian in general, I just don't think this specific patch is one of them.

(As a sidenote, it might be relevant as a gcc bug report to figure out why the compiler marks those writes as out of bounds, but only on PPC with -O3 and -flto (not even the same options cause the errors on amd64))

This was uploaded[1], and we can see that the ppc64el build succeeded. The package is currently in noble-proposed going through migration.

Marking the bug as "fix committed". I raced the sponsorship queue report, as this was still in the queue a few hours ago :)

1. https://launchpad.net/ubuntu/+source/hiredis/1.2.0-6ubuntu1

This bug was fixed in the package hiredis - 1.2.0-6ubuntu1

---------------
hiredis (1.2.0-6ubuntu1) noble; urgency=medium

  * d/p/sds_ppc64el_ftbfs.patch: Fix FTBFS on ppc64el (LP: #2049188)

 -- Mate Kukri <email address hidden> Fri, 12 Jan 2024 09:27:18 +0000