Enable the mic-mute led on Dell MTL laptops

Bug #2049569 reported by Chris Chiu
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
HWE Next
New
Undecided
Unassigned
firmware-sof (Ubuntu)
Status tracked in Noble
Jammy
Fix Released
Undecided
Unassigned
Noble
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Status tracked in Noble
Jammy
Invalid
Undecided
Unassigned
Noble
Fix Released
Undecided
Unassigned
linux-oem-6.5 (Ubuntu)
Status tracked in Noble
Jammy
Fix Released
Undecided
Unassigned
Noble
Invalid
Undecided
Unassigned

Bug Description

[SRU Justifications]

========== kernels ==========

[Impact]
On Dell's Precision 3550, Intel MTL platform, the MIC-Mute function is working but the LED(on F4) state is not changed accordingly.

[Fix]
There's no problem on the same series on RPL platform. It needs MTL specific SoF driver and controls to support the registered mixer switch. It requires the patches in https://<email address hidden>/ and https://<email address hidden>/

[Test Case]
1. press mic-mute hot-key and check if mic-mute is enabled or not by the OSD icon.
2. The mic-mute led should be ON when mic-mute enabled, OFF when disabled.

[Where problems could occur]
It's only required for new sof-audio-pci-intel-mtl driver. The impact should be restricting.

========== firmware-sof ==========

[Impact]
The mic-mute led not working on Intel MTL powered laptops.

[Fix]
For firmware-sof, it required the upstream commit fdc884baa4b3 ("Add sof-ipc4-v2.8.1/mtl/, intel-signed + community") and the sof-hda-generic-2ch.tplg from v2.8.1 to make sure the ipc4 topology and control matches with the updated driver.

[Test Case]
1. enable -proposed pocket and install firmware-sof-signed
2. press mic-mute hot-key and check if mic-mute is enabled or not by the OSD icon.

[Where problems could occur]
The updated sof-mtl.ri and the sof-hda-generic-2ch.tplg are shared by all Intel MTL platforms. Need to verify audio function on MTL enpowered machines.

Chris Chiu (mschiu77)
description: updated
Chris Chiu (mschiu77)
tags: added: oem-priority originate-from-2047635 somerville
Chris Chiu (mschiu77)
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

these are from 6.7, noble has that

Changed in linux-oem-6.5 (Ubuntu Noble):
status: New → Invalid
Changed in linux (Ubuntu Jammy):
status: New → Invalid
Changed in linux-oem-6.5 (Ubuntu Jammy):
status: New → Fix Released
Changed in linux (Ubuntu Noble):
status: New → Fix Released
Timo Aaltonen (tjaalton)
Changed in linux-oem-6.5 (Ubuntu Jammy):
status: Fix Released → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-6.5/6.5.0-1014.15 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-oem-6.5' to 'verification-done-jammy-linux-oem-6.5'. If the problem still exists, change the tag 'verification-needed-jammy-linux-oem-6.5' to 'verification-failed-jammy-linux-oem-6.5'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-oem-6.5-v2 verification-needed-jammy-linux-oem-6.5
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

not really verified, but can't remove at this point anymore

tags: added: verification-done-jammy-linux-oem-6.5
removed: verification-needed-jammy-linux-oem-6.5
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (96.9 KiB)

This bug was fixed in the package linux-oem-6.5 - 6.5.0-1014.15

---------------
linux-oem-6.5 (6.5.0-1014.15) jammy; urgency=medium

  * jammy/linux-oem-6.5: 6.5.0-1014.15 -proposed tracker (LP: #2048371)

  * DP connection swap to break eDP behavior on AMD 7735U (LP: #2049758)
    - drm/amd/display: Pass pwrseq inst for backlight and ABM

  * Disable keyboard wakeup for Framework 13 (LP: #2048735)
    - platform/x86/amd/pmc: Move platform defines to header
    - platform/x86/amd/pmc: Only run IRQ1 firmware version check on Cezanne
    - platform/x86/amd/pmc: Move keyboard wakeup disablement detection to pmc-
      quirks
    - platform/x86/amd/pmc: Disable keyboard wakeup on AMD Framework 13

  * Enable the mic-mute led on Dell MTL laptops (LP: #2049569)
    - ASoC: SOF: ipc4-control: Add support for ALSA switch control
    - ASoC: SOF: ipc4-topology: Add definition for generic switch/enum control

  * Support Mediatek MT7925 WiFi/BT (LP: #2043542)
    - wifi: mt76: mt7603: rework/fix rx pse hang check
    - wifi: mt76: mt7603: improve watchdog reset reliablity
    - wifi: mt76: mt7603: improve stuck beacon handling
    - wifi: mt76: connac: move connac3 definitions in mt76_connac3_mac.h
    - wifi: mt76: remove unused error path in mt76_connac_tx_complete_skb
    - wifi: mt76: mt7996: set correct wcid in txp
    - wifi: mt76: mt7996: fix beamform mcu cmd configuration
    - wifi: mt76: mt7996: fix beamformee ss subfield in EHT PHY cap
    - wifi: mt76: mt7996: fix wmm queue mapping
    - wifi: mt76: mt7996: fix rx rate report for CBW320-2
    - wifi: mt76: mt7996: fix TWT command format
    - wifi: mt76: update beacon size limitation
    - wifi: mt76: fix potential memory leak of beacon commands
    - wifi: mt76: get rid of false alamrs of tx emission issues
    - wifi: mt76: fix per-band IEEE80211_CONF_MONITOR flag comparison
    - wifi: mt76: mt7915: fix beamforming availability check
    - wifi: mt76: mt7996: enable BSS_CHANGED_MU_GROUPS support
    - wifi: mt76: mt7615: enable BSS_CHANGED_MU_GROUPS support
    - wifi: mt76: enable UNII-4 channel 177 support
    - wifi: mt76: mt7915: report tx retries/failed counts for non-WED path
    - wifi: mt76: report non-binding skb tx rate when WED is active
    - wifi: mt76: mt7915: drop return in mt7915_sta_statistics
    - wifi: mt76: mt7996: drop return in mt7996_sta_statistics
    - wifi: mt76: mt7921: remove macro duplication in regs.h
    - wifi: mt76: mt7915: move mib_stats structure in mt76.h
    - wifi: mt76: mt7996: rely on mib_stats shared definition
    - wifi: mt76: mt7921: rely on mib_stats shared definition
    - wifi: mt76: mt7915: add support for MT7981
    - wifi: mt76: mt7921e: report tx retries/failed counts in tx free event
    - wifi: mt76: add tx_nss histogram to ethtool stats
    - wifi: mt76: mt7915: accumulate mu-mimo ofdma muru stats
    - wifi: mt76: mt7921: Support temp sensor
    - wifi: mt76: mt7915: disable WFDMA Tx/Rx during SER recovery
    - wifi: mt76: mt7996: disable WFDMA Tx/Rx during SER recovery
    - wifi: mt76: mt7921: make mt7921_mac_sta_poll static
    - mt76: mt7996: rely on mt76_sta_stats in mt76_wcid
    - wifi: mt76: mt7921: get rid of MT7921_RESET...

Changed in linux-oem-6.5 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Chris Chiu (mschiu77)
description: updated
Chris Chiu (mschiu77)
description: updated
Chris Chiu (mschiu77)
description: updated
Revision history for this message
Chris Chiu (mschiu77) wrote :

attach debdiff of firmware-sof for Jammy, Mantic and Noble.

Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Chris Chiu (mschiu77) wrote :

Attache the proposed .deb package file for Jammy, Mantic and Noble

Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "debdiff for jammy" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in firmware-sof (Ubuntu Jammy):
status: New → Confirmed
Changed in firmware-sof (Ubuntu):
status: New → Confirmed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Are you able to test this on mantic with mantic kernel? If not, skip mantic.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2023.12.1-1ubuntu1

---------------
firmware-sof (2023.12.1-1ubuntu1) noble; urgency=low

  * Merge from Debian unstable (LP: #2049569). Remaining changes:
    - compress sof firmware with zstd
  * Drop old delta, all upstream.

firmware-sof (2023.12.1-1) unstable; urgency=medium

  * Update to upstream version 2023-12.1

firmware-sof (2023.12-1) unstable; urgency=medium

  * Update to upstream version 2023-12

firmware-sof (2023.09-1) unstable; urgency=medium

  * Update to upstream version 2023-09

 -- Ubuntu Merge-o-Matic <email address hidden> Sat, 09 Mar 2024 15:47:29 +0000

Changed in firmware-sof (Ubuntu Noble):
status: Confirmed → Fix Released
Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Chris, or anyone else affected,

Accepted firmware-sof into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/firmware-sof/2.0-1ubuntu4.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in firmware-sof (Ubuntu Jammy):
status: Confirmed → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Accepted into -proposed, but as part of firmware-sof verification, please also verify audio function on MTL enpowered machines as mentioned in the regression potential section. Thank you!

Revision history for this message
Leo Lin (0xff07) wrote :

The firmware-sof-signed in -proposed doesn't seem to fix the LEDs at least on one HP platform. Reading the file from /sys/class/sound/ctl-led/mic/card0/list shows nothing.

The md5sum of sof-ace-tplg/sof-hda-generic-2ch.tplg also doesn't match the one in upstream v2023.12.1 release.

# From upstream release
$ md5sum sof-bin-2023.12.1/sof-ace-tplg/sof-hda-generic-2ch.tplg
4f97f6f77ebeb5e8ed78923c36bc897e sof-bin-2023.12.1/sof-ace-tplg/sof-hda-generic-2ch.tplg

# From 2.0-1ubuntu4.6
$ md5sum sof-ace-tplg/sof-hda-generic-2ch.tplg
100186829692a835c518a34a576569c3 sof-ace-tplg/sof-hda-generic-2ch.tplg

tags: added: verification-failed-jammy
removed: verification-needed-jammy
Revision history for this message
Chris Chiu (mschiu77) wrote :

Sorry for the mistake. The sof-hda-generic-2ch.tplg is replaced for non-MTL platform which would cause regression.

new MR for jammy proposed to restore the sof-tplg/sof-hda-generic-2ch.tplg and replace the same file in sof-ace-tplg for MTL
https://code.launchpad.net/~mschiu77/ubuntu/+source/firmware-sof/+git/firmware-sof/+merge/462688

The `md5sum` of the files down below should match the upstream sof-bin-2023.12.1
$ md5sum lib/firmware/intel/sof-ace-tplg/sof-hda-generic-2ch.tplg
4f97f6f77ebeb5e8ed78923c36bc897e lib/firmware/intel/sof-ace-tplg/sof-hda-generic-2ch.tplg
$ md5sum lib/firmware/intel/sof-ipc4/mtl/sof-mtl.ri
fe5ef04483649481146baf87059555f9 lib/firmware/intel/sof-ipc4/mtl/sof-mtl.ri
$ md5sum lib/firmware/intel/sof-ipc4/mtl/community/sof-mtl.ri
438869b48941968ab0b9c46877e9d1fa lib/firmware/intel/sof-ipc4/mtl/community/sof-mtl.ri
$ md5sum lib/firmware/intel/sof-ipc4/mtl/intel-signed/sof-mtl.ri
fe5ef04483649481146baf87059555f9 lib/firmware/intel/sof-ipc4/mtl/intel-signed/sof-mtl.ri

PPA for jammy uploaded to https://launchpad.net/~mschiu77/+archive/ubuntu/ppa-2049569-4.7
@Leo Lin, please verify with the new PPA. Thanks

Revision history for this message
Leo Lin (0xff07) wrote :

@mschiu77 the firmware-sof provided in your PPA works! The LEDs can toggle accordingly after installation.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Chris, or anyone else affected,

Accepted firmware-sof into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/firmware-sof/2.0-1ubuntu4.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-jammy
removed: verification-failed-jammy
Revision history for this message
Leo Lin (0xff07) wrote :

Installed the 2.0-1ubuntu4.7 version of firmware-sof-signed on the previously failed HP platform. Confirmed that now the LEDs can toggle accordingly.

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Bin Li (binli) wrote (last edit ):

Installed the 2.0-1ubuntu4.7 version of firmware-sof-signed on the previously failed ThinkPad platforms. Confirmed that now the LEDs can toggle accordingly.

tags: added: originate-from-2047202 sutton
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2.0-1ubuntu4.7

---------------
firmware-sof (2.0-1ubuntu4.7) jammy; urgency=medium

  * Enable the mic-mute led on Dell MTL laptops. LP: #2049569
    - Resotore sof-hda-generic-2ch.tplg for Intel platforms older than MTL
    - Add sof-v2.8.1 tplg for Intel Meteor Lake hardware
    - Reorder the sof-v2.8.1 patches to align with upstream

 -- Chris Chiu <email address hidden> Tue, 19 Mar 2024 19:14:54 +0800

Changed in firmware-sof (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Update Released

The verification of the Stable Release Update for firmware-sof has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.