Ubuntu
rsyslog package

ProtectHome setting in debian/rsyslog.service isn't understood by systemd

Bug #2051405 reported by Anthony Harrington
4
Affects Status Importance Assigned to Milestone
rsyslog (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Small bug introduced in commit e175f5c3668adc1c65f66efb61f70060569c9fe8
https://git.launchpad.net/ubuntu/+source/rsyslog/commit/?id=e175f5c3668adc1c65f66efb61f70060569c9fe8

which changed the rsyslog.service line of

ProtectHome=yes to ProtectHome=readonly

Systemd doesn't understand "readonly" https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html

and will mention in its journal:

systemd[1]: /lib/systemd/system/rsyslog.service:24: Failed to parse protect home value, ignoring: readonly

Quickfix: just needs a hyphen on line 24 to read 'read-only'

Related branches

~xypron/ubuntu/+source/rsyslog:merge-lp2051405-noble-8.2312.0-3ubuntu3
Nick Rosbrook (community): Approve
Ubuntu Sponsors: Pending requested
git-ubuntu import: Pending requested
Diff: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/rsyslog.service (+1/-1)
~xypron/ubuntu/+source/rsyslog:merge-lp2051405-noble-8.2312.0-3ubuntu3
Nick Rosbrook (community): Needs Information
Ubuntu Sponsors: Pending requested
git-ubuntu import: Pending requested
Diff: 3344 lines (+2719/-43)
38 files modified
debian/00rsyslog.conf (+12/-0)
debian/50-default.conf (+48/-0)
debian/NEWS (+30/-0)
debian/README.apparmor (+132/-0)
debian/README.apparmor.rsyslog.d (+16/-0)
debian/apparmor/rsyslog-gnutls.apparmor (+3/-0)
debian/apparmor/rsyslog-mysql.apparmor (+20/-0)
debian/apparmor/rsyslog-openssl.apparmor (+3/-0)
debian/apparmor/rsyslog-pgsql.apparmor (+9/-0)
debian/changelog (+1878/-0)
debian/clean (+6/-0)
debian/control (+7/-2)
debian/dmesg.service (+13/-0)
debian/patches/omusrmsg-bugfix-potential-double-free-which-can-caus.patch (+69/-0)
debian/patches/plugins-FromHost-must-be-63-characters-long.patch (+44/-0)
debian/patches/series (+2/-0)
debian/reload-apparmor-profile (+14/-0)
debian/rsyslog-gnutls.install (+1/-0)
debian/rsyslog-mysql.install (+1/-0)
debian/rsyslog-openssl.install (+1/-0)
debian/rsyslog-pgsql.install (+1/-0)
debian/rsyslog.conf (+10/-26)
debian/rsyslog.dirs (+1/-0)
debian/rsyslog.docs (+1/-0)
debian/rsyslog.install (+6/-1)
debian/rsyslog.logcheck.ignore.server (+3/-0)
debian/rsyslog.postinst (+29/-0)
debian/rsyslog.postrm (+13/-0)
debian/rsyslog.service (+4/-8)
debian/rules (+8/-2)
debian/tests/apparmor-include-mechanism (+92/-0)
debian/tests/control (+20/-0)
debian/tests/logcheck (+13/-4)
debian/tests/simple-logger (+24/-0)
debian/tests/simple-mysql (+29/-0)
debian/tests/simple-pgsql (+25/-0)
debian/tests/utils (+76/-0)
debian/usr.sbin.rsyslogd (+55/-0)
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

Thanks Anthony for reporting the issue.

According to the systemd.exec.5 man-page:

ProtectHome= Takes a boolean argument or the special values "read-only" or "tmpfs".

Debian's rsyslog 8.2312.0-2 has
debian/rsyslog.service:24:ProtectHome=yes

Ubuntu's rsyslog 8.2312.0-2ubuntu1 has
debian/rsyslog.service:24:ProtectHome=readonly

Only Ubuntu Noble is affected.

Changed in rsyslog (Ubuntu):
status: New → Confirmed
assignee: nobody → Heinrich Schuchardt (xypron)
tags: added: foundations-todo
tags: added: fr-6404
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

Merge request https://code.launchpad.net/~xypron/ubuntu/+source/rsyslog/+git/rsyslog/+merge/459640

Changed in rsyslog (Ubuntu):
assignee: Heinrich Schuchardt (xypron) → nobody
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

rsyslog - 8.2312.0-3ubuntu3 is available in ppa:xypron/rsyslog2312.

Revision history for this message
Heinrich Schuchardt (xypron) wrote :

With the change an autopkgtests succeeded but an upgrade failed.

Changed in rsyslog (Ubuntu):
assignee: nobody → Heinrich Schuchardt (xypron)
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

Merge request updated:
https://code.launchpad.net/~xypron/ubuntu/+source/rsyslog/+git/rsyslog/+merge/459640

Changed in rsyslog (Ubuntu):
assignee: Heinrich Schuchardt (xypron) → nobody
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

The package has been built as rsyslog 8.2312.0-3ubuntu3 to 8.2312.0-3ubuntu3+ppa1 in ppa:xypron/rsyslog2312.

Autopkgtests where successful:
https://autopkgtest.ubuntu.com/results/autopkgtest-noble-xypron-rsyslog2312/noble/amd64/r/rsyslog/20240214_111854_b3b15@/log.gz

Installation on an amd64 system showed no issues.

Revision history for this message
Heinrich Schuchardt (xypron) wrote :

With ProtectHome=read-only autopkgtests passed but when updating locally the systemd service failed to start due to an access problem in the /run directory.

Nick Rosbrook (enr0n)
Changed in rsyslog (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rsyslog - 8.2312.0-3ubuntu3

---------------
rsyslog (8.2312.0-3ubuntu3) noble; urgency=medium

  * ubuntu d/rsyslog.service ProtectHome=no (LP: #2051405)

 -- Heinrich Schuchardt <email address hidden> Sat, 27 Jan 2024 10:34:41 +0100

Changed in rsyslog (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Anthony Harrington (linuxchemist) wrote :

Thank you :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.