hfsutils: FTBFS: hpwd.c:55:7: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]

Bug #2060708 reported by Benjamin Drung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
hfsutils (Debian)
Fix Released
Unknown
hfsutils (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Imported from Debian bug http://bugs.debian.org/1066216:

Source: hfsutils
Version: 3.2.6-15
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: <email address hidden>
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Ilibhfs -I/usr/include/tcl -I/usr/include/tk -DHAVE_CONFIG_H -DUSE_INTERP_RESULT -c -o hpwd.o hpwd.c
> hpwd.c: In function ‘hpwd_main’:
> hpwd.c:55:7: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]
> 55 | if (strcmp(ent->cwd, ":") == 0)
> | ^~~~~~
> hpwd.c:32:1: note: include ‘<string.h>’ or provide a declaration of ‘strcmp’
> 31 | # include "hpwd.h"
> +++ |+#include <string.h>
> 32 |
> cc1: some warnings being treated as errors
> make[1]: *** [<builtin>: hpwd.o] Error 1

The full build log is available from:
http://qa-logs.debian.net/2024/03/13/hfsutils_3.2.6-15_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;<email address hidden>
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&<email address hidden>&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Benjamin Drung (bdrung)
tags: added: update-excuse
Changed in hfsutils (Debian):
importance: Undecided → Unknown
Revision history for this message
Benjamin Drung (bdrung) wrote :

Uploaded hfsutils 3.2.6-15ubuntu1.

Changed in hfsutils (Ubuntu):
importance: Undecided → Critical
importance: Critical → High
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hfsutils - 3.2.6-15ubuntu1

---------------
hfsutils (3.2.6-15ubuntu1) noble; urgency=medium

  * Explicitly import string.h (Closes: #1066216, LP: #2060708)

 -- Benjamin Drung <email address hidden> Tue, 09 Apr 2024 18:25:49 +0200

Changed in hfsutils (Ubuntu):
status: Fix Committed → Fix Released
Changed in hfsutils (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.