Launchpad itself

Application tab URLs shouldn't end in slashes

Bug #224235 reported by Matthew Paul Thomas
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Curtis Hovey

Bug Description

On this page:
* the "Overview" tab goes to launchpad.net/launchpad/
* the "Code" tab goes to code.launchpad.net/launchpad/
* the "Bugs" tab goes to bugs.launchpad.net/launchpad/
etc.

Instead:
* the "Overview" tab should go to launchpad.net/launchpad
* the "Code" tab should go to code.launchpad.net/launchpad
* the "Bugs" tab should go to bugs.launchpad.net/launchpad
etc.

The location bar does not have this problem, and neither does fmt:link.

<flacoste> mpt: i'd suggest filing a bug about this since it will require a lot of test fixes (maybe, maybe not)

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Why is this a problem?

Changed in launchpad:
status: New → Incomplete
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

For all the small reasons that it's usually bad for the same page to have multiple URLs. The page shows up with two entries in your browser history, instead of one; a link to the page from an external site might not show up as visited when it should; when bookmarking the page, the browser may not realize that you've already bookmarked it with the other URL; etc.

Changed in launchpad:
status: Incomplete → New
Diogo Matsubara (matsubara)
Changed in launchpad:
status: New → Confirmed
Francis J. Lacoste (flacoste)
Changed in launchpad:
importance: Undecided → Medium
milestone: none → 1.2.5
Revision history for this message
Curtis Hovey (sinzui) wrote :

I'm taking this bug, but I suspect it will slip to 1.2.6. Fixing the application tabs requires a single line change to the code, but I see this problem is really happening in all menu links.

Fixing the core tests will take minutes, but we need to fix dozens of tests because of this change. The testbrowser is navigating the tab links in the tests, and the URL is checked. Looking at a sample of the tests, I note that many of these should be checking the title not the URL. While I'm not propose to switch the tests to verify the page title, I would have a lot of work if the tests were following our policy.

I propose fixing FacetMenu first, the push the change down to MenuBase to limit the scope of the test changes.

Changed in launchpad:
assignee: nobody → sinzui-is
Curtis Hovey (sinzui)
Changed in launchpad:
status: Confirmed → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in RF 6349.

Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.