loggerhead

Visiting just "/download" or "/download/" redirects to a bad URL

Bug #247992 reported by Matt Nordhoff on 2008-07-12

Affects		Status	Importance	Assigned to	Milestone
	loggerhead	Fix Released	Wishlist	Matt Nordhoff

Latest Loggerhead trunk + bzr-search_integration and bzr.dev.

Visiting "/some/branch/download" or "/some/branch/download/" redirects to "/some/branch../changes", which obviously doesn't work.

This is probably caused by this code in loggerhead/controllers/download_ui.py, but I don't know the right fix:

if len(args) < 2:
raise httpexceptions.HTTPMovedPermanently(self._branch.url('../changes'))

Revision history for this message

Matt Nordhoff (mnordhoff) wrote on 2008-08-07:

I just unmarked this as a duplicate of bug 243422. This code *does* do (some) validation of user input; it just has a buggy response.

Martin Albisetti (beuno) on 2008-08-15

Revision history for this message

Martin Albisetti (beuno) wrote on 2009-06-01:

Does this still apply?

Changed in loggerhead:
status:	Confirmed → Triaged

Revision history for this message

Yes.

Matt Nordhoff (mnordhoff) on 2010-05-05

Changed in loggerhead:
assignee:	nobody → Matt Nordhoff (mnordhoff)
status:	Triaged → Fix Committed

Robert Collins (lifeless) on 2012-09-11

Changed in loggerhead:
status:	Fix Committed → Fix Released

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.