Launchpad itself

OOPS when trying to subscribe a private team to a bug

Bug #294719 reported by Ursula Junque
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Low
Unassigned

Bug Description

As seen on OOPS-1040EA82:

PrivatePersonLinkageError: Cannot link person (name=payson, visibility=PRIVATE_MEMBERSHIP) to <BugSubscription at 0x2aaaadcaa310> (name=None)

Also in OOPS-1040EA80, OOPS-1040EA81, OOPS-1040EA83, OOPS-1040EA85.

Another oops, OOPS-1039EB141, raised the following on IRC:
<Edwin> Ursinha: natick-team is currently not private, and it should be impossible for it to become the bug supervisor while it is private. Maybe someone was changing the privacy setting while someone else was editing something.

I'm opening this bug since it happened with another team and with 10 minutes interval between two oopses.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi brad, since this has come up at the same time that we were discussing the privacy, do you have time to close this bug for this cycle?

Changed in launchpad-registry:
assignee: nobody → bradcrittenden
milestone: none → 2.1.11
status: New → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → High
Revision history for this message
Curtis Hovey (sinzui) wrote :

This looks like a race condition. We may need to understand what the user was doing to reproduce the problem.

Changed in launchpad-registry:
assignee: bradcrittenden → edwin-grubbs
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

How was the ~payson team made private and the bug supervisor? I just tested this on staging, and the forms give you an error if you try to privatize a team that is the bug supervisor or if you try to set the bug supervisor to a private team.

The payson project needs to either have a new team set as its bug supervisor or the ~payson team needs to be made public, since making it possible to have a private bug supervisor is not a scheduled task.

The cause of the oops still needs to be fixed.

Revision history for this message
Joey Stanford (joey) wrote :

I changed the team to public so they can file bugs.

Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
milestone: 2.1.11 → 2.1.12
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

I am unable to recreate this issue, and it hasn't happened again since Nov 7, so I am going to change the importance to Medium.

If it is just an absurdly unlikely timing issued that caused these oopses, one fix is to use database triggers to enforce these constraints. However, that may be overkill for something that should be extremely rare.

Changed in launchpad-registry:
importance: High → Medium
Revision history for this message
Joey Stanford (joey) wrote : Re: [Bug 294719] Re: OOPS when trying to subscribe a private team to a bug

We can recreate this on demand. :-)

1) Setup a team to be the bug supervisor on a product which has private bugs.
2) Change the team visibility to private.
3) Subscribe to a private bug.

It's not happened since because I used my super-cow powers to make all
the teams public after someone else had made them private.

Joey

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

I double-checked with Joey about his steps for reproducing it, and I was unable to get it to work, so I am marking it incomplete.

Changed in launchpad-registry:
milestone: 2.1.12 → none
status: Triaged → Incomplete
Revision history for this message
Curtis Hovey (sinzui) wrote :

I suspect this report will be marked invalid when Launchpad addresses the core issue that private teams must not leak their names.

Changed in launchpad-registry:
assignee: edwin-grubbs → nobody
importance: Medium → Low
Revision history for this message
Barry Warsaw (barry) wrote :

I confirm Edwin's observation that Joey's steps do not work. Once the public team is made a bug supervisor, its visibility cannot be changed.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Changes to the code base appear to have fixed this before we setup to really provide this feature.

Changed in launchpad-registry:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.