sftp.py causes dput to fail if bzrlib not installed

Bug #297851 reported by Steve Langasek
4
Affects Status Importance Assigned to Milestone
dput (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Binary package hint: dput

the new sftp.py upload method includes the following code:

try:
    import bzrlib.transport
except Exception, e:
    print "E: bzrlib must be installed to use sftp transport."
    sys.exit(1)

This is a problem because dput uses a glob to import *all* the transports, so if bzrlib is not installed this import will fail on every invocation of dput, and bzr is only a recommends of the dput package.

Please fix this to not exit on import failure.

Related branches

Steve Langasek (vorlon)
Changed in dput:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dput - 0.9.2.35ubuntu3

---------------
dput (0.9.2.35ubuntu3) jaunty; urgency=low

  * sftp.py: import bzrlib.transport inside the upload method so that dput will
    not error out when bzrlib.transport is not available but the user isn't
    using the sftp transport anyhow. (LP: #297851)

 -- <email address hidden> (Cody A.W. Somerville) Fri, 14 Nov 2008 10:30:01 -0400

Changed in dput:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.