Unable to compile iscsitarget-source 0.4.15+svn148-2.1ubuntu2 on Intrepid

Bug #298520 reported by Garrett Fields
2
Affects Status Importance Assigned to Milestone
iscsitarget (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Using the method described here:
https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/145539

sudo apt-get install iscsitarget-source
sudo module-assistant
*prepare*
*select*
   --> Select iscsitarget
*build*

I got message:
In file included from/usr/src/modules/iscsitarget/kernel/block-io.c:12:
include/linux/parser.h:32: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘match_strlcpy’

Also reported here:
http://www.nabble.com/iscsitarget-0.4.16-with-2.6.26-kernel--td19276359.html

According to that thread, this problem also exists in 0.4.16 for these users.

Solution:
I looked at the current SVN for my inspiration.

I suggest someone send upload a modified iscsitarget-source file with the following fix:
in /modules/iscsitarget/kernel/block-io.c,

I replaced:

#include <linux/parser.h>
#include <linux/blkdev.h>
#include <linux/buffer_head.h>

with

#include <linux/types.h>
#include <linux/blkdev.h>
#include <linux/parser.h>
#include <linux/buffer_head.h>

According to a thread above, the location of parser.h was important. The additional types.h didn't seem to hurt either. Finding this would have been much quicker, but I didn't realize that the source was being unpacked from the bz2 file every time a build was attempted. (I'm not a pro at this sort of thing) My attempts to fix this was being overwritten until I modified the bz2 file. Anyway, hope this helps someone in the meantime until this can be fixed in the repository.

Related branches

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package iscsitarget - 0.4.16+svn162-2ubuntu1

---------------
iscsitarget (0.4.16+svn162-2ubuntu1) jaunty; urgency=low

  * Merge from debian unstable, fixes LP: #298520
   - Remaining changes:
    + debian/iscsitarget.init: lsb-ized the entire init script
      (Debian Bug: #506588)
    + debian/control: depend on lsb-base >= 3.2-14
   - Dropped changes:
    + debian/rules, usr/misc.h: -D_GNU_SOURCE no longer required,
      __qelem is explicitly defined by source

iscsitarget (0.4.16+svn162-2) unstable; urgency=high

  * Fix initscript. (Closes: #484107)

iscsitarget (0.4.16+svn162-1) unstable; urgency=low

  * New upstream snapshot.
  * Fix bashism in initscript. (Closes: #486035)
  * Bump standards to 3.8.0, no changes needed.
  * List all copyright holders and contributors in the copyright file.

 -- Dustin Kirkland <email address hidden> Sat, 22 Nov 2008 15:14:12 -0600

Changed in iscsitarget:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.