teams should be members of themselves

Bug #30789 reported by Stuart Bishop
8
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Guilherme Salgado

Bug Description

Carlos Perelló Marín wrote:

> Not really, I talked with Salgado about that because I assume the same
> but the test were failing, well, I assumed that
> rosetta_experts.inTeam(rosetta_experts) would return True (I think you
> misunderstood that code). A team is never member of its own team but

Hmm... this sounds like a bug in the team machinery to me.

>>> person_set = getUtility(IPersonSet)
>>> stub = person_set.getByName('stub')
>>> stub.inTeam(stub)
True
>>> admins = person_set.getByName('admins')
>>> admins.inTeam(admins)
False
>>>

IIRC People were members of their own team specifically so membership checks
could be done in a single database query.

 affects /products/launchpad

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Confirming as per steve's email to the list

Changed in launchpad:
status: Unconfirmed → Confirmed
Revision history for this message
Carlos Perelló Marín (carlos) wrote :

I had to add some code to workaround this problem on ITranslationGroupSet.getByPerson

Changed in launchpad:
assignee: nobody → salgado
Changed in launchpad:
status: Confirmed → In Progress
Revision history for this message
Stuart Bishop (stub) wrote :

Upping priority as this blocks onramp testing

Changed in launchpad:
importance: Medium → Critical
Changed in launchpad:
status: In Progress → Fix Committed
Stuart Bishop (stub)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Данило Шеган (danilo) wrote :

XXX in database/pofile.py, _can_edit_translations() mentions that the code should be changed once this is fixed. Carlos?

Changed in rosetta:
status: Unconfirmed → Confirmed
Revision history for this message
Carlos Perelló Marín (carlos) wrote :

I already addressed that in my firefox branch.

Revision history for this message
Joey Stanford (joey) wrote :

Carlos, is this now deployed?

Revision history for this message
Данило Шеган (danilo) wrote :

Fixed and removed a comment with another branch.

Changed in rosetta:
assignee: nobody → danilo
milestone: none → 1.2.3
status: Confirmed → In Progress
Revision history for this message
Данило Шеган (danilo) wrote :

This has been fixed in RF 5753.

Changed in rosetta:
status: In Progress → Fix Committed
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.