team map makes browser unacceptably slow

Bug #314238 reported by Ian Jackson
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Curtis Hovey

Bug Description

I went to the page
  https://launchpad.net/~launchpad-users
and it made my web browser lock up for several seconds while it processed the enormous number of little markers on the embedded Google map. The second time I did it I got a warning from my browser that a script was looping offering to terminate it.

If this map is retained on this page (which I think it should not - see my other report) then the number of markers shown should be strictly limited.

(Debian etch Iceweasel aka firefox on a 1.6GHz Pentium M)

Revision history for this message
Lauri Niskanen (ape3000) wrote :

The maps should be disabled by default, if there are over 500 members or so. This limit should be editable on personal settings. Then there would be a button that would warn about the heaviness, but allow seeing the map with all the members.

Changed in launchpad:
status: New → Confirmed
Revision history for this message
Diogo Matsubara (matsubara) wrote :

Curtis, any chance of having an option to disable maps for teams?

Changed in launchpad:
status: Confirmed → New
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I think for Launchpad to have a "Don't lock up my browser" setting would invite ridicule. Instead, I suggest either:
(1) pick a safe limit, and if the team has more than that number of members, choose a random sample of them to display each time the page is loaded;
(2) after the page has finished loading without any members shown on the map, add the members to the map in small batches at ~1-second intervals.

Revision history for this message
Curtis Hovey (sinzui) wrote :

I think Matthew's suggestion is a good approach. I don't think we need to load all the locations unless that user asks for it. Seeing all the locations of a team is an academic exercise; I do not think seeing this helps a user complete a task. Loading a safe sample of users is fine 99.99% of the time.

Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

I have a branch the allows users to disable the small maps on the user and team pages. This might help some users until this performance bug is really fixed

Revision history for this message
Curtis Hovey (sinzui) wrote :

Attached is an image that adds a checkbox, a link, and a message to team maps. Part of this suggestion would be more obvious if the team page was using the one-column layout that user profile pages have. If this page was using one-column design, we would move the action to show team map and timezones under the image.

I propose that the small map be limited to n member, 24 perhaps.
When the team contains more than n members, a parenthetical message follows the map and timezone link.

I don't think the small map is appropriate for show all members. This page is about the team in general, and ew have a page dedicated to the map. The large map is much better for seeing large teams. I don't think it is worth while to added delayed loading to this page. since it could take 20 minutes to load all the members of launchpad-users, and honestly, who is going to wait that long for a small map on page that is about summarising the team.

The checkbox is to address a group of related issues. I wrote code to hide the small maps (reinventing the portlet state code from LP 1.0 UI). After reviewing the many suggestions, I think may users distinguishing between their small map, other user's small maps, and team small maps. I can easily expand my work to offer separate states for user, other-user and team small maps.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: nobody → sinzui
importance: Low → High
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 2.2.3
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in launchpad/devel r7910.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix released in Launchpad 2.2.3.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.