Can't add auctions

On Fri, Jul 15, 2005 at 05:48:34PM -0400, Anthony DeRobertis wrote:
>
> Just tried to use bidwatcher again (haven't used it since April) and now
> it refuses to add ebay auctions. I tried both typing and copy/pasting
> the item number, but in both cases it says:
>
> [2005-07-15 17:41:47] Error: Invalid auction number. (5788323204)
>
> The item number is right, at least according to
> <http://cgi.ebay.com/Syntax-USB-400-802-11b-adapter-USB_W0QQitemZ5788323204QQcategoryZ45002QQssPageNameZWDVWQQrdZ1QQcmdZViewItem>
>
> It seems ebay changes have completely broken bidwatcher :-(

Yeah, I can confirm. I was on vacation last week and I'm just catching
up on e-mail now. I'll look at it.

-kpd

* Kevin Dwyer <email address hidden> [2005-07-23 09:51]:
> > It seems ebay changes have completely broken bidwatcher :-(
>
> Yeah, I can confirm. I was on vacation last week and I'm just catching
> up on e-mail now. I'll look at it.

Any update on this?
--
Martin Michlmayr
http://www.cyrius.com/

On Tue, Aug 09, 2005 at 04:41:37PM +0100, Martin Michlmayr wrote:
> * Kevin Dwyer <email address hidden> [2005-07-23 09:51]:
> > > It seems ebay changes have completely broken bidwatcher :-(
> >
> > Yeah, I can confirm. I was on vacation last week and I'm just catching
> > up on e-mail now. I'll look at it.
>
> Any update on this?

I've been too busy to look at this yet. Any help would be appreciated.

I'll see if I can solicit a patch from some of the other periodic
developers.

-kpd

Package: bidwatcher
Version: 1.3.17-1
Followup-For: Bug #318506

Hi,

this is a quick patch which temporarily fixes the issue. Most information seems
to be parsed as usual again (I guess -- since this is the first time I'm using
this program :)

I haven't done any testing of the bidding functionality, but I'm highly
suspicious that this would be broken as well. Also, shipping costs don't seem
to be retrieved, and I'm pretty sure that the cars/motors magic has been lost.

Note that this also addresses the Description[] buffer overflow from another
bug report.

best,
Antoine

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12.3
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages bidwatcher depends on:
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libcurl3 7.14.0-2 Multi-protocol file transfer libra
ii libgcc1 1:4.0.1-2 GCC support library
ii libglib1.2 1.2.10-10 The GLib library of C routines
ii libgtk1.2 1.2.10-17 The GIMP Toolkit set of widgets fo
ii libidn11 0.5.13-1.0 GNU libidn library, implementation
ii libssl0.9.7 0.9.7e-3 SSL shared libraries
ii libstdc++5 1:3.3.5-13 The GNU Standard C++ Library v3
ii libx11-6 4.3.0.dfsg.1-14 X Window System protocol client li
ii libxext6 4.3.0.dfsg.1-14 X Window System miscellaneous exte
ii libxi6 4.3.0.dfsg.1-14 X Window System Input extension li
ii xlibs 4.3.0.dfsg.1-14 X Keyboard Extension (XKB) configu
ii zlib1g 1:1.2.2-4 compression library - runtime

bidwatcher recommends no packages.

-- no debconf information

*** bidwatcher.patch
diff -uw bidwatcher-1.3.17/helpers.cpp bidwatcher-1.3.17-NEW/helpers.cpp
--- bidwatcher-1.3.17/helpers.cpp 2005-02-18 05:46:49.000000000 +0100
+++ bidwatcher-1.3.17-NEW/helpers.cpp 2005-08-09 23:48:30.000000000 +0200
@@ -1066,20 +1066,22 @@
     * but that's not what I'm going to do right now.
     * Thanks to Bob Beaty!
     */
- scratch = strstr(Buff, ") -");
+ // Update, August 2005: web page format seems to have changed, so we now
+ // parse the description from the page title, which is in the format
+ // "eBay: %DESCRIPTION% (item %n end time %t)" -AB
+ scratch = strstr(Buff, "eBay: ");
    if (scratch != NULL) {
- // move past the ") -"
- scratch += 3;
- // move past any whitespace
- while (isspace(*scratch)) scratch++;
- // copy over the description to a newline
+ // move past the prefix string
+ scratch += 6;
+ // copy over the description while buffer lasts (it's 129 bytes)
      idx = 0;
- while (*scratch != '\n') {
+ while (idx < 128 && strncmp(scratch, " (item ", 7)) {
        Description[idx++] = *scratch++;
      }
      // NULL terminate the description I just parsed off
      Description[idx] = '\0';
    } else {
+ ...

On Tue, Aug 09, 2005 at 01:19:04PM -0400, Kevin Dwyer wrote:
>
> I've been too busy to look at this yet. Any help would be appreciated.
>
> I'll see if I can solicit a patch from some of the other periodic
> developers.

There is now some working code in the sourceforge CVS. Please test if
you can. Feedback is welcome.

(I don't believe bidding works yet, but you can watch auctions.)

-kpd

Package: bidwatcher
Version: 1.3.17-1
Followup-For: Bug #318506

Adding a ney auction still results in error message.

| Error: Invalid auction number.

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.8-2-686
Locale: LANG=de_DE, LC_CTYPE=de_DE (charmap=ISO-8859-15)

Versions of packages bidwatcher depends on:
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libcurl3 7.13.2-2 Multi-protocol file transfer libra
ii libgcc1 1:3.4.3-13 GCC support library
ii libglib1.2 1.2.10-9 The GLib library of C routines
ii libgtk1.2 1.2.10-17 The GIMP Toolkit set of widgets fo
ii libidn11 0.5.13-1.0 GNU libidn library, implementation
ii libssl0.9.7 0.9.7e-3sarge1 SSL shared libraries
ii libstdc++5 1:3.3.5-13 The GNU Standard C++ Library v3
ii libx11-6 4.3.0.dfsg.1-14sarge1 X Window System protocol client li
ii libxext6 4.3.0.dfsg.1-14sarge1 X Window System miscellaneous exte
ii libxi6 4.3.0.dfsg.1-14sarge1 X Window System Input extension li
ii xlibs 4.3.0.dfsg.1-14sarge1 X Keyboard Extension (XKB) configu
ii zlib1g 1:1.2.2-4.sarge.2 compression library - runtime

-- no debconf information

bidwatcher was removed from Debian in October due to security
vulnerabilities and other breakage. For details, please see
<http://bugs.debian.org/331684>.