fluxbox cannot draw xfce4-terminal icon correctly on fluxbox toolbar

Bug #361389 reported by dsyates
2
Affects Status Importance Assigned to Milestone
fluxbox (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: fluxbox

Description: Ubuntu 9.04
Release: 9.04
fluxbox:
  Installed: 1.1.1-1
  Candidate: 1.1.1-1
  Version table:
 *** 1.1.1-1 0
        500 http://us.archive.ubuntu.com jaunty/universe Packages
        100 /var/lib/dpkg/status
Expected fluxbox to be able to draw icons propely/correctly on toolbar.
Imstead, with draw pictures on toolbar option enabled, fluxbox cannot properly draw xfce4-terminal icon on tooldbar.
Icon looks like it's made of snow or static. Most is not all other icons are properly drawn as pictures on toolbar.

Related branches

Revision history for this message
Paul Tagliamonte (paultag) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue that you reported is one that should be reproducible with the live environment of the Desktop CD of the development release - Maverick Meerkat. It would help us greatly if you could test with it so we can work on getting it fixed in the next release of Ubuntu. You can find out more about the development release at http://www.ubuntu.com/testing/ . Thanks again and we appreciate your help.

Changed in fluxbox (Ubuntu):
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for fluxbox (Ubuntu) because there has been no activity for 60 days.]

Changed in fluxbox (Ubuntu):
status: Incomplete → Expired
Revision history for this message
Paul Tagliamonte (paultag) wrote :

http://git.fluxbox.org/fluxbox.git/commit/?id=1da473bab9fa7b18ae925f8e084465c4c81bc3c9

Upstream found and fixed this issue.

Have a nice day :)

Use _NET_WM_ICON from 32bit apps (xfce4-terminal) correctly
The icons coming from _NET_WM_ICON are argb32. fluxbox uses such icons
in entities such as 'clientmenu', 'iconbar', 'titlebar'. These entities
are not related to the depth of the winclient but to fluxbox's default
depth. Using 'winclient.depth()' is a mistake, since fluxbox is unable
to copy pixmaps from 32bit to 24/16/15bit.

It is not necessary either, because fluxbox should extract the argb32 icon
data directly into the pixmap with the correct depth in the first place.

This fixes (reopened) bug #1852693.

Note: The whole icon code in fluxbox is quite messy, lots of copying and
scaling. It might be simpler and fater to just extract the icon when needed
, in just the size that is needed.

Changed in fluxbox (Ubuntu):
status: Expired → Fix Committed
Revision history for this message
Mathias Gumz (akira-9) wrote : Re: [Bug 361389] Re: fluxbox cannot draw xfce4-terminal icon correctly on fluxbox toolbar

> Note: The whole icon code in fluxbox is quite messy, lots of copying and
> scaling. It might be simpler and fater to just extract the icon when needed
> , in just the size that is needed.

i need a spellchecker in place! :) omfg. 'fater'

o/
--
  [uid] mathias gumz [mail] akira at fluxbox dot org [pgp] 1024D/F6F6B18C
  [www] http://www.darkshed.net/ [irc] ak|ra (#fluxbox at freenode.org)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fluxbox - 1.3.2-2

---------------
fluxbox (1.3.2-2) unstable; urgency=low

  * Fixing a minor headache with not shipping .png images, since most
    background setters can't set .svg. (Closes: #645120)
     - I've (as a result) been forced to add the .png files to the
       source/include-binaries file.

fluxbox (1.3.2-1) unstable; urgency=low

  * Patch by Harald Jenny to fix the debian-light theme. (Closes: #645057)
  * Changed the author header in the patches/ directory - malformed author
    value.
  * Upstream fix closed a bug back in 1.3.0 - we'll just close that out with the
    new release (Closes: #617638). Thanks, Frédéric and lmwangi!
  * Upstream signal handling is fixed up a great deal thanks to Pavelo
    - (Closes: #532094) - Thanks, Phil!
    - (Closes: #596029) - Thanks, James! (This one was particularly annoying)
  * Overhauled the copyright file - we're all set (Closes: #585180) - Thanks,
    Francesco!
    - While I was in there, migrated to the latest version of DEP5.
  * The icon handling has been fixed up (LP: #361389) - thanks dsyates!
  * Please note that this is no longer non-DFSG free upstream. This release
    no longer needs DFSG hacks.
     - Unmangled watch file.
 -- Ubuntu Archive Auto-Sync <email address hidden> Mon, 14 Nov 2011 10:35:35 +0000

Changed in fluxbox (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.