Odoo Server (MOVED TO GITHUB)

report engin regression: fields not displayed in some circumstances

Bug #385297 reported by Raphaël Valyi - http://www.akretion.com on 2009-06-09

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Server (MOVED TO GITHUB)	Fix Released	Undecided	Unassigned

Bug Description

Hi,

On branch 5-0
server rev #1789 (hey great commit)
addons rev #2343

When nested in particular ways, some python fields in the reports are no more displayed with the new report engine.
I don't know any example of such cases in the demo data, but here I provide attached a modified addons/sale/report/order.rml file that when put in place of the original addons report show the bug.

It looks like at least numeric fields such as integer and float can be subject to this bug.
Strangely, if you put such a [[ field_x ]] inside a [[ str(field_x) ]], or a [[ formatLang(field_x) ]] then it will be displayed, it's the case in my test case if you alter it that way.
To reproduce the bug you should test my order.rml report and you should look at the fields after "MAGIC ERROR", with no str() around they are missing, adding a str() around they will be shown.

This is an important bug, because some fields can be silently forgotten while they were showing using OpenERP 5.0.0.3.
Moreover, my customer bought a maintenance contract guarantying bugfix as we will emphasis also through the maintenance contract channel.

Moreover, there might be cases with non numeric types missing too such as explained in that forum post
http://openerp.com/forum/topic11538.html?sid=d9e38aaf4a8013f51b991be9792a3d18
But unfortunately I wasn't able to reproduce such a case. It might be less important too, numeric type are very important on the contrary because the bug occurs often with them.

Hope this helps,

Raphaël Valyi

Related branches

lp:openobject-server/5.0

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-06-09:

order.rml Edit (18.9 KiB, text/html)

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2009-06-09:

The attached .RML is not correct. Can you send another one ?

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-06-09:

order.rml.zip Edit (2.4 KiB, text/plain)

Hello Fabien, challenging me on late hacking?
Here it is, see attachment, as zip that time.

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2009-06-09:

fixed in branches/5.0

Changed in openobject-server:
status:	New → Fix Released

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2009-06-09:

r1784

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2009-06-10:

tested with your file and I confirm it's fixed.

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-06-12:

Hi,

It has been fixed indeed, but by rev #1782.1.2

BUT it has regressed again later between #1782.1.2 and rev #1789.

After phone call, Tiny is investigating that regression.

Revision history for this message

Christophe Simonis (OpenERP) (kangol) wrote on 2009-06-12:

To be exact, it has been fixed by http://bazaar.launchpad.net/~<email address hidden>#bin/report/report_sxw.py

But I didn't found any regression in the code...

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-06-12:

Sorry,

just as I said to you on the phone, IT'S BROKEN, not fixed...
Did you test? My test case simply fails again on head 5-0, simple enough to test.

I spent a few minutes bisecting the revisions to find out the regression, so far I can say that,
going forward with the time:

- <email address hidden> is OK indeed, first fix by Fabien
- <email address hidden> is still OK

- <email address hidden> is KO !!!!!!!!!!!!!
- <email address hidden> is OK !!!!!!!!!!
- <email address hidden> is KO again !!!!!
- hda@hda-20090610060138-rv3rnt6iyonmj1us is still KO!!

it seem that all later revision are broken then.

Thank you to investigate, as I said this is supposed to be covered by my customer maintenance contract (number 12) and it's just too sad fixing things and then breaking them.

Hope this helps.

Changed in openobject-server:
status:	Fix Released → Confirmed

Revision history for this message

Naresh(OpenERP) (nch-openerp) wrote on 2009-06-12:

#10

Hello Raphael Valyi,

The Commit <email address hidden> refers to Bug: https://bugs.launchpad.net/openobject-addons/+bug/385299 which was '&' character .

thanks,
nch

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2009-06-12: Re: [Bug 385297] Re: report engin regression: fields not displayed in some circumstances

#11

Hello Raphael,
Just a small mail to say I fix this in 5 minutes.
Sorry for the problems,

Raphaël Valyi - http://www.Smile.fr wrote:
> Sorry,
>
> just as I said to you on the phone, IT'S BROKEN, not fixed...
> Did you test? My test case simply fails again on head 5-0, simple enough to test.
>
> I spent a few minutes bisecting the revisions to find out the regression, so far I can say that,
> going forward with the time:
>
> - <email address hidden> is OK indeed, first fix by Fabien
> - <email address hidden> is still OK
>
> - <email address hidden> is KO !!!!!!!!!!!!!
> - <email address hidden> is OK !!!!!!!!!!
> - <email address hidden> is KO again !!!!!
> - hda@hda-20090610060138-rv3rnt6iyonmj1us is still KO!!
>
> it seem that all later revision are broken then.
>
> Thank you to investigate, as I said this is supposed to be covered by my
> customer maintenance contract (number 12) and it's just too sad fixing
> things and then breaking them.
>
> Hope this helps.
>
>
>
> ** Changed in: openobject-server
> Status: Fix Released => Confirmed
>

--
Fabien Pinckaers
CEO Tiny - OpenERP Editor
Chaussée de Namur 40
B-1367 Grand-Rosière
Belgium
Phone: +32.81.81.37.00
Fax: +32.81.73.35.01
Web: http://openerp.com

Great Achievements Start With Tiny Investments
-- Marty, 2005

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2009-06-12:

#12

Ok, i confirmed both bugs are fixed.
Seems we introduced a bug by fixing another one. Sorry for these problems.
Now, it's ok, tested on your document.

Changed in openobject-server:
status:	Confirmed → Fix Released

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-06-12:

#13

Hello Fabien,

thank you very much for your time Fabien. We will be able to migrate if that local regression is reverted indeed. It's just that at Smile we tend to share our time between a few customer offices, so when planning a migration we have to make sure we are indeed able to do it in the time frame we planned, that why we were a little pressing, else level 1 support would cost them too much if we need to come back over and over because of local regressions. But we are almost done now after that one last thing, no problem customer still happy.

@nch,

yes I know about the other the 2 other bugfixes you mentionned, I confirm those don't show up anymore indeed, so thank you to the team for those fixes.

Regards

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-06-12:

#14

Hi,

all right, I confirm this bug has been re-fixed, thank you guys!