please review and sponsor all-in-one-sidebar (updated)

could you please upload this new release to REVU for a review? let me know the url when done. Gonna take care of this update request. (don't subscribe u-u-s)

I tried to uploaded it to REVU a while ago as requested. I can't see that it has shown up. Please note that this is an updated version and not a new package. Does REVU block updates to packages already in Ubuntu? In that case I can upload it somewhere else.

By the way, am I correct to assume that you also will take care of merging ( https://code.launchpad.net/~kvilhaugsvik/firefox-extensions/all-in-one-sidebar.ubuntu/+merge/8652 ) the branch as well?

I know this is a new upstream release, that's why I asked you to put it on REVU for a better review. So please try again, maybe you didnt push it properly. Why do you want to merge it into ubuntu-dev? by doing it you won't be able to push stuff into that branch anymore. What do you think?

> I know this is a new upstream release, that's why I asked you to put it
> on REVU for a better review.
Good to know. I was confused after reading "If you packaged a new
upstream version (of a package that is already in the archives), and
you want to get it sponsored, do not use REVU to get it sponsored" in
the wiki when my upload didn't work.

> So please try again, maybe you didnt push
> it properly.
Seems like it was uploaded but not accepted. When I signed it again
using my old (expired) gpg-key instead of the new one (that I uploaded
to Launchpad today) it was accepted. It can now be found at
http://revu.ubuntuwire.com/p/all-in-one-sidebar

> Why do you want to merge it into ubuntu-dev? by doing it
> you won't be able to push stuff into that branch anymore. What do you
> think?
Sorry if I didn't express myself clear. I was wondering if you could
do the merge if/when you upload the package to the archive. (In case
you had access to the archive but not the branch) Based on your reply
I guess the answer is that you can.

Thank you for your patience!
Sveinung

Actually REVU should be used for NEW packages only but it's better for me to review it direcly using it.
Anyway I have access to the branch too and if you want I can manage to merge your branch into a brand new one into ubuntu-dev, we'll talk about it after package's upload anyway. Gonna process this tomorrow.

Package looks ok, install and builds fine plus it seems to work fine on Firefox. Just two minor things:
1) you forgot adding some changelog's entry
2) there are two minor lintian warnings

they are:

W: all-in-one-sidebar source: debhelper-but-no-misc-depends all-in-one-sidebar
W: all-in-one-sidebar source: out-of-date-standards-version 3.8.0 (current is 3.8.2)

Please fix the changelog problem and you want this two lintian warnings, if not just tell me to upload anyway.

> 1) you forgot adding some changelog's entry
Not sure if I understand what you meant here. Please explain. If you
mean from bazaar: I don't think "open tree for development" belong in
the debian changelog when it's closed again. (See
https://wiki.ubuntu.com/MozillaTeam/Extensions/Packaging where it
instructs me to remove it from the Debain changelog in the end) Or
should "new upstream release (LP: #398535)" be "RELEASE
all-in-one-sidebar v0.7.10 to ubuntu karmic (LP: #398535)"?

> 2) there are two minor lintian warnings
Fixed one. I don't have time right now to check it for Debian policy
3.8.2 right now so it would be nice if it could be uploaded anyway
like you offered.

Look here for the missing changelog entry: https://edge.launchpad.net/ubuntu/+source/all-in-one-sidebar
Anyway you should include every change that the package had before your new package, so you will have to add the missing changelog entry plus its changes.
For the other lintian warning, just go to debian/control and bump Standards-version to 3.8.2 and you're done. It will take like 1 minute.

you should also update maintainer field with this mail: Ubuntu Developers <email address hidden> not the old one as per https://wiki.ubuntu.com/DebianMaintainerField

> Look here for the missing changelog entry: https://edge.launchpad.net/ubuntu/+source/all-in-one-sidebar
Seems like 0.7.4-0ubuntu2 disappeared when 0.7.4-0ubuntu3 got uploaded
since it weren't pushed to the bazaar branch and 0.7.4-0ubuntu3 was
based on the version in the bazaar branch (0.7.4-0ubuntu1).

> Anyway you should include every change that the package had before your new package, so you will have to add the missing changelog entry plus its changes.
Sure. In order to preserve history I put 0.7.4-0ubuntu2 on top of
0.7.4-0ubuntu1 (in the branch) and merged it into the newest version.
That way the history will make sense for the changes from
0.7.4-0ubuntu2 that suddenly appears in the newer version. I kept the
change log entry and watch file from 0.7.4-0ubuntu2 since it was
better then the one currently in all-in-one-sidebar. The rest had
already been done.

> For the other lintian warning, just go to debian/control and bump Standards-version to 3.8.2 and you're done. It will take like 1 minute.
So the package follow policy? The CDBS magic takes care of it? Cool. Done.

Thank you very much for your help!
Sveinung

it looks like the watch file doesnt work. Can you please get back to use the upstream branch as before?

please fix the watch file, then the package is ready to be uploaded.

or if you want just remove it, I can grab orig by hand

nvm, the watch file works but when you run bzr bd it won't work. Don't have to change anything, gonna take your package from REVU and build it normally without bzr

Uploaded. Thanks for your work.

This bug was fixed in the package all-in-one-sidebar - 0.7.10-0ubuntu1

---------------
all-in-one-sidebar (0.7.10-0ubuntu1) karmic; urgency=low

  * new upstream release (LP: #398535)
  * list firefox-3.5 as alternate dependency
  * depend on ${misc:Depends} to fix lintian warning
  * changed maintainer field do to change in rules
  * merged all-in-one-sidebar 0.7.4-0ubuntu2
     + replace current watchfile with the one from it
     + add the change log entry from it
     + discard it's other changes
  * bump standards-version to 3.8.2

 -- Sveinung Kvilhaugsvik <email address hidden> Tue, 04 Aug 2009 19:25:10 +0200

Thank you very much for your help uploading and for your feedback.

no problem, for the merge thing Alexander gonna review it too, he was the original ubuntu-dev branch maintainer :)