Sunbird does not use highest resolution icon

This has already been taken care of just waiting for a push to Karmic. Please test the package in my PPA at:

https://launchpad.net/~gnomefreak/+archive/ppa

I have builds for jaunty intrepid nad hardy in PPA.
Change concerning icon is using the official branding (should take care of this bug as well.

The PPA builds do not have the added patches for arm arch FTBFS problems

I tried this package from your PPA: https://launchpad.net/~gnomefreak/+archive/ppa/+files/sunbird_0.9+nobinonly-0ubuntu3~jjv_amd64.deb. I don't think the bug is fixed, it still seems to be linking to mozicon50.png.

Ok i will look into this more.
Are you able to show me the difference that you are seeing between hte 50 and the 128. they both look fine here.
What graphics card drivers and screen res are you running?

I will make a few changes to .links and rules and post a test package on my PPA. I would still like the info i asked for above.
Can you tell me if firefox is show correctly?
What system are you using ubuntu 9.04?

This contains a bunch of fixes. I am uploading now to PPA and should be sometime today or tomorrow before its done building, depending on when the builder boxes become free.

I am using Ubuntu 9.04. I don't think it has anything to do with my graphics card. The icon just doesn't look right whenever something needs to display an icon for Sunbird larger than 50 pixels. Here are two screenshots. The top part shows what it looks like when I put Firefox and Sunbird on my desktop (my desktop icons size is set to 150%). The Firefox icon is the same size as my other icons but the Sunbird one is a lot smaller because it's using the smaller icon. The bottom part shows Firefox and Sunbird side by side in Gnome Do. The Sunbird icon looks blurry.

ok latest upload on my PPA are ready. I need to know if it is fixed for you so i can push it to my branch.

It's only sort of fixed. I tried this package from your PPA: https://launchpad.net/~gnomefreak/+archive/ppa/+files/sunbird_0.9+nobinonly-0ubuntu6~9.04~jjv1_amd64.deb. The link works, it points to mozicon128.png. But now mozicon128.png is not actually 128x128, it's been resized to 48x48. I was looking at the diff and it looks like the line that was using "convert -resize" to create mozicon50.png is now overwriting mozicon128.png.

On 07/16/2009 04:07 PM, mrboojive wrote:
> It's only sort of fixed. I tried this package from your PPA:
> https://launchpad.net/~gnomefreak/+archive/ppa/+files/sunbird_0.9
> +nobinonly-0ubuntu6~9.04~jjv1_amd64.deb. The link works, it points to
> mozicon128.png. But now mozicon128.png is not actually 128x128, it's
> been resized to 48x48. I was looking at the diff and it looks like the
> line that was using "convert -resize" to create mozicon50.png is now
> overwriting mozicon128.png.
>
Yeah i figured that was the issue just needed to make sure first. I am
having PC issues and i have work on my car to do. hopefully be done by
the end of month. about a week to get PC and car fixed and the 27th i
have eye surgery so i will be out ~1 week after surgery. If you can
provide me with a diff ill patch it and build it before monday/tuesday
if not i will get to it as soon as i can.

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

"How can i get lost, if i have no where to go"
    -- Metallica from Unforgiven III

ok this should do it for this bug. let me know version ending in ~jjv2 is the one that needs testing right now. than i will fix my branch so to update with official package you will need to remove mine and install without using PPA once it is pushed to archives. not sure if these fixes will be pushed to jaunty yet

ok scratch that it failed to build for some reason. i will look into it later this week its sunday and i shouldnt even be online

I tested the ~jjv2 Jaunty package and the icon is fixed in that one, even though the Karmic one is not building.

On 07/20/2009 05:40 PM, mrboojive wrote:
> I tested the ~jjv2 Jaunty package and the icon is fixed in that one,
> even though the Karmic one is not building.
>
I think the failure is due to LP not me but i will re-run the build
sometime today locally to make sure. Thanks for testing

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

"How can i get lost, if i have no where to go"
    -- Metallica from Unforgiven III

ok i know the failure to build i think (jaunty built fine, its karmic that i have to change GCC depends versions.

Fixed in bzr branch. will ask for sponsorship in a bit and see what happens.
If you are using my PPA version please downgrade when it is released to universe

This bug was fixed in the package lightning-sunbird - 0.9+nobinonly-0ubuntu3

---------------
lightning-sunbird (0.9+nobinonly-0ubuntu3) karmic; urgency=low

  [ John Vivirito ]
  * Fixes (LP: #178785)
    - debian/rules: Added build option --enable-official-branding to build with official branding
    - debian/patches: Removed deb299697-lp42559-use-FC_ANY_METRICS.patch to fix build errors
    - debian/patches: Updated series
  * Fixes (LP: #399400)
    - debian/rules: Removed the convert icon section
    - debian/sunbird.links: Adjusted link to use the 128 icon
  * Fixes (LP: #401165)
    - debian/control: Removed GCC and GCC++ from build-deps
    - debian/rules: Commented out GCC and GCC++ lines to build using default
    - debian/patches: Added ftbfs_gcc44_elif.patch to fix FTBFS
    - debian/patches/series: Updated
  * Fixes (LP: #385325) crash in JS due to usage of wrong floating point number$
    - debian/patches: Added bz322806_arm-vfp-2538:3f78d5e894bc
    - debian/patches/series: Updated
  * Fixes (LP: #378754)
    - debian/control: Fixed typo in calendar-google-provider description.
  * Fixes (LP: #358084): add arm(el) xpcom patches from thunderbird package
    - add debian/patches/18_arm_xpcom_unused_attribute.dpatch
    - add debian/patches/38_arm_xpcom_optim.dpatch
    - add debian/patches/bz339782_cvs_xptcinvoke_arm_backport_1.13.patch
    - update debian/patches/series
  * debian/patches:
    - Add debian/patches/412610_attachment_309958.patch: to prevent crash on MAX_PATH
    - update debian/patches/series

 -- John Vivirito <email address hidden> Fri, 21 Aug 2009 10:57:02 -0400