Ubuntu
goffice package

Patch: build 2 libgoffice variants (gnome and gtk)

Bug #40122 reported by Gauvain Pocentek
8
Affects Status Importance Assigned to Milestone
goffice (Ubuntu)
Fix Released
Medium
Daniel Holbach

Bug Description

Here is a proposed patch to build gnome and gtk variants from the same source package. Comments appreciated :)

Revision history for this message
Gauvain Pocentek (gpocentek) wrote : Debdiff

here it is.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Hey Gauvain, nice work on the patch. It generally looks ok to me, but could you please update it to the current version and pay attention to not drop stuff by accident? For example this piece of debian/rules hackery
    -find -type f -name 'Makefile.am' | sed -e 's/\.am$$//' | xargs rm -f

was simply dropped. Let's try to keep the diff as small as possible. If there are other improvements to make, let's not do them now.

Revision history for this message
Gauvain Pocentek (gpocentek) wrote : Debdiff against current package

The removed lines was an accident, and it shouldn't have happened!
Anyway, this debdiff doesn't remove lines.

Revision history for this message
Gauvain Pocentek (gpocentek) wrote : Real new patch

Sorry, I uploaded the wrong debdiff...

Revision history for this message
Daniel Holbach (dholbach) wrote :

 goffice (0.2.1-3ubuntu3) dapper; urgency=low
 .
   * Build both gnome dependent and independent packages.
   * New created binary packages:
     - libgoffice-gtk-1-2
     - libgoffice-gtk-1-2-dbg

Changed in goffice:
status: Unconfirmed → Fix Released
Revision history for this message
Gauvain Pocentek (gpocentek) wrote :

Reopening this bug, a new patch is coming.

Changed in goffice:
status: Fix Released → In Progress
Revision history for this message
Gauvain Pocentek (gpocentek) wrote : New patch

Please have a look at the gnumeric patch (Bug #42610) before applying this one. It may need to be changed if the gnumeric patch is not good enough.
Thanks.

Revision history for this message
Gauvain Pocentek (gpocentek) wrote : Updated debdiff

goffice has been updated today, the patch too

Revision history for this message
Daniel Holbach (dholbach) wrote :

Looks good, ready to upload.

Changed in goffice:
assignee: nobody → dholbach
status: In Progress → Fix Committed
Jani Monoses (jani)
Changed in goffice:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.