Patch: gnome/gtk build

Bug #42610 reported by Gauvain Pocentek
8
Affects Status Importance Assigned to Milestone
gnumeric (Ubuntu)
Fix Released
Medium
Daniel Holbach

Bug Description

Attaching a patch.
It allows to build both gnome and gtk variants from the same source package.
It needs goffice to be patched first (Bug #40122).

Revision history for this message
Gauvain Pocentek (gpocentek) wrote : Gnumeric debdiff

here is the patch :)

Changed in gnumeric:
assignee: nobody → dholbach
Revision history for this message
Gauvain Pocentek (gpocentek) wrote : New debdiff

Adapted to the last uploaded package.

Revision history for this message
Jani Monoses (jani) wrote :

I am trying it out and making some modifications to it now.

Revision history for this message
Jani Monoses (jani) wrote :

a smaller one with the following differences compared to the previous debdiff

- don't make a new -gtk package for the plugins too since those are gnome independent already.
- do not move some files to gnumeric-common even if it makes sense, to make sure the debs install the same files as before. This can be cleaned up
later but is not needed for the gtk separation
- do not make gnumeric and gnumeric-gtk explicitely depend on the respective libgoffice, as they can work with either goffice variant. Let this
explicit dependency be stated separately if needed (in the desktop seed for example in xubuntu)
- suggest gnumeric | gnumeric-gtk for the common and the doc packages
- remove some diff hunks which only added a newline

I tested this and the resulting debs work fine with the new goffice, and the original packages install the same list of files as before this patch.

Daniel, Gauvain, unless you have further comments I'd like to commit this
by the weekend.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Upload it - it looks good to me.

Changed in gnumeric:
status: Unconfirmed → Confirmed
Revision history for this message
Jani Monoses (jani) wrote :

thanks for the review, uploaded

Changed in gnumeric:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.