main inclusion report plasma-widget-indicatordisplay
Bug #410228 reported by
Jonathan Riddell
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
plasma-widget-indicatordisplay (Ubuntu) |
Fix Released
|
Undecided
|
Loïc Minier |
Bug Description
Binary package hint: plasma-
https:/
To post a comment you must log in.
Packaging looks good, minor points:
- Priority should be optional.
- You might want to add a watch file.
- I see CMakeLists.txt uses pkg-config checks but there's no cmake or kde package deping on it, so I don't know where the pkg-config functions come from but you might have to explicitly build-depend on pkg-config
There's an issue with licensing:
- upstream files lack the full license grant (the blob saying this file is under GPL and you should have received it etc.), they only have "License: GPL v3"
- plenty of files are actually LGPL; this is worth representing in the debian/copyright file at least, or fixing upstream; please ship a copy of the COPYING.LGPL file if you ship files under the LGPL
Upstream code: looks good.
What's the issue with running the testsuite in dbus-launch?
Please subscribe to the bug mail for this package or subscribe the responsible team.