main inclusion report plasma-widget-indicatordisplay

Bug #410228 reported by Jonathan Riddell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
plasma-widget-indicatordisplay (Ubuntu)
Fix Released
Undecided
Loïc Minier

Bug Description

Binary package hint: plasma-widget-indicatordisplay

https://wiki.kubuntu.org/MainInclusionReportPlasmaWidgetIndicatordisplay

Revision history for this message
Loïc Minier (lool) wrote :

Packaging looks good, minor points:
- Priority should be optional.
- You might want to add a watch file.
- I see CMakeLists.txt uses pkg-config checks but there's no cmake or kde package deping on it, so I don't know where the pkg-config functions come from but you might have to explicitly build-depend on pkg-config

There's an issue with licensing:
- upstream files lack the full license grant (the blob saying this file is under GPL and you should have received it etc.), they only have "License: GPL v3"
- plenty of files are actually LGPL; this is worth representing in the debian/copyright file at least, or fixing upstream; please ship a copy of the COPYING.LGPL file if you ship files under the LGPL

Upstream code: looks good.

What's the issue with running the testsuite in dbus-launch?

Please subscribe to the bug mail for this package or subscribe the responsible team.

Changed in plasma-widget-indicatordisplay (Ubuntu):
assignee: nobody → Loïc Minier (lool)
status: New → Incomplete
Revision history for this message
Jonathan Riddell (jr) wrote :

I've set the priority to optional
There's no formal upstream releases currently so can't set a watch file
I've added pkg-config to libqt4-dev since lots of Qt and KDE apps need it (previously it was pulled in by one of the -dev packages it depends upon)
Version 0.2.2 fixes the licencing, now uniformly GPL 3
Still talking with agateau to get the test suite working in a build environment

I've moved this to main for now as I'm keen to get it into the next alpha, but I'll keep working on getting the test suite running during build to ensure this MIR is followed through properly.

Revision history for this message
Loïc Minier (lool) wrote :

Ok fix releasing since the licensing is fixed

Changed in plasma-widget-indicatordisplay (Ubuntu):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.