[PATCH] wrong parameter quoting in diversion of start-stop-daemon
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ltsp (Ubuntu) |
Fix Released
|
Low
|
Scott Balneaves |
Bug Description
The ltsp-server package diverts (in the client chroot) /sbin/start-
/sbin/start-
calls start-stop-
the wrapper passes on the parameters using $*, which doesn't handle quoted parameters
correctly. I noticed this because /etc/cron.
start-stop-daemon --start --pidfile /dev/null --startas /bin/sh \
--oknodo --chuid man -- -c \
"find /var/cache/man -type f -name '*.gz' -atime +6 -print0 | \
xargs -r0 rm -f"
and the find-piped-to-xargs part gets expanded to the wrong thing by the start-stop-daemon
wrapper, causing the contents of the entire root filesystem to be dumped to the output.
This can be easily fixed as follows:
--- /usr/share/
+++ /usr/share/
@@ -4,5 +4,5 @@
#
if [ "$LTSP_
- /sbin/start-
+ /sbin/start-
fi
Thanks, I've patched the upstream source.