cone FTBFS in karmic

Bug #420303 reported by Bhavani Shankar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cone (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Related branches

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Seems like a missing build dep on libtool

assigning to myself

Regards

Changed in cone (Ubuntu):
status: New → In Progress
assignee: nobody → Bhavani Shankar (bhavi)
Revision history for this message
Bhavani Shankar (bhavi) wrote :

Its still FTBFS

http://launchpadlibrarian.net/30931963/buildlog_ubuntu-karmic-i386.cone_0.77-2ubuntu1_FAILEDTOBUILD.txt.gz

The macros seem to rely on implicit conversion from void * to char * which is permitted in C but not CPP.

Unassigning

Regards

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Sorry its const void and essentially a gcc problem i think...

Revision history for this message
Michael Bienia (geser) wrote :

It's not a gcc problem, but a bug in the code:

libmaildir/maildiradd.C:168
    memcpy(strrchr(newname.c_str(), '/')-3, "cur", 3);

c_str() returns a const char* (i.e. read-only), strrchr() on a const char* returns also a const char*
but memcpy expects to get there a pointer to a read-write location

That's the problem gcc complains about. From a look at the code, this code needs to be changed to do the modification on newname (C++ string) directly and not on its C representation.

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Okay michael

Reporting to debian

and unassigning

Regards

Changed in cone (Ubuntu):
status: In Progress → Confirmed
assignee: Bhavani Shankar (bhavi) → nobody
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Here is the corresponding debdiff. This compilation error has been solved in latest cone version. I've opened a bug report in Debian requesting the upgrade of cone, so that we can sync cone in the next development cycle.

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Thanks fabrice...

Revision history for this message
StefanPotyra (sistpoty) wrote :

hm... the const_cast seems pretty ugly at this place (why not just modify the std::string using std::string methods?), however as this fix is in 0.79, I'm ok with it, test-buliding.

StefanPotyra (sistpoty)
Changed in cone (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cone - 0.77-2ubuntu1

---------------
cone (0.77-2ubuntu1) karmic; urgency=low

  * debian/control: added build dependency on libtool (thanks Bhavani Shankar)
    (LP: #420303)
  * debian/patches/gcc_4.4.diff: fix compilation errors with gcc 4.4
    (retrofitted from version 0.79)

 -- Fabrice Coutadeur <email address hidden> Tue, 15 Sep 2009 04:34:52 +0000

Changed in cone (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
StefanPotyra (sistpoty) wrote :

uploaded, thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.