Ubuntu
freetalk package

freetalk FTBFS

Bug #443241 reported by Jon Bernard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
freetalk (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: freetalk

freetalk is failing to build from source:

callbacks.cc: In function 'LmHandlerResult ft_msg_msg_handler(LmMessageHandler*, LmConnection*, LmMessage*, void*)':
callbacks.cc:156: error: assignment of read-only location '* strchr(from, 47)'

Full build log is here: https://launchpad.net/ubuntu/+archive/test-rebuild-20090909/+build/1214792

Related branches

lp:ubuntu/karmic/freetalk
Revision history for this message
Jon Bernard (jbernard) wrote :

Attached is a patch that fixes this, seems to work for me but please test and verify

Revision history for this message
Jon Bernard (jbernard) wrote :

Here's a much better version of the above patch

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Please do not add a patch system to a package that comes from Debian: this makes the debdiff bigger, and increase the difference between Debian and Ubuntu.

Another approach to fix this compilation error would be to copy the 'from' variable to another one in line 153 to a char *, use it and free it before leaving the function.

When you have the new debdiff, please put your bug report back to complete.

Thanks for your work!

Fabrice

Changed in freetalk (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Jon Bernard (jbernard) wrote :

New diff attached.

Changed in freetalk (Ubuntu):
status: Incomplete → New
Fabrice Coutadeur (fabricesp)
Changed in freetalk (Ubuntu):
assignee: nobody → fabrice_sp (fabricesp)
status: New → In Progress
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Uploaded.
Thanks for your contribution :-)

Fabrice

Changed in freetalk (Ubuntu):
assignee: fabrice_sp (fabricesp) → nobody
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package freetalk - 3.2-1ubuntu1

---------------
freetalk (3.2-1ubuntu1) karmic; urgency=low

  * Fix FTBFS due to a modified const in src/callbacks.cc (LP: #443241)

 -- Jon Bernard <email address hidden> Mon, 05 Oct 2009 12:17:44 -0400

Changed in freetalk (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.