FTBFS? (Perhaps upgrade to gEDA 1.6.0)

Bug #444527 reported by Peter Clifton
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
geda-gattrib (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: geda-gattrib

During development of gEDA 1.6.0, we became aware that with GTK versions greater than 2.17.x, geda-gattrib will not build due to changes in GTK API. (Renaming of some private members which the gtk-extra derived code in gattrib (ab)used).

I presume that this will be discovered during the final rebuilds of Karmic.

This issue was resolved during gEDA 1.6.0 development, and although I know karmic is in freeze at the moment - uploading 1.6.0 would be a neat way to get around this problem.

If uploading 1.6.0 is not possible, it might be possible to patch the build for geda-gattrib with a similar fix to that we applied for 1.6.0. This removed the bit-rotten GtkItemEntry code in favour of using a plain GtkEntry.

For those who use gEDA, gEDA 1.6.0 will be a marked improvement upon gEDA 1.4.x. Our user base is not that large though.. so potential impact to the wider Ubuntu user-base (should there be any issues with gEDA 1.6.0) is very small.

Related branches

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Hi peter

Which is the offending file?

Regards

Revision history for this message
Bhavani Shankar (bhavi) wrote :

I ve just prepared a PPA package

Test building

Regards

Changed in geda-gattrib (Ubuntu):
status: New → Confirmed
Revision history for this message
Peter Clifton (pcjc2) wrote :

gattrib/src/gtkitementry.c is the offending file.

This is the fix applied to gEDA 1.6.0 (remove the offending file and use a different widget):
http://git.gpleda.org/?p=gaf.git;a=commitdiff;h=78da20ca286eb2f6e518c64dca94b888fc8c19af

The diff won't apply directly, but it should only be build system changes which don't apply. They won't be needed for the 1.4.x series.

My preferred fix would be to see if we can sneak a 1.6.0 package into Karmic ;)

(That way we're all running the same tested code, not applying huge patches to unmaintained upstream versions).

Revision history for this message
Peter Clifton (pcjc2) wrote :

Sorry.. gattrib/src/gtkitementry_2_2.c

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Okay ll look at it

Assigning

Changed in geda-gattrib (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Bhavani Shankar (bhavi)
Revision history for this message
Bhavani Shankar (bhavi) wrote :
Revision history for this message
Bhavani Shankar (bhavi) wrote :
Revision history for this message
Bhavani Shankar (bhavi) wrote :
Revision history for this message
Bhavani Shankar (bhavi) wrote :

Done peter

Calling in sponsors

Regards

Changed in geda-gattrib (Ubuntu):
status: In Progress → Confirmed
assignee: Bhavani Shankar (bhavi) → nobody
Revision history for this message
Peter Clifton (pcjc2) wrote :

I'm a little lost as to what the deb-diff was for. The control file implies that it is a geda-gattrib 1.6.0 release, but I don't think this would not be possible without updating the rest of the geda-* packages.

gEDA (gschem and gattrib) install their own .desktop files, but I see the debdiff appears to add an extra one for gattrib.

I've got some first-cut debian packaging for the whole of gEDA 1.6.0 (which is now shipped as one unified source tarball), if you are interested.

Revision history for this message
Peter Clifton (pcjc2) wrote :

I'm just waiting to see that these build on the ppa builder:

https://launchpad.net/~pcjc2/+archive/

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Instead of having a brand new set of packages ,wouldn't it be possible to apply the same fix you mention to actual version in Karmic?
Otherwise, you would need a FFe to allow this package to make their path into Karmic.
Unsubscribing u-u-s for the moment. Please subscribe again when either FFe has been approved, or you ahve a debdiff for existing version.

Thanks for your work,
Fabrice

Changed in geda-gattrib (Ubuntu):
importance: Undecided → Wishlist
status: Confirmed → Incomplete
Revision history for this message
Peter Clifton (pcjc2) wrote :

Either solution is possible - I was just thinking that 1.6.0 packages would have been better tested than applying a big patch to 1.4.x.

Revision history for this message
Peter Clifton (pcjc2) wrote :

What a PAIN in the backside!

My 1.6.0 patch didn't apply cleanly, so I back-ported to 1.4.3. Then had to add patch infrastructure to the geda-gattrib package...

Then couldn't make it work properly (the pacakage needed the equivalent of an autoreconf - and I'm not sure how to do that and still keep a sensibly small diff. (My karmic box has different versions of various software than what was used to produce the original gEDA dist tarball).

Anyway.. back to the drawing board, and rather than removing the offending files (and headers), changing Makefiles etc.., I've just removed the _content_ of the bit-rotten .c and .h files, leaving the compiler to build and link them anyway.

I'll attach the debdiff now...

Revision history for this message
Peter Clifton (pcjc2) wrote :
Revision history for this message
Peter Clifton (pcjc2) wrote :
Revision history for this message
Peter Clifton (pcjc2) wrote :
Revision history for this message
Peter Clifton (pcjc2) wrote :
Revision history for this message
Peter Clifton (pcjc2) wrote :
Revision history for this message
Peter Clifton (pcjc2) wrote :

Perhaps it is time to call in the sponsors again?

As a gEDA developer I'm biased, but I still think seeking a FFe for the entire of gEDA 1.6.0 would be a more supportable way to go, since the gEDA developers actually support the 1.6.x series.

But of course.. I'm not impartial.
I've provided code for both options - someone decide ;)

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

subscribing motu-release for advice :-)

Changed in geda-gattrib (Ubuntu):
status: Incomplete → New
Revision history for this message
StefanPotyra (sistpoty) wrote :

Hi Peter,

first off, geda is so cool! I'm using it in the faumachine project in order to have a graphical circuit layout for a (then simulated) mainboard, which gets converted to c-code (by a slightly modified tragesym). Thanks a lot for geda!

Now the geda project is spread among a number of source packages. Is the geda-gattrib (1.6) compatible with the older versions of the other source packages (geda, geda-gnetlist, ...), or would we need to update these as well?

Cheers,
    Stefan.

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Yeah peter,

I was also taking a look at the unified tarball and I installed it .. (As EE student m using it from past 4 years and thanks to the whole geda team... You guys rock!) but here the package is split into different components... if you say its worthwhile updating whole geda stack then I can help out(as I did in jaunty cycle)

Thanks

Revision history for this message
Peter Clifton (pcjc2) wrote :

Hi guys, I'm sure the rest of the gEDA team would appreciate hearing those comments (geda-user list?).

W.r.t new geda-gattrib, older *geda-*, I'm pretty sure that gattrib 1.6.0 could not be built against libgeda 1.4.2.

Revision history for this message
Scott Kitterman (kitterman) wrote :

How many packages are we talking about and have they all been tested/have working packages?

Revision history for this message
StefanPotyra (sistpoty) wrote :

hm, since we're a few hours before FinalFreeze, and can't sync 1.6 from unstable, I doubt we'll manage to package up all of the new versions of the geda stack in time, leaving us only with patching 1.4 :/

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package geda-gattrib - 1:1.4.3-2ubuntu1

---------------
geda-gattrib (1:1.4.3-2ubuntu1) karmic; urgency=low

  [ Peter Clifton ]
  * Fix FTBFS by removing GtkItemEntry code. Use plain GtkEntry instead.

  [ Stefan Potyra ]
  * Add dpatch to build-depends in debian/control.
  * LP: #444527

 -- Stefan Potyra <email address hidden> Sun, 25 Oct 2009 03:04:31 +0100

Changed in geda-gattrib (Ubuntu):
status: New → Fix Released
Revision history for this message
Peter Clifton (pcjc2) wrote :

Thanks Stefan,

Your help ingetting this fixed is much appreciated.

Best wishes,

Peter Clifton

Revision history for this message
StefanPotyra (sistpoty) wrote : Re: [Bug 444527] Re: FTBFS? (Perhaps upgrade to gEDA 1.6.0)

Hi Peter,

Am Sunday 25 October 2009 05:28:29 schrieb Peter Clifton:
> Thanks Stefan,
>
> Your help ingetting this fixed is much appreciated.

well, uploading it was trivial! Thanks to you for providing the fix and even
more for your work on geda in the first place!

Cheers,
   Stefan.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.