Bazaar

branch-history fails on tailored repository

Bug #44842 reported by Colin Watson
6
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Olaf Conradi

Bug Description

I originally created this branch by using tailor to convert it from an svn repository. As a result, many of the older committer IDs don't match bzr's idea of what a committer ID should look like, and 'branch-history' refuses to get out of bed:

  <cjwatson@cairhien ~/src/ubuntu/ubiquity/ubiquity>$ bzr branch-history
  bzr: ERROR: 'juanje' doesn't seem to contain a reasonable email address

I think this is a good case for a warning at most; after all, all branch-history really needs is to ensure uniqueness, and it shouldn't matter that the committer IDs are malformed.

A copy of the repository used here is available at <http://people.ubuntu.com/~cjwatson/bzr/ubiquity/ubuntu/>.

Revision history for this message
Olaf Conradi (olaf-conradi) wrote : Add exception handling to extarct email

Hi Colin,

This isn't a bug in bzr, but in bzrtools as branch-history is a plugin.

Can you try the attached patch. I'll send it to Aaron if it works for you.

Cheers
 -Olaf

Revision history for this message
David Allouche (ddaa) wrote :

Duh!

The launchpad import system also produces commits where the comitter id is not an email address.

bzr should really not fail to read data when the comitter is malformed. It _may_ have guards against comitting with a malformed user name in the UI, but that's another story.

Revision history for this message
Colin Watson (cjwatson) wrote :

Olaf: yes, your patch (a) makes branch-history succeed and (b) appears to produce a reasonable-looking summary of the branch history. Thanks!

Revision history for this message
Olaf Conradi (olaf-conradi) wrote :

Colin: ok, thanks. I already went ahead and submitted it to Aaron. So it will probably show up some time in bzrtools.

David: I don't think there is any code left in bzr which depends on the rev_id format being email-date-bits.

Changed in bzr:
assignee: nobody → olaf-conradi
status: Unconfirmed → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 44842] Re: branch-history fails on tailored repository

> David: I don't think there is any code left in bzr which depends on the
> rev_id format being email-date-bits.

If there is any, please file bzr bugs for it.

Revision history for this message
John A Meinel (jameinel) wrote :

this is a bzrtools bug, so should be over there, but it is fixed anyway, so closing rather than rejecting.

Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.