eject button not working for non-data CDs

Thanks for your report. Please open a Terminal, and do

  sudo /usr/lib/devicekit-disks/devkit-disks-daemon --replace > /tmp/debug.txt 2>&1

Then insert a DVD, press eject button, wait a couple of seconds. Then press Control-C to cancel the debugging process, and attach /tmp/debug.txt here.

Afterwards, do

  devkit-disks --dump > /tmp/dk-dump.txt

and attach /tmp/dk-dump.txt here.

Thank you!

i have done the above and attached the files required.

Confirming the issue there, after playing a DVD in totem the button doesn't work, do you need any extra details?

Can you confirm that if you insert a video DVD and didn't start the video player (totem) yet, you can still eject it using the button? And as soon as totem starts, it doesn't work any more? That's the behaviour I get now.

martin

i can confirm that if you mount the dvd video without playing it. the eject button on the drive works but it leaves it mounted so when you insert another disk it doesn't work until you have unmounted the first disk.

when you press the eject button on the drive it should do both unmount and eject the disc.

also when you start and play the dvd video with either totem or vlc the eject button on the drive stops working.

I'm having the same problem with DVD's and CD's don't work at all.

I did some investigations for this. It's not intrinsically specific to DVDs, it happens as soon as a program open()s the raw device without O_NONBLK:

 * insert CD or DVD, don't open in video player

 * $ python
   >>> f = open('/dev/sr0')
   >>> f.close()

  -> drive gets locked

 * eject, insert again

 * Python 2.6.4 (r264:75706, Nov 2 2009, 14:44:17)
   >>> import os
   >>> f = os.open('/dev/sr0', os.O_RDONLY | os.O_NONBLOCK)

  -> drive does not get locked

However, O_NONBLOCK has a much larger impact than just avoiding drive door lock, it changes the behaviour of open() itself when the device is not fully ready yet, as well as the default behaviour of all subsequent write() or read(). So doing this change in our video players would require larger code changes.

This is just mainly seen with DVDs because for data CDs/DVDs the raw device does not get open()ed, but just gets mounted. Only audio/video players, CD rippers/burners, etc. open the raw device.

This is way outside the range of what dk-d can control. We either need to fix it in all video players or change the tray locking behaviour in the kernel itself.

Confirming that open() doesn't lock the CD-ROM door after

  # echo 0 > /proc/sys/dev/cdrom/lock

I'll mark that as a dupe of bug 397734 now and reopen the kernel task.