FTBFS: Sync givaro 3.2.13-1 (universe) from Debian unstable (main)

Currently givaro FTBFS:
http://launchpadlibrarian.net/31810058/buildlog_ubuntu-karmic-i386.givaro_3.2.10-1_FAILEDTOBUILD.txt.gz
The new upstream version fixes this.

~kitterman suggested the sync on IRC:
simon-o Hi, I'm looking at a package which FTBFS. There is a new upstream version with a "rewritten" build system. Imho it would be the easiest to sync the package from Debian, but I don't know if this is ok, this late in the cycle... 11:30
simon-o http://launchpadlibrarian.net/31810058/buildlog_ubuntu-karmic-i386.givaro_3.2.10-1_FAILEDTOBUILD.txt.gz 11:30
ScottK simon-o: If the current package FTBFS, then we should consider it. 11:31

Hi,

Is there any changelog from Upstream? I've not been able to find any, and there are rdepends, we need to check it twice.

If there isn't any changelog, you should subscribe motu-release to request officially 2 acks.

Thanks,
Fabrice

Fabrice, here is a diff of the interesting upstream changes, generated with:
  debdiff givaro_3.2.10-1.dsc givaro_3.2.13-1.dsc | filterdiff -i '*.C' -i '*.h' -i '*.inl' > givaro-upstream.diff
I didn't find an upstream changelog either, but most changes seem to be related to the build system.

I subscribed motu-release so that they can check this too. For me it looks ok.

hm, the change in givaro-config.h are slightly worrying (unless givaro-config.h is autogenerated during build time.. I'l check that this evening, am at work atm, and can't give a too deep look).
Can you attach a diff of symbols between the current version and the new one?

uh oh, there are removed symbols in libgivaro0. After a quick check, at least _ZN6Degree8deginftyE (Degree::deginfty) is used from liblinbox0 :(.

So the SONAME should have been bumped in between, but wasn't. I'd suggest passing -V to dh_makeshlibs (that should be
DEB_DH_MAKESHLIBS_ARGS_ALL=-V, not verified though) so that rdepends will obtain a versioned dependency on the newer libgivaro0 library once these have been rebuilt, *and* to rebuild the two rdepends. (Another solution would be to rename libgavaro0 and add conflicts/replaces against it).

Can you check if linbox and sagemath still build with the new givaro?

If it's only about fixing FTBFS (and no interest in newer upstream version), then you could use this patch. Solution borrowed from debbugs 527503.

Ilya, yes this is only about fixing the FTBFS. Thanks a lot for the patch.
givaro build fine with in my own pbuilder environment and in my ppa:
https://edge.launchpad.net/~simono/+archive/ppa/+build/1306453
What do the others think about the patch?

Looking at the FTBFS fix for sponsorship.

This bug was fixed in the package givaro - 3.2.10-1ubuntu1

---------------
givaro (3.2.10-1ubuntu1) karmic; urgency=low

  * Add relibtoolize.patch to fix FTBFS (LP: #456231).

 -- Ilya Barygin <email address hidden> Sat, 24 Oct 2009 00:28:06 +0400