ubuntu-project: edit ignores sensible-editor if EDITOR and SELECTED_EDITOR are not set

Bug #484730 reported by Hai-Lam Bui
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Quickly
Fix Released
Undecided
Unassigned

Bug Description

No matter which editor the user chooses with select-editor, if EDITOR and SELECTED_EDITOR are not set, quickly edit starts gedit if using the ubuntu-project template, instead of sensible-editor.

Steps to reproduce:
1. Open a terminal and go to a quickly project that uses the ubuntu-project template.
2. Run select-editor and choose anything other than gedit.
3. Run env -u EDITOR -u SELECTED_EDITOR quickly edit.

Cause:
The bug is found in edit.py:

if not default_editor and os.path.exists('~/.selected_editor'):
    editor = 'sensible-editor'

os.path.exists() does not expand '~' by itself; processing the path with os.path.expanduser() first works.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thank you for your interest in Quickly.

yep, .selected_editor is not taken into account in your version, and that's a bug. Only EDITOR and SELECTED-EDITOR are.
I'll fix it soon in trunk.

Changed in quickly:
status: New → Triaged
status: Triaged → Fix Committed
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Fixed in trunk, thanks.

Changed in quickly:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.