MIR for pastedeploy

Bug #493594 reported by Chuck Short
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pastedeploy (Ubuntu)
Fix Released
Wishlist
Martin Pitt
Lucid
Fix Released
Wishlist
Martin Pitt

Bug Description

Hi,

I would like to include python-pastedeploy into main as part of the canonical-applicaiton-support. The MIR can be found at:

https://wiki.ubuntu.com/MIRPythonPasteDeploy

Regards
chuck

Chuck Short (zulcss)
Changed in pastedeploy (Ubuntu Lucid):
milestone: none → lucid-alpha-2
Chuck Short (zulcss)
Changed in pastedeploy (Ubuntu Lucid):
milestone: lucid-alpha-2 → lucid-alpha-3
Martin Pitt (pitti)
Changed in pastedeploy (Ubuntu Lucid):
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :

This looks fine to me. It would be great if we could make the test suite work, since that seems to be non-trivial. There is no "main" code, so I suppose this needs some particular way of invoking the tests. Could this be integrated into the build process, please?

Changed in pastedeploy (Ubuntu Lucid):
status: New → Incomplete
Revision history for this message
Chuck Short (zulcss) wrote :

Done I have integrated the testsuite in the build process, upstream had fixed their tests which were previously broken. I had backported their fixes. Please note it now requires python-nose as a build dependency now as well.

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks for enabling the test suite, good work! It proved itself that it's working, since it FTBFSed:

............E.......
======================================================================
ERROR: Failure: ImportError (No module named fixture)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/nose/loader.py", line 379, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/lib/pymodules/python2.6/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/lib/pymodules/python2.6/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/build/buildd/pastedeploy-1.3.3/tests/test_config_middleware.py", line 3, in <module>
    from paste.fixture import TestApp
ImportError: No module named fixture

----------------------------------------------------------------------
Ran 20 tests in 0.121s

Revision history for this message
Piotr Ożarowski (piotr) wrote :

I didn't look at your patch yet, but please note that all python-paste* packages share a namespace and paste.fixture is provided by python-paste package so if you're running tests with PYTHONPATH set to local paste directory that contains paste.deploy package only, it will not work even if python-paste is in Build-Depends (unless you'll modify __path__ to include system's paste)

Thierry Carrez (ttx)
Changed in pastedeploy (Ubuntu Lucid):
importance: Undecided → Wishlist
Revision history for this message
Chuck Short (zulcss) wrote :

The testsuite was fixed in the last upload. It should be ok for seeding now.

Regards
chuck

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks for fixing. Promoted.

Changed in pastedeploy (Ubuntu Lucid):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.