Disabling tap to click doesn't disable tap to click in scrollarea

Bug #509724 reported by Sebastian Keller
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Settings Daemon
Invalid
Low
gnome-settings-daemon (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: gnome-settings-daemon

Setting the gconf-key /desktop/gnome/peripherals/touchpad/tap_to_click to false changes the xinput property of "Synaptics Tap Action (258)" from "2, 3, 0, 0, 1, 3, 2" to "2, 3, 0, 0, 0, 0, 0". The first two entries however represent "RTCornerButton" and "RBCornerButton" and don't get set to 0, which means that there will be a click event for button 2 if you tap in the right top corner or 3 if you tap the right bottom corner. I guess it would be a good idea to set the 3rd and 4th entry to 0 too, in case there are some touchpad configurations that have these click events on the left instead of the right side.

Revision history for this message
Sebastian Keller (skeller) wrote :

Here is a small patch to fix this issue. Please note that I'm only assuming that LTCornerButton and LBCornerButton are used when the device is in lefthanded mode and the ones on the right are always disabled in this case since I never used a lefthanded touchpad and i don't know how it is supposed to work

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This bug is an upstream one and it would be quite helpful if somebody experiencing it could send the bug the to the people writing the software. You can learn more about how to do this for various upstreams at https://wiki.ubuntu.com/Bugs/Upstream. Thanks in advance!

Changed in gnome-settings-daemon (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Low
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks for sending upstream

Changed in gnome-settings-daemon (Ubuntu):
status: New → Triaged
Revision history for this message
Sebastian Keller (skeller) wrote :

According to upstream the default in the driver is 0 and ubuntu changed it to 2, 3. So this patch would be ubuntu-specific.

Revision history for this message
Sebastian Keller (skeller) wrote :

I looked at 103_enable_cornertapping.patch in xserver-xorg-input-synaptics now and there only the right corner tapping is used even if the touchpad is in lefthanded mode, so my previous patch was wrong. Here is an updated version.

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your change there, only corner clicks are enabled in lucid so tseliot recommended only changing the corner click option, the update change has been commited now and will be uploaded today

Changed in gnome-settings-daemon (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 2.29.6-0ubuntu2

---------------
gnome-settings-daemon (2.29.6-0ubuntu2) lucid; urgency=low

  * debian/patches/16_use_synchronous_notifications.patch,
    debian/patches/90_autoreconf.patch:
    - use correct ldflags variable and fix unresolved symbols issues
  * debian/patches/05_disable_corner_tapping.patch:
    - disable corner tapping when disabling tap to clik, thank Sebastian Keller
      (lp: #509724)
 -- Sebastien Bacher <email address hidden> Fri, 29 Jan 2010 11:30:51 +0100

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Sebastian Keller (skeller) wrote :

Reopening as the patch currently in the package only disables right-click but not middle-click. Maybe my comment in the patch was a bit misleading, I meant disable corner tapping on the right side of the touchpad, that includes right- and middle-click, as it is also possible to have corner tapping on the left side of the touchpad, which however is not changed in the synaptics-driver, so there is no need to change this here.

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

the change was made on purpose for the reason upstream is listing, there is no reason to unset middle click from gsd if the driver doesn't enable it in ubuntu...

Changed in gnome-settings-daemon (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Sebastian Keller (skeller) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

reopening since tseliot had a second look and confirmed he was wrong there and the first change was correct...

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Released → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

reopening since tseliot had a second look and confirmed he was wrong there and the first change was correct...

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 2.29.6-0ubuntu3

---------------
gnome-settings-daemon (2.29.6-0ubuntu3) lucid; urgency=low

  * debian/patches/05_disable_corner_tapping.patch:
    - upgraded previous change to change middle click too,
      thank Sebastian Keller (lp: #509724)
 -- Sebastien Bacher <email address hidden> Tue, 02 Feb 2010 14:57:32 -0800

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Changed in gnome-settings-daemon:
importance: Unknown → Low
status: Unknown → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.