res_currency.compute should check for currency differences before any rate fetch

This patch tries to solve this issue, checking firstly if to_currency_id==from_currency_id.

From the description of this bug, it looks like a wishlist / optimization, marking it so, and targetting for v6 (makes more sense right now - v5 only receives bugfixes)

If this is not the case, please explain what the bug is (as far as I can see if I attempt to create an invoice on a date where there is no currency conversion rate it correctly warns about it, so that must not be it).

Olivier it's OK to mark it as wishlist or optimization, as stated in the description, it's more a suggestion for optimizing existing code than a misfunction.

We should also double-check the code of compute for the "account.move.line" reference

This code must be removed from addons/base/res/res_currency.py
(remove the account arg also)

2 if account and (account.currency_mode=='average') and account.currency_id:
2 q = self.pool.get('account.move.line')._query_get(cr, uid, context=context)
2 cr.execute('select sum(debit-credit),sum(amount_currency) from account_move_line l ' \
2 'where l.currency_id=%s and l.account_id=%s and '+q, (account.currency_id.id,account.id,))
2 tot1,tot2 = cr.fetchone()

Hello,

This suggestion has been implemented, and we have also removed all references to "account" in "base" and moved all account-related code to the account module. This is effective as of the following revisions:
- server: rev. 3150 <email address hidden>
- addons: rev. 4042 <email address hidden>

Thanks reporting, this allowed us to improve other things as well!