Ubuntu
pyroom package

Autosave is not working

Bug #558347 reported by Ara Pulido
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
PyRoom
Fix Committed
Medium
Florian Heinle
pyroom (Ubuntu)
New
Undecided
Unassigned

Bug Description

Binary package hint: pyroom

Using pyroom in Lucid,

I set autosave every minute, but after several minutes without touching the document, the document has not been saved and I have to save it manually.

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: pyroom 0.4.1-2
ProcVersionSignature: Ubuntu 2.6.32-19.28-generic 2.6.32.10+drm33.1
Uname: Linux 2.6.32-19-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
CheckboxSubmission: a08fd14ff73f03f0a48f9e6d0af6c8e2
CheckboxSystem: bb422ca46d02494cdbc459927a98bc2f
Date: Thu Apr 8 12:36:07 2010
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: pyroom

Related branches

lp:pyroom
Revision history for this message
Ara Pulido (ara) wrote :
Jeff Lane  (bladernr)
Changed in pyroom:
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
Changed in pyroom (Ubuntu):
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
Martin Pitt (pitti)
Changed in pyroom:
assignee: Canonical Desktop Team (canonical-desktop-team) → nobody
Changed in pyroom (Ubuntu):
assignee: Canonical Desktop Team (canonical-desktop-team) → nobody
Revision history for this message
Tony Martínez (tonini500) wrote :

Fixed.

With this patch, the behaviour is:

- The backup files are saved in $HOME/.local/share/pyroom/autosave
- When a user saves a file, the backup is removed automatically. The backup will create again with a new autosave comes.

Revision history for this message
Tony Martínez (tonini500) wrote :

Sorry, added a little modification:
- When a user opens an existing file (and also that file has a backup), if user clicks on "Discard" button (= discard the backup file) in the dialog opened, the backup is deleted.

This is the correct patch.

Regards.

Brian Murray (brian-murray)
tags: added: patch
Revision history for this message
Adam Rooke (abelianr) wrote : Re: [Bug 558347] Re: Autosave is not working

This doesn't work for a new buffer - one that has yet to be saved to disk in
any form.

Is it necessary to append "." to the front of the file name in order to make
the auto save file a hidden file? Since the files are all in their own
directory I think it makes sense that they are visible by default.

Other than that, it seems to work as expected.

On 18 August 2010 23:56, Brian Murray <email address hidden> wrote:

> ** Tags added: patch
>
> --
> Autosave is not working
> https://bugs.launchpad.net/bugs/558347
> You received this bug notification because you are a member of PyRoom
> Bug Squad, which is subscribed to PyRoom.
>

Daniel Holbach (dholbach)
tags: added: patch-needs-work
Revision history for this message
Florian Heinle (tiax) wrote :

Hi,

I had a look at the patch trying to understand where the bug was. it seems that there was a typo in preferences.py that set autosavee instead of autosave and that would not re-enable autosave after it had been disabled.

I've taken this part of the patch and commited it to Revision 212 of trunk. For the other parts of the patch I'll be filing further bug reports.

Thanks, Tony!

Florian Heinle (tiax)
Changed in pyroom:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Florian Heinle (tiax)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.