quickly share creates GPG key with no email address and subsequently fails

Bug #567272 reported by Bruno Girin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Quickly
Fix Released
Medium
Didier Roche-Tolomelli
quickly (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: quickly

When using quickly share for the first time, quickly generates a GPG key. However, this key does not include an email address and quickly subsequently fails with the following error:

Your gpg key has been create. You have to upload it to Launchpad. Guidance is provided in Launchpad help. Press any key once done.
Traceback (most recent call last):
  File "/usr/share/quickly/templates/ubuntu-application/share.py", line 107, in <module>
    keyid = quicklyutils.get_right_gpg_key_id(launchpad)
  File "/usr/share/quickly/templates/ubuntu-application/internal/quicklyutils.py", line 375, in get_right_gpg_key_id
    os.putenv('DEBEMAIL', email)
TypeError: putenv() argument 2 must be string, not None
ERROR: share command failed

Steps to reproduce:
1. Create a project using quickly on a machine that has no GPG keys stored
2. Run quickly share in the project folder
3. Quickly generates a GPG key with no email address (e.g. John Smith <None>)
4. Register the key with Launchpad
5. Press ENTER in the window where "quickly share" is running to proceed

Actual behaviour
Quickly crashes

Expected behaviour
Quickly should request an email address from the user so that the created GPG key includes that address.

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: quickly 0.4-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.32-21.32-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-21-generic i686
Architecture: i386
Date: Tue Apr 20 15:25:46 2010
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta i386 (20100406.1)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_GB.utf8
 SHELL=/bin/bash
QuicklyDataPath: /usr/share/quickly
QuicklyTemplates:
 /usr/share/quickly/templates/ubuntu-application
 /usr/share/quickly/templates/ubuntu-cli
 /usr/share/quickly/templates/ubuntu-pygame
QuicklyTemplatesDirectories: /usr/share/quickly/templates/
SourcePackage: quickly

Revision history for this message
Bruno Girin (brunogirin) wrote :
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Ok, can reproduce the bug here.
Thanks for the detailed bug report that help reproduce it easily :)

Quickly shouldn't prompt for the email as it has already at least the one on Launchpad. If you launch quickly license before, it should have this one as well. The issue is just that I didn't putting out empty email adress from the detection algorithm as I was just thinking about the matching case (which is done to ensure that your gpg key corresponds to one adress email, and the distant one is the same), not the creation one. Having a looking to fix this now for 0.4.1

Changed in quickly (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Changed in quickly:
assignee: nobody → Didier Roche (didrocks)
importance: Undecided → Medium
status: New → In Progress
Changed in quickly:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quickly - 0.4.1-0ubuntu1

---------------
quickly (0.4.1-0ubuntu1) lucid; urgency=low

  * New bugfix upstream release:
    ubuntu-application template (and inherited):
    - add more debugging info in --verbose mode for gpg keys
    - remove ~/.selected_editor detection. Introduced confusion for users
      (LP: #565586)
    - better message and user help when ppa not found (LP: #565581)
    - fix again some tutorial issues which had been lost during html -> docbook
      transition (LP: #499356)
    - fix gpg key creation with no email address (LP: #567272)
    - Updated translations
 -- Didier Roche <email address hidden> Fri, 23 Apr 2010 16:24:58 +0200

Changed in quickly (Ubuntu):
status: Triaged → Fix Released
Changed in quickly:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.